[CP-Beta] Cherry-pick ninja+cmake deps #178244
Conversation
Pulls in flutter#178054 and flutter#178079 Please note there is one "bringup: true" in this change: bringup: true # Failing: flutter#178060
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request cherry-picks changes to add clang, cmake, and ninja as dependencies to multiple CI targets in .ci.yaml. In accordance with the repository's style guide, which states that cherry-picks to non-master branches have already been reviewed, I am not providing detailed review comments. However, I noted significant duplication of the new dependency block across many targets. To improve maintainability, this could be addressed on the master branch, for instance by using YAML anchors if the CI system supports them.
|
Will fix #178178 once landed / rebased. |
jtmcdole
added
the
autosubmit
auto-submit
bot
merged commit fd7f423
into
flutter:flutter-3.38-candidate.0
2 participants
Pulls in #178054 and #178079
Please note there is one "bringup: true" in this change:
bringup: true # Failing: #178060