Skip to content

Make sure that a TextField doesn't crash in 0x0 environment #178232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Nov 11, 2025
Merged

Make sure that a TextField doesn't crash in 0x0 environment #178232

auto-submit merged 1 commit into from
Nov 11, 2025

Conversation

@ahmedsameha1
Copy link
Contributor

@ahmedsameha1 ahmedsameha1 commented Nov 10, 2025

This is my attempt to handle #6537 for the TextField widget.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Nov 10, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 10, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a regression test to ensure that a TextField does not crash when it has a zero-size area. The test case correctly simulates the scenario by setting the view's physical size to zero and then triggering a selection change. My feedback includes a minor suggestion to improve test hygiene by reordering the addTearDown calls to follow the recommended resource cleanup order.

packages/flutter/test/material/text_field_test.dart Outdated
Comment on lines 18906 to 18907
addTearDown(controller.dispose);
addTearDown(tester.view.reset);
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better test hygiene, it's generally safer to dispose of resources in the reverse order of their allocation. In this test, the TextEditingController is created after the tester.view is modified. Therefore, the controller should be disposed of before resetting the view.

The addTearDown function executes callbacks in the reverse order of their registration. To ensure controller.dispose() is called before tester.view.reset(), you should register tester.view.reset first.1

    addTearDown(tester.view.reset);
    addTearDown(controller.dispose);

Style Guide References

Footnotes

  1. ↩

@victorsanni victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 11, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Nov 11, 2025
Merged via the queue into flutter:master with commit 951b3ca Nov 11, 2025
76 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 11, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 11, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
2ff972a 
…flutter/flutter#178232)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 11, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
027db9e 
…flutter/flutter#178232)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 11, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
b54b24f 
…flutter/flutter#178232)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
c23906e 
…flutter/flutter#178232)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
8681144 
…flutter/flutter#178232)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
a1ee4f3 
…flutter/flutter#178232)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
b717286 
…flutter/flutter#178232)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
9f1a8b5 
…flutter/flutter#178232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
1a49e45 
…flutter/flutter#178232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
f9e8264 
…flutter/flutter#178232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
fa40e9a 
…flutter/flutter#178232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
3c33c89 
…flutter/flutter#178232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
fc57f28 
…flutter/flutter#178232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
f788b6a 
…flutter/flutter#178232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
8499424 
…flutter/flutter#178232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
1a00d97 
…flutter/flutter#178232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
01728ea 
…flutter/flutter#178232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 16, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
fc3a59a 
…flutter/flutter#178232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 16, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
2f27753 
…flutter/flutter#178232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 16, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
cb2f54a 
…flutter/flutter#178232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
c7a7cdc 
…flutter/flutter#178232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
a131dc4 
…flutter/flutter#178232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
54a9dcc 
…flutter/flutter#178232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
326dc97 
…flutter/flutter#178232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
d7b0982 
…flutter/flutter#178232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025
@engine-flutter-autoroll
951b3cad0 Make sure that a TextField doesn't crash in 0x0 environment (…
ef7e9e1 
…flutter/flutter#178232)
IvoneDjaja pushed a commit to IvoneDjaja/flutter that referenced this pull request Nov 22, 2025
@ahmedsameha1 @IvoneDjaja
Make sure that a TextField doesn't crash in 0x0 environment (flutter#…
7a41ad5 
…178232)

This is my attempt to handle
flutter#6537 for the TextField widget.
mboetger pushed a commit to mboetger/flutter that referenced this pull request Dec 2, 2025
@ahmedsameha1 @mboetger
Make sure that a TextField doesn't crash in 0x0 environment (flutter#…
4c7dde7 
…178232)

This is my attempt to handle
flutter#6537 for the TextField widget.
reidbaker pushed a commit to AbdeMohlbi/flutter that referenced this pull request Dec 10, 2025
@ahmedsameha1 @reidbaker
Make sure that a TextField doesn't crash in 0x0 environment (flutter#…
691d6d0 
…178232)

This is my attempt to handle
flutter#6537 for the TextField widget.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

@victorsanni victorsanni victorsanni approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahmedsameha1 @dkwingsmt @victorsanni