Check for devicectl launch logs from std and file #178167

vashworth · 2025-11-07T16:19:02Z

For some reason in different editors, devicectl does not appear to stream its logs to stdout. Usually after calling xcrun devicectl device process launch --console ..., the stdout stream will receive a log of 'Waiting for the application to terminate'. To workaround this, we use the --log-ouput flag with the devicectl command, which tells devicectl to write its logs to a file. We then periodically read the file looking for the 'Waiting for the application to terminate' log.

Fixes b/454953393.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

vashworth · 2025-11-07T16:19:57Z

@bkonyi Let me know if you have any better ideas for this. This is a hacky workaround because I couldn't figure out why the stdout stream isn't receiving the expected logs (see PR description)

gemini-code-assist

Code Review

This pull request introduces a workaround for an issue where devicectl does not reliably stream logs to stdout. It adds a mechanism to poll a log file for a specific message to confirm app launch. While the approach is sound, I've identified a few issues related to resource management, race conditions, and synchronous I/O that should be addressed to improve the robustness and correctness of the implementation. My review includes suggestions to fix a resource leak, prevent race conditions, and use asynchronous I/O.

packages/flutter_tools/lib/src/ios/core_devices.dart

bkonyi · 2025-11-07T16:48:59Z

I don't have any better ideas, unfortunately. Maybe @chingjun or @helin24 will have some idea since this is apparently a Cider-V specific issue.

bkonyi

LGTM once Gemini's comments are addressed.

helin24 · 2025-11-07T19:36:11Z

Hmm that's strange! I don't know enough about the flutter tooling to have any theories about why this may be. Thanks for addressing the issue though.

…flutter#178167)

For some reason in different editors, `devicectl` does not appear to stream its logs to `stdout`. Usually after calling `xcrun devicectl device process launch --console ...`, the `stdout` stream will receive a log of `'Waiting for the application to terminate'`. To workaround this, we use the `--log-ouput` flag with the `devicectl` command, which tells `devicectl` to write its logs to a file. We then periodically read the file looking for the `'Waiting for the application to terminate'` log. Fixes b/454953393. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…flutter#178167)

Reverts #178167 and instead runs `devicectl` in interactive mode by prefixing command with `script -t 0 /dev/null` to convince `devicectl` it has a terminal attached in order to redirect stdout. Fixes b/454953393. Related to #178319. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

) Reverts flutter#178167 and instead runs `devicectl` in interactive mode by prefixing command with `script -t 0 /dev/null` to convince `devicectl` it has a terminal attached in order to redirect stdout. Fixes b/454953393. Related to flutter#178319. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

For some reason in different editors, `devicectl` does not appear to stream its logs to `stdout`. Usually after calling `xcrun devicectl device process launch --console ...`, the `stdout` stream will receive a log of `'Waiting for the application to terminate'`. To workaround this, we use the `--log-ouput` flag with the `devicectl` command, which tells `devicectl` to write its logs to a file. We then periodically read the file looking for the `'Waiting for the application to terminate'` log. Fixes b/454953393. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

) Reverts flutter#178167 and instead runs `devicectl` in interactive mode by prefixing command with `script -t 0 /dev/null` to convince `devicectl` it has a terminal attached in order to redirect stdout. Fixes b/454953393. Related to flutter#178319. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

For some reason in different editors, `devicectl` does not appear to stream its logs to `stdout`. Usually after calling `xcrun devicectl device process launch --console ...`, the `stdout` stream will receive a log of `'Waiting for the application to terminate'`. To workaround this, we use the `--log-ouput` flag with the `devicectl` command, which tells `devicectl` to write its logs to a file. We then periodically read the file looking for the `'Waiting for the application to terminate'` log. Fixes b/454953393. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

) Reverts flutter#178167 and instead runs `devicectl` in interactive mode by prefixing command with `script -t 0 /dev/null` to convince `devicectl` it has a terminal attached in order to redirect stdout. Fixes b/454953393. Related to flutter#178319. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Reverts #176063 Fixes: #179667 Git bisect: ``` ❯ git bisect log # bad: [5b74a3b] Check for a null cached image in SingleFrameCodec::getNextFrame (#179483) # good: [66dd93f] Bump engine version for Flutter 3.38.4 stable hotfix. (#179424) git bisect start 'master' 'flutter-3.38-candidate.0' # good: [df87ee3] Roll Skia from d10a0d877ff4 to ea7cdbc6b986 (15 revisions) (#176686) git bisect good df87ee3 # good: [951b25d] Check for devicectl launch logs from std and file (#178167) git bisect good 951b25d # good: [337bbfb] Potentially fixing the flakiness in win32 windowing tests, but it needs some running (#178499) git bisect good 337bbfb # good: [8e952d6] Roll Skia from c20f797ab6f9 to 81a9a0751f00 (5 revisions) (#179417) git bisect good 8e952d6 # good: [723fec5] Roll Skia from e19670f70406 to dccd48c6c6ab (6 revisions) (#179524) git bisect good 723fec5 # bad: [96c6525] Roll Dart SDK from 3c07646cdcb9 to 019cb923bf62 (1 revision) (#179595) git bisect bad 96c6525 # good: [4000ce2] Implementation of `TestWindowingOwner` for testing multi-window (#179355) git bisect good 4000ce2 # good: [26f311c] Roll Dart SDK from 75899721aa42 to 3c07646cdcb9 (1 revision) (#179587) git bisect good 26f311c # bad: [8cc9fee] Roll Skia from b1936c760645 to 00e6fc407968 (5 revisions) (#179589) git bisect bad 8cc9fee # bad: [b37b6fa] Change GenerateFilledArcStrip to use non-overlapping triangles (#179292) git bisect bad b37b6fa # bad: [f197a3a] Android implementation of content sizing (#176063) git bisect bad f197a3a # first bad commit: [f197a3a] Android implementation of content sizing (#176063) ```

vashworth added 2 commits October 31, 2025 11:21

Use both stdout and file output to check if app launched

cca027e

Add test

c1fd2c4

vashworth requested a review from a team as a code owner November 7, 2025 16:19

vashworth requested review from bkonyi and removed request for a team November 7, 2025 16:19

github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. team-ios Owned by iOS platform team labels Nov 7, 2025

gemini-code-assist bot reviewed Nov 7, 2025

View reviewed changes

packages/flutter_tools/lib/src/ios/core_devices.dart Outdated Show resolved Hide resolved

packages/flutter_tools/lib/src/ios/core_devices.dart Outdated Show resolved Hide resolved

bkonyi approved these changes Nov 7, 2025

View reviewed changes

vashworth and others added 2 commits November 7, 2025 16:25

feedback

30396e2

Merge branch 'master' into devicectl_launch_logs_fix

24e3df4

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 10, 2025

auto-submit bot added this pull request to the merge queue Nov 10, 2025

Merged via the queue into flutter:master with commit 951b25d Nov 10, 2025
145 of 146 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 10, 2025

engine-flutter-autoroll mentioned this pull request Nov 11, 2025

Roll Flutter from 31a8481cd14c to 2981516d74bc (58 revisions) flutter/packages#10398

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 11, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

81b4abb

…flutter#178167)

engine-flutter-autoroll mentioned this pull request Nov 11, 2025

Roll Flutter from 31a8481cd14c to 2c817be69eae (59 revisions) flutter/packages#10399

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 11, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

4623abc

…flutter#178167)

engine-flutter-autoroll mentioned this pull request Nov 11, 2025

Manual roll Flutter from 31a8481cd14c to 2c817be69eae (59 revisions) flutter/packages#10401

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 11, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

66385b9

…flutter#178167)

vashworth mentioned this pull request Nov 11, 2025

[beta/stable] Running from VS Code on physical iOS 26 device hangs #178319

Closed

engine-flutter-autoroll mentioned this pull request Nov 12, 2025

Roll Flutter from 31a8481cd14c to 6d6c0bb4db95 (77 revisions) flutter/packages#10404

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

2c743a0

…flutter#178167)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

64660be

…flutter#178167)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

188cbd8

…flutter#178167)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

ee7f5ae

…flutter#178167)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

a195e29

…flutter#178167)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

e1d56e1

…flutter#178167)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

30ed7c0

…flutter#178167)

jmagman mentioned this pull request Nov 14, 2025

After upgrading to Flutter 3.38.0, VSCode/Cursor cannot run debug mode on a real iPhone #178421

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

222fc69

…flutter#178167)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

ddd8d22

…flutter#178167)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

8838fde

…flutter#178167)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 16, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

85d2dce

…flutter#178167)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 16, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

2068814

…flutter#178167)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 16, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

c27cc4c

…flutter#178167)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

354a6ac

…flutter#178167)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

ad86f47

…flutter#178167)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

448990e

…flutter#178167)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

abd18c2

…flutter#178167)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

037355b

…flutter#178167)

vashworth added the cp: stable cherry pick this pull request to stable release candidate branch label Nov 17, 2025

vashworth added the cp: beta cherry pick this pull request to beta release candidate branch label Nov 17, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025

951b25d24 Check for devicectl launch logs from std and file (flutter/…

4876e36

…flutter#178167)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Check for devicectl launch logs from std and file #178167

Check for devicectl launch logs from std and file #178167

Uh oh!

vashworth commented Nov 7, 2025

Uh oh!

vashworth commented Nov 7, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

bkonyi commented Nov 7, 2025

Uh oh!

bkonyi left a comment

Uh oh!

helin24 commented Nov 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Check for devicectl launch logs from std and file #178167

Check for devicectl launch logs from std and file #178167

Uh oh!

Conversation

vashworth commented Nov 7, 2025

Pre-launch Checklist

Uh oh!

vashworth commented Nov 7, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

bkonyi commented Nov 7, 2025

Uh oh!

bkonyi left a comment

Choose a reason for hiding this comment

Uh oh!

helin24 commented Nov 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants