Skip to content

[web] Remove image codecs from canvaskit_chromium #178133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mdebbar wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[web] Remove image codecs from canvaskit_chromium #178133

mdebbar wants to merge 7 commits into from
+62 −63

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Nov 6, 2025 •
edited
Loading

Fixes #122331

Build with image codecs (before) without image codecs (after) Difference %
canvaskit_chromium 1.54 MB 1.45 MB $${\color{green}9\%}$$
canvaskit_webparagraph 1.12 MB 1.01 MB $${\color{green}10\%}$$

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Nov 6, 2025
@github-actions github-actions bot added the platform-web Web applications specifically label Nov 7, 2025
@kevmoo
Copy link
Contributor

kevmoo commented Nov 7, 2025

This makes uploaded bits smaller, right? By how much?
Have we confirmed on older Chrome builds? When was this fixed?

@mdebbar
Copy link
Contributor Author

mdebbar commented Nov 7, 2025

This makes uploaded bits smaller, right? By how much?

Yes, added the numbers to the PR description. It's ±100KB smaller.

Have we confirmed on older Chrome builds? When was this fixed?

This PR is a no-op for apps (other than making CanvasKit's size smaller). The web engine has been using the browser ImageDecoder exclusively on Chrome for quite a while now. There was one remaining edge case that required Skia decoders, but that was addressed in flutter/engine#53201 more than a year ago.

TL;DR: Flutter web apps today in Chrome are already not using the Skia decoders. This PR is removing the unused decoders to save size.

@mdebbar mdebbar marked this pull request as ready for review November 12, 2025 20:40
harryterkelsen
harryterkelsen approved these changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

engine/src/flutter/lib/web_ui/test/canvaskit/canvaskit_api_test.dart

void _imageTests() {
test('MakeAnimatedImageFromEncoded makes a non-animated image', () {
if (configuration.canvasKitVariant == CanvasKitVariant.chromium) {
Copy link
Contributor

@harryterkelsen harryterkelsen Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use skip: instead

Copy link
Contributor Author

@mdebbar mdebbar Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was the first thing I tried :)

It doesn't work because the configuration object is initialized after skip is evaluated. The configuration value is initialized in a setUpAll callback, so the only reliable place to get the correct value of configuration.canvasKitVariant is inside the test body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harryterkelsen harryterkelsen harryterkelsen approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. platform-web Web applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[web] Remove image codecs from CanvasKit Chromium

3 participants

@mdebbar @kevmoo @harryterkelsen