Skip to content

Conversation

@guidezpl
Copy link
Member

@guidezpl guidezpl commented Nov 6, 2025

These are raised by the analyzer, following #173715

These are raised by the analyzer
@github-actions github-actions bot added the d: examples Sample code and demos label Nov 6, 2025
@guidezpl guidezpl requested a review from mattkae November 6, 2025 12:33
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds flutter_lints as a dev_dependency to the pubspec.yaml files for windowing_test and multiple_windows. This is a necessary fix, as both packages include flutter_lints in their analysis_options.yaml for static analysis but were missing the explicit dependency declaration.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 6, 2025
@github-actions github-actions bot removed the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 13, 2025
@guidezpl guidezpl requested a review from QuncCccccc November 13, 2025 17:47
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this @guidezpl. The failing test appears to be a timeout.

FYI @mattkae

Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@guidezpl guidezpl enabled auto-merge November 18, 2025 09:40
@guidezpl guidezpl added this pull request to the merge queue Nov 18, 2025
Merged via the queue into flutter:master with commit 8ccb48b Nov 18, 2025
147 checks passed
@guidezpl guidezpl deleted the fix-dependencies branch November 18, 2025 10:39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 18, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 18, 2025
flutter/flutter@cc14ef5...cb7b7df

2025-11-18 [email protected] Enable UIScene Migration and update create templates (flutter/flutter#178700)
2025-11-18 Minsuk Jung Fix #160622: change containsWatchConpanion function to detect companion watch apps defined by only the project info file. (flutter/flutter#176832)
2025-11-18 [email protected] Roll Skia from 614e71550fc3 to ca906091e199 (2 revisions) (flutter/flutter#178716)
2025-11-18 [email protected] Revert "[ Tool ] Don't delete `.dart_tool/widget_preview_scaffold` during `flutter clean` (#175664)" (flutter/flutter#178672)
2025-11-18 [email protected] Add missing flutter_lints dev dependencies (flutter/flutter#178105)
2025-11-18 [email protected] Roll Skia from ec2f626cdcad to 614e71550fc3 (3 revisions) (flutter/flutter#178708)
2025-11-18 [email protected] Roll Dart SDK from a8ad764281e3 to 312845b06afc (1 revision) (flutter/flutter#178704)
2025-11-18 [email protected] Roll Skia from d7268f8245f2 to ec2f626cdcad (1 revision) (flutter/flutter#178703)
2025-11-18 [email protected] Refactor SnackBar behavior selection example to use `RadioGroup` (flutter/flutter#178618)
2025-11-18 [email protected] Add framework-side hitTestBehavior support for Semantics widget and apply to ModalRoute (flutter/flutter#177570)
2025-11-18 [email protected] Fix deprecation warning in some API examples using RadioListTile (flutter/flutter#178635)
2025-11-18 [email protected] Roll Skia from 47fd0d9b1044 to d7268f8245f2 (6 revisions) (flutter/flutter#178695)
2025-11-18 [email protected] Roll Dart SDK from cf94632d94a1 to a8ad764281e3 (1 revision) (flutter/flutter#178694)
2025-11-18 [email protected] [fuchsia] Add wrapper for zx_iob_writev (flutter/flutter#178626)
2025-11-17 [email protected] Make a11y `computeChildGeometry` slightly faster (flutter/flutter#177477)
2025-11-17 [email protected] Fix DropdownMenu width when decorationBuilder provides label (flutter/flutter#178465)
2025-11-17 [email protected] Add DropdownMenuFormField.decorationBuilder (flutter/flutter#178640)
2025-11-17 [email protected] Roll Skia from 84c83c0dfb4a to 47fd0d9b1044 (4 revisions) (flutter/flutter#178673)
2025-11-17 [email protected] Small cleanup in `AndroidTouchProcessor.java‎` (flutter/flutter#178574)
2025-11-17 [email protected] Remove unnecessary `final` modifier in `StandardMessageCodec.java‎` (flutter/flutter#178598)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
IvoneDjaja pushed a commit to IvoneDjaja/flutter that referenced this pull request Nov 22, 2025
mboetger pushed a commit to mboetger/flutter that referenced this pull request Dec 2, 2025
reidbaker pushed a commit to AbdeMohlbi/flutter that referenced this pull request Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

d: examples Sample code and demos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants