Reland "Refactor OverlayPortal semantics (#173005)" #178095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: tests
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request relands the refactoring of OverlayPortal semantics and includes a fix for an infinite loop. The changes introduce traversalParent and hitTestTransform to correctly handle semantics for overlays, separating traversal order from paint/hit-test order. This is a significant and wide-ranging change across the engine and framework. The implementation is mostly solid, but I have identified a few areas for improvement. I've pointed out a potential race condition in the semantics update logic, a minor bug in aria-owns handling on the web, and a code duplication in the C++ part of the engine.
QuncCccccc
force-pushed
the
revert-178007-revert-173005
branch
2 times, most recently
from
455d99f to
fb7cc8f
Compare
QuncCccccc
commented
Nov 6, 2025
| required String? identifier, | ||
| required Object? traversalParentIdentifier, | ||
| required Set<Object>? traversalChildIdentifier, | ||
| required Object? traversalChildIdentifier, |
Contributor
Author
There was a problem hiding this comment.
This should be Object instead of Set<Object>?. This is missed because we haven't directly used it in OverlayPortal. Catched this when adding tests.
QuncCccccc
force-pushed
the
revert-178007-revert-173005
branch
from
fb7cc8f to
87a7eb5
Compare
chunhtai
reviewed
Nov 6, 2025
| // updatedChildren list. | ||
| continue; | ||
| // | ||
| // A corner case is the traversal parent of the traversal child, in paint |
Contributor
There was a problem hiding this comment.
so something like this?
// assume root node id is 0
Semantics(
// assume semantics node id = 1
traversalParent: 'key',
child: Semantics(
// assume semantics node id = 2
traversalChildren: 'key',
)
)
In this case I assume we want the hittest tree to be
0 -> 1 -> 2
but traversal tree to be
0 -> 2 -> 1
Contributor
Author
There was a problem hiding this comment.
Talked with @chunhtai offline. In this case we throw exception to indicate wrong parent-child relationship. Also update SemanticsConfiguration.isCompatibleWith to avoid implicit merging.
QuncCccccc
force-pushed
the
revert-178007-revert-173005
branch
from
85c3596 to
ddf67f6
Compare
QuncCccccc
force-pushed
the
revert-178007-revert-173005
branch
from
ddf67f6 to
4e9b287
Compare
QuncCccccc
force-pushed
the
revert-178007-revert-173005
branch
from
7d4f799 to
1c1aa5a
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
IvoneDjaja
pushed a commit
to IvoneDjaja/flutter
that referenced
this pull request
Nov 22, 2025
…78095) Reverts flutter#178007 This PR is to reland flutter#173005 and add a fix to avoid infinite loop. The fix doesn't contain engine changes.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
…78095) Reverts flutter#178007 This PR is to reland flutter#173005 and add a fix to avoid infinite loop. The fix doesn't contain engine changes.
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…78095) Reverts flutter#178007 This PR is to reland flutter#173005 and add a fix to avoid infinite loop. The fix doesn't contain engine changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #178007
This PR is to reland #173005 and add a fix to avoid infinite loop. The fix doesn't contain engine changes.