Fix DropdownMenu escape key does not close the menu #178002

bleroux · 2025-11-04T18:40:21Z

Description

This PR fixes escape key not closing the menu when DropdownMenu.requestFocusOnTap is false.

Related Issue

Fixes DropdownMenu menu panel does not close when pressing ESC and requestFocusOnTap is false
Part of #123797

Tests

Adds 3 tests.
Updates 2 non-related tests where I spotted some nits.

gemini-code-assist

Code Review

This pull request provides a solid fix for an issue where the DropdownMenu could not be closed with the escape key when requestFocusOnTap is false. The implementation correctly uses Actions and Shortcuts to handle the DismissIntent. The accompanying tests are thorough, covering both the fix and potential regressions. The test refactoring, including the adoption of tester.sendKeyEvent and improved naming, enhances the overall quality of the test suite. The changes are well-executed and ready to merge.

gemini-code-assist

Code Review

This pull request correctly fixes an issue where the DropdownMenu could not be closed with the Escape key when requestFocusOnTap is false. The fix is implemented by properly adding a DismissIntent and a corresponding shortcut for the Escape key. The change is well-supported by new regression tests that cover both requestFocusOnTap states, as well as a more complex interaction scenario. Additionally, many existing tests were cleaned up for consistency and to use modern testing APIs, which improves the overall quality of the test suite. The changes are solid and address the problem effectively.

packages/flutter/test/material/dropdown_menu_test.dart

justinmc

LGTM 👍

justinmc · 2025-11-04T22:50:28Z

packages/flutter/test/material/dropdown_menu_test.dart

+      await tester.pump();
+      expect(findMenuPanel(), findsNothing);
+    },
+    variant: TargetPlatformVariant.all(),


Nit: I think you shouldn't need TargetPlatformVariant.all for any of these tests, unless there's specifically platform-dependent stuff happening here. This will end up getting tested on all platforms by CI anyway.

I used TargetPlatformVariant.all() because those tests depends on DropdownMenu.requestFocusOnTap value which is platform dependent.

But you're right that this is not needed for the two first tests I added because in these tests DropdownMenu.requestFocusOnTap is explicitly set. I pushed a commit to remove TargetPlatformVariant.all() usage for these tests.

auto-submit · 2025-11-06T00:09:18Z

autosubmit label was removed for flutter/flutter/178002, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…r/flutter#178002)

flutter/flutter@e5d5c01...c5e809a 2025-11-06 [email protected] Remove WindowingOwner.hasTopLevelWindows (flutter/flutter#178033) 2025-11-06 [email protected] Fix DropdownMenu escape key does not close the menu (flutter/flutter#178002) 2025-11-06 [email protected] Update documentation tool reference in image.dart (flutter/flutter#177782) 2025-11-06 [email protected] Roll Skia from 4eb2383d38f2 to 5c4e1352128f (5 revisions) (flutter/flutter#178094) 2025-11-06 [email protected] Revert "Refactor OverlayPortal semantics (#173005)" (flutter/flutter#178007) 2025-11-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix verified input test failure in CI (attempt 4) (#178018)" (flutter/flutter#178089) 2025-11-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] Unify Surface code between Skwasm and CanvasKit (#177138)" (flutter/flutter#178085) 2025-11-05 [email protected] Fix verified input test failure in CI (attempt 4) (flutter/flutter#178018) 2025-11-05 [email protected] fix: inconsistent horizontal spacing between hours and mins in time picker for non-english language (flutter/flutter#173706) 2025-11-05 [email protected] Roll Fuchsia Linux SDK from mpsxF1gd-jbKNvmpm... to cm88aTLui5yorSGYQ... (flutter/flutter#178074) 2025-11-05 [email protected] Fix(ios): Remove arm64 exclusion to support Xcode 26 simulators (flutter/flutter#177065) 2025-11-05 [email protected] Roll Skia from 2ff897e9b440 to 4eb2383d38f2 (18 revisions) (flutter/flutter#178070) 2025-11-05 [email protected] [web] Unify Surface code between Skwasm and CanvasKit (flutter/flutter#177138) 2025-11-05 [email protected] Update more missing ninja deps (flutter/flutter#178079) 2025-11-05 [email protected] Add ninja / cmake deps to failing tests (flutter/flutter#178054) 2025-11-05 [email protected] [web] Don't add webparagraph suite to CI (flutter/flutter#177681) 2025-11-05 [email protected] Fixing broken link in engine readme (flutter/flutter#177987) 2025-11-05 [email protected] Print reason for adb command failure in verified input test (attempt 3) (flutter/flutter#178005) 2025-11-05 [email protected] Fix `ReorderableList` items jumping when drag direction reverses mid-animation (flutter/flutter#173241) 2025-11-05 [email protected] Replace deprecated `withOpacity` in `overflow_bar.0.dart‎` example (flutter/flutter#177813) 2025-11-05 [email protected] Replace deprecated `withOpacity` in `data_table.1.dart‎` example (flutter/flutter#177812) 2025-11-05 [email protected] Replace deprecated `withOpacity` in `switch.1.dart` example (flutter/flutter#177811) 2025-11-04 [email protected] Roll Skia from c89b6118266b to 2ff897e9b440 (6 revisions) (flutter/flutter#177999) 2025-11-04 [email protected] Fix verified input test in CI (attempt 2) (flutter/flutter#177961) 2025-11-04 [email protected] Replace rendering for solid color circles (both filled and stroked) to use SDFs (flutter/flutter#177482) 2025-11-04 [email protected] Roll Fuchsia Linux SDK from vxK5obzfr1X9P2kSh... to mpsxF1gd-jbKNvmpm... (flutter/flutter#177996) 2025-11-04 [email protected] Validate that platforms specified in .ci.yaml target names match the platforms defined in the platform_properties section (flutter/flutter#177523) 2025-11-04 [email protected] Roll Packages from 1a7075b to 3d926aa (6 revisions) (flutter/flutter#177998) 2025-11-04 [email protected] Remove dead code from snippet_generator (flutter/flutter#174440) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

## Description This PR fixes escape key not closing the menu when `DropdownMenu.requestFocusOnTap` is false. ## Related Issue Fixes [DropdownMenu menu panel does not close when pressing ESC and requestFocusOnTap is false](flutter#177993) Part of flutter#123797 ## Tests - Adds 3 tests. - Updates 2 non-related tests where I spotted some nits.

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Nov 4, 2025

gemini-code-assist bot reviewed Nov 4, 2025

View reviewed changes

packages/flutter/test/material/dropdown_menu_test.dart Outdated Show resolved Hide resolved

bleroux force-pushed the fix_DropdownMenu_escape_key_does_not_close_the_menu branch from 62386c0 to f030950 Compare November 4, 2025 19:05

bleroux requested a review from justinmc November 4, 2025 21:44

justinmc approved these changes Nov 4, 2025

View reviewed changes

bleroux force-pushed the fix_DropdownMenu_escape_key_does_not_close_the_menu branch from f030950 to 47f39c7 Compare November 5, 2025 09:33

bleroux added 2 commits November 5, 2025 22:41

Fix DropdownMenu escape key does not close the menu

93133cf

Remove TargetPlatformVariant.all() for 2 tests

a5a524e

bleroux force-pushed the fix_DropdownMenu_escape_key_does_not_close_the_menu branch from 47f39c7 to a5a524e Compare November 5, 2025 21:41

bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 5, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 6, 2025

bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 6, 2025

auto-submit bot added this pull request to the merge queue Nov 6, 2025

Merged via the queue into flutter:master with commit c093967 Nov 6, 2025
78 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 6, 2025

bleroux deleted the fix_DropdownMenu_escape_key_does_not_close_the_menu branch November 6, 2025 11:14

engine-flutter-autoroll mentioned this pull request Nov 6, 2025

Roll Flutter from e5d5c01850f2 to c5e809a998fe (29 revisions) flutter/packages#10369

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2025

c093967de Fix DropdownMenu escape key does not close the menu (flutte…

803ea07

…r/flutter#178002)

engine-flutter-autoroll mentioned this pull request Nov 6, 2025

Roll Flutter from e5d5c01850f2 to 6925f8b815ea (30 revisions) flutter/packages#10370

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2025

c093967de Fix DropdownMenu escape key does not close the menu (flutte…

459ec8a

…r/flutter#178002)

engine-flutter-autoroll mentioned this pull request Nov 6, 2025

Roll Flutter from e5d5c01850f2 to aebe02b44fe2 (31 revisions) flutter/packages#10371

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2025

c093967de Fix DropdownMenu escape key does not close the menu (flutte…

8b4d9a9

…r/flutter#178002)

engine-flutter-autoroll mentioned this pull request Nov 6, 2025

Roll Flutter from e5d5c01850f2 to c45883383950 (32 revisions) flutter/packages#10372

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2025

c093967de Fix DropdownMenu escape key does not close the menu (flutte…

e5f5968

…r/flutter#178002)

engine-flutter-autoroll mentioned this pull request Nov 6, 2025

Roll Flutter from e5d5c01850f2 to ac3b91db0dcc (33 revisions) flutter/packages#10373

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2025

c093967de Fix DropdownMenu escape key does not close the menu (flutte…

3ac9b5f

…r/flutter#178002)

engine-flutter-autoroll mentioned this pull request Nov 6, 2025

Roll Flutter from e5d5c01850f2 to 7dc982e1b16d (34 revisions) flutter/packages#10375

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2025

c093967de Fix DropdownMenu escape key does not close the menu (flutte…

a3461f4

…r/flutter#178002)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix DropdownMenu escape key does not close the menu #178002

Fix DropdownMenu escape key does not close the menu #178002

Uh oh!

bleroux commented Nov 4, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

justinmc left a comment

Uh oh!

justinmc Nov 4, 2025

Uh oh!

bleroux Nov 5, 2025 •

edited

Loading

Uh oh!

auto-submit bot commented Nov 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix DropdownMenu escape key does not close the menu #178002

Fix DropdownMenu escape key does not close the menu #178002

Uh oh!

Conversation

bleroux commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Tests

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

bleroux Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Nov 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bleroux commented Nov 4, 2025 •

edited

Loading

bleroux Nov 5, 2025 •

edited

Loading