[engine,build] Fix Fuchsia RBE build #177865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Fuchsia build configuration to fix issues with Remote Build Execution (RBE). The main changes include explicitly listing the __config_site file as a build input for RBE workers and removing now-unnecessary target_triple and sysroot flags from the toolchain definition, as these are handled by the Fuchsia build configs. Additionally, compiler commands are updated to use -MMD instead of -MD for dependency generation, which is a good improvement.
zanderso
force-pushed
the
fix-fuchsia-rbe
branch
from
97ed0cf to
110f01d
Compare
zanderso
force-pushed
the
fix-fuchsia-rbe
branch
from
110f01d to
017887f
Compare
jason-simmons
approved these changes
Nov 1, 2025
jtmcdole
approved these changes
Nov 1, 2025
zanderso
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 2, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 4, 2025
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
As in the Dart build here: https://github.com/dart-lang/sdk/blame/fc8b3d79277c55f613423e125f49c80643d2498a/build/toolchain/fuchsia/fuchsia_toolchain.gni#L24 For unknown reasons, the `__config_site` file has to be explicitly listed as an input to the build to ensure it is available in the RBE workers. This PR also cleans up unnecessary flags from the Fuchsia toolchain definition. The target triple and sysroot flags are already injected into the compiler flags by the Fuchsia build configs. linux_fuchsia presub ran in 16 minutes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in the Dart build here:
https://github.com/dart-lang/sdk/blame/fc8b3d79277c55f613423e125f49c80643d2498a/build/toolchain/fuchsia/fuchsia_toolchain.gni#L24
For unknown reasons, the
__config_sitefile has to be explicitly listed as an input to the build to ensure it is available in the RBE workers.This PR also cleans up unnecessary flags from the Fuchsia toolchain definition. The target triple and sysroot flags are already injected into the compiler flags by the Fuchsia build configs.
linux_fuchsia presub ran in 16 minutes.