Update the path used by the download_fuchsia_sdk.py script to //third_party/fuchsia-sdk #177794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_party/fuchsia-sdk See flutter#177118
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the path for the Fuchsia SDK in the download_fuchsia_sdk.py script to //third_party/fuchsia-sdk. The changes correctly propagate this new path throughout the script, including removing the now-unnecessary host_os parameter from functions and its usage. The code is cleaner and more consistent with other scripts. I have one suggestion for a minor cleanup.
| args = parser.parse_args() | ||
| fail_loudly = 1 if args.fail_loudly else 0 | ||
| verbose = args.verbose | ||
| host_os = args.host_os |
Contributor
There was a problem hiding this comment.
Since host_os is no longer used, the corresponding command-line argument definition on line 135 should also be removed to avoid confusion and improve maintainability.1
Style Guide References
Footnotes
-
The repository style guide mandates following the Google Python Style Guide. Removing unused code, such as the
--host-oscommand-line argument which is no longer used, is a standard practice for code health and maintainability that aligns with the principles of writing clean, readable code. ↩
Member
Author
There was a problem hiding this comment.
Added a comment - this flag is retained to avoid breaking existing scripts that use the flag
Contributor
|
🥂 Thank you Jason. |
jason-simmons
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 31, 2025
…to //third_party/fuchsia-sdk (flutter/flutter#177794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 31, 2025
…to //third_party/fuchsia-sdk (flutter/flutter#177794)
This was referenced Oct 31, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 31, 2025
…to //third_party/fuchsia-sdk (flutter/flutter#177794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 31, 2025
…to //third_party/fuchsia-sdk (flutter/flutter#177794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 31, 2025
…to //third_party/fuchsia-sdk (flutter/flutter#177794)
This was referenced Oct 31, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 1, 2025
…to //third_party/fuchsia-sdk (flutter/flutter#177794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 1, 2025
…to //third_party/fuchsia-sdk (flutter/flutter#177794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 1, 2025
…to //third_party/fuchsia-sdk (flutter/flutter#177794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 2, 2025
…to //third_party/fuchsia-sdk (flutter/flutter#177794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 2, 2025
…to //third_party/fuchsia-sdk (flutter/flutter#177794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 2, 2025
…to //third_party/fuchsia-sdk (flutter/flutter#177794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
…to //third_party/fuchsia-sdk (flutter/flutter#177794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
…to //third_party/fuchsia-sdk (flutter/flutter#177794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
…to //third_party/fuchsia-sdk (flutter/flutter#177794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
…to //third_party/fuchsia-sdk (flutter/flutter#177794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
…to //third_party/fuchsia-sdk (flutter/flutter#177794)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
…to //third_party/fuchsia-sdk (flutter/flutter#177794)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 4, 2025
flutter/flutter@6f8abdd...027f2e4 2025-10-31 [email protected] Roll Dart SDK from bb45c4186fb2 to db168d9e7471 (1 revision) (flutter/flutter#177839) 2025-10-31 [email protected] Hide "waiting for customer" issues from text input triage (flutter/flutter#177524) 2025-10-31 [email protected] Making the multiple_windows example app demonstrate dialogs of dialogs (flutter/flutter#177786) 2025-10-31 [email protected] Fix ElevatedButton.icon breaks focus traversal and VoiceOver when toggling icon (flutter/flutter#177579) 2025-10-31 [email protected] Fix FilledButton.icon and FilledButton.tonalIcon break focus traversal and VoiceOver (flutter/flutter#177593) 2025-10-31 [email protected] Fix cubic subdivision estimation using correct Wang’s formula (flutter/flutter#177758) 2025-10-31 [email protected] Roll Skia from ccbd7697791f to 2cf9a1923078 (1 revision) (flutter/flutter#177832) 2025-10-31 [email protected] Roll Fuchsia Linux SDK from ksXeDDo2yYBXJ4uEu... to O-OoG6j4wHXd1ThNM... (flutter/flutter#177831) 2025-10-31 [email protected] Roll Skia from 1532fabb4b7d to ccbd7697791f (4 revisions) (flutter/flutter#177828) 2025-10-31 [email protected] Roll Dart SDK from cf24b43cb643 to bb45c4186fb2 (2 revisions) (flutter/flutter#177824) 2025-10-31 [email protected] Roll Skia from 825d5c854302 to 1532fabb4b7d (3 revisions) (flutter/flutter#177808) 2025-10-30 [email protected] Roll Dart SDK from da663596bf6d to cf24b43cb643 (2 revisions) (flutter/flutter#177798) 2025-10-30 [email protected] Update the path used by the download_fuchsia_sdk.py script to //third_party/fuchsia-sdk (flutter/flutter#177794) 2025-10-30 [email protected] Roll Skia from 6af53143b120 to 825d5c854302 (2 revisions) (flutter/flutter#177788) 2025-10-30 [email protected] Fixes RuntimeEffect when used with ImageFilter.compose and gaussian blur (flutter/flutter#177687) 2025-10-30 [email protected] Adds cache extent type to two_dimentional_viewport (flutter/flutter#177411) 2025-10-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Update .ci.yaml in flutter/flutter to use 15.5 (#177669)" (flutter/flutter#177793) 2025-10-30 [email protected] Marks Windows windowing_test to be flaky (flutter/flutter#177716) 2025-10-30 [email protected] Fixes `SettingsChannelTest` flake (flutter/flutter#177061) 2025-10-30 [email protected] Implements uniform-by-name for web (flutter/flutter#176980) 2025-10-30 [email protected] Update .ci.yaml in flutter/flutter to use 15.5 (flutter/flutter#177669) 2025-10-30 [email protected] [Impeller] Fall back to OpenGL ES on older Adreno GPUs (flutter/flutter#177747) 2025-10-30 [email protected] [VPAT] Update a11y assessment app and guideline tests (flutter/flutter#177690) 2025-10-30 [email protected] Roll Skia from 18457971c30f to 6af53143b120 (4 revisions) (flutter/flutter#177778) 2025-10-30 [email protected] Roll Packages from 41c6b3d to 1a7075b (2 revisions) (flutter/flutter#177777) 2025-10-30 [email protected] Roll Dart SDK from 4785d5971d64 to da663596bf6d (1 revision) (flutter/flutter#177772) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…_party/fuchsia-sdk (flutter#177794) See flutter#177118
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #177118