-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Respect product flavor abiFilters by adding a disable-abi-filtering Android project flag.
#177753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1adc692 to
a0ad9e6
Compare
disable-abi-filtering Android project flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think to truly mark the linked issue as fixed we would also need to expose this option through the flutter tool, something like the path that android-skip-build-dependency-validation takes in #143341
Technically it can be invoked by the flutter tool though, no? This is the test invocation I used: I thought about adding at Anyway, that's my 2 cents. If it's a blocker to LGTM I'll add it. |
Ah I had forgotten about the Maybe we should add something to our flavors docs which makes brief mention of this requirement when using abiFilters on the product flavors though? Otherwise I think there is essentially no way for a developer to know to do this outside of either us telling them directly on an issue, or them knowing the internals of the FGP (which I think we should never assume they do). |
gmackall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That additional documentation can be figured out independently though, this change lgtm
|
auto label is removed for flutter/flutter/177753, Failed to enqueue flutter/flutter/177753 with HTTP 400: GraphQL mutate failed. |
|
This was stuck in the merge queue and not progressing; removing and re-inserting. |
Did you try turning the computer off and then back on again? /s |
…filtering` Android project flag. (flutter/flutter#177753)
…filtering` Android project flag. (flutter/flutter#177753)
…filtering` Android project flag. (flutter/flutter#177753)
…filtering` Android project flag. (flutter/flutter#177753)
…filtering` Android project flag. (flutter/flutter#177753)
…filtering` Android project flag. (flutter/flutter#177753)
…filtering` Android project flag. (flutter/flutter#177753)
…filtering` Android project flag. (flutter/flutter#177753)
…filtering` Android project flag. (flutter/flutter#177753)
…filtering` Android project flag. (flutter/flutter#177753)
…filtering` Android project flag. (flutter/flutter#177753)
…filtering` Android project flag. (flutter/flutter#177753)
…filtering` Android project flag. (flutter/flutter#177753)
…filtering` Android project flag. (flutter/flutter#177753)
…10408) Manual roll requested by [email protected] flutter/flutter@31a8481...ee23168 2025-11-07 [email protected] Roll Packages from f13bad3 to 3caa48b (5 revisions) (flutter/flutter#178164) 2025-11-07 [email protected] Fix text input actions in DropdownMenu. (flutter/flutter#177313) 2025-11-07 [email protected] Roll Skia from f838c4b31edb to 581d1ecd5029 (1 revision) (flutter/flutter#178157) 2025-11-07 [email protected] Roll Skia from eb3c5b280ae6 to f838c4b31edb (3 revisions) (flutter/flutter#178149) 2025-11-07 [email protected] Roll Skia from 360fe72b5bf4 to eb3c5b280ae6 (1 revision) (flutter/flutter#178147) 2025-11-07 [email protected] Roll Skia from 116f237bb39d to 360fe72b5bf4 (4 revisions) (flutter/flutter#178146) 2025-11-07 [email protected] Roll Fuchsia Linux SDK from cm88aTLui5yorSGYQ... to qDVe2mrpSgQdxra7p... (flutter/flutter#178144) 2025-11-07 [email protected] fix: findChildIndexCallback to take seperators into account for seperated named constructor in ListView and SliverList (flutter/flutter#174491) 2025-11-06 [email protected] [web] Remove unnecessary android_sdk dep (flutter/flutter#178078) 2025-11-06 [email protected] Add haptic notifications support. (flutter/flutter#177721) 2025-11-06 [email protected] Allow label to be used to compute InputDecorator Intrinsic width (flutter/flutter#178101) 2025-11-06 [email protected] Respect product flavor abiFilters by adding a `disable-abi-filtering` Android project flag. (flutter/flutter#177753) 2025-11-06 [email protected] Use aria-hidden attribute for platform view accessibility on web (flutter/flutter#177969) 2025-11-06 [email protected] [tool] Fix IP parsing by using Uri constructor (flutter/flutter#178083) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
A new flag has been added that will allow Android developers to disable FlutterPlugin.kt code that adds abiFilters to buildTypes. This should only be used when the developer knows what they are doing. This is specifically for developers that want to set abiFilters in [Product Flavors](flutter/flutter#175845) Depends on: flutter/flutter#177753 ## Presubmit checklist - [X] If you are unwilling, or unable, to sign the CLA, even for a _tiny_, one-word PR, please file an issue instead of a PR. - [X] If this PR is not meant to land until a future stable release, mark it as draft with an explanation. - [X] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style)—for example, it doesn't use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first-person pronouns). - [X] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer.
… Android project flag. (flutter#177753) This PR introduces a flag (`disable-abi-filtering`) that disables the FlutterPlugin's abiFiltering on buildTypes. This should only be used when the developers know what they are doing. Specifically this allows developers to set their own abiFilters in ProductFlavors or defaultConfig. Because Gradle has complex merging logic, there is a hierarchy of priority when calculating settings (like abiFilters). For example: defaultConfig < productFlavors < buildTypes when combining the three into the final build variant. If abiFilters are set in buildType, it will override abiFilters in productFlavors. When the FlutterPlugin executes, it cannot know about the developers build.gradle settings and therefore we cannot add logic that checks to see if abiFilters are set in productFlavors. Therefore, this flag gives developers an escape hatch so they can implement what they want. Fixes: flutter#175845 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing.
… Android project flag. (flutter#177753) This PR introduces a flag (`disable-abi-filtering`) that disables the FlutterPlugin's abiFiltering on buildTypes. This should only be used when the developers know what they are doing. Specifically this allows developers to set their own abiFilters in ProductFlavors or defaultConfig. Because Gradle has complex merging logic, there is a hierarchy of priority when calculating settings (like abiFilters). For example: defaultConfig < productFlavors < buildTypes when combining the three into the final build variant. If abiFilters are set in buildType, it will override abiFilters in productFlavors. When the FlutterPlugin executes, it cannot know about the developers build.gradle settings and therefore we cannot add logic that checks to see if abiFilters are set in productFlavors. Therefore, this flag gives developers an escape hatch so they can implement what they want. Fixes: flutter#175845 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing.
This PR introduces a flag (
disable-abi-filtering) that disables the FlutterPlugin's abiFiltering on buildTypes. This should only be used when the developers know what they are doing. Specifically this allows developers to set their own abiFilters in ProductFlavors or defaultConfig.Because Gradle has complex merging logic, there is a hierarchy of priority when calculating settings (like abiFilters). For example: defaultConfig < productFlavors < buildTypes when combining the three into the final build variant. If abiFilters are set in buildType, it will override abiFilters in productFlavors.
When the FlutterPlugin executes, it cannot know about the developers build.gradle settings and therefore we cannot add logic that checks to see if abiFilters are set in productFlavors. Therefore, this flag gives developers an escape hatch so they can implement what they want.
Fixes: #175845
Pre-launch Checklist
///).