Skip to content

Only remove what is necessary from abiFilters #177745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mboetger wants to merge 1 commit into from
Closed

Only remove what is necessary from abiFilters #177745

mboetger wants to merge 1 commit into from

Conversation

@mboetger
Copy link
Contributor

@mboetger mboetger commented Oct 29, 2025

Instead of clearing abiFilters, just remove what is necessary (x86 - which is not supported).

Fixes: #175845

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 29, 2025
gmackall
gmackall approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, would be good to have a test to make sure we respect user configuration

@mboetger mboetger mentioned this pull request Oct 29, 2025
Merged
9 tasks
@mboetger mboetger closed this Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmackall gmackall gmackall approved these changes

Assignees

No one assigned

Labels

platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Android] reconfigure abiFilters not effect in productFlavors abiFilters

2 participants

@mboetger @gmackall