-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[web] Move webparagraph tests to their right location #177739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request moves the font_collection_test.dart test file to a new directory, test/webparagraph/, and updates its relative import paths to reflect the new location. This is a structural refactoring for better test organization.
harryterkelsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
Many failures happening in [`Linux linux_web_engine_tests `](https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20linux_web_engine_tests) due to `ui/web_paragraph/font_collection_test.dart` being misplaced. This PR moves the test file to the correct directory so it runs with the correct test suite.
flutter/flutter@df72035...6f8abdd 2025-10-30 [email protected] Roll Skia from 5035cdc7de31 to 18457971c30f (1 revision) (flutter/flutter#177767) 2025-10-30 [email protected] Roll Skia from 018e2cdba2fe to 5035cdc7de31 (3 revisions) (flutter/flutter#177764) 2025-10-30 [email protected] Roll Dart SDK from a0480f399f8f to 4785d5971d64 (21 revisions) (flutter/flutter#177760) 2025-10-30 [email protected] Roll Skia from c803f12d2e26 to 018e2cdba2fe (1 revision) (flutter/flutter#177759) 2025-10-30 [email protected] Roll Skia from 51267d4a2cea to c803f12d2e26 (2 revisions) (flutter/flutter#177756) 2025-10-30 [email protected] Roll Fuchsia Linux SDK from 3EF6k6lqXPWDwrdyj... to ksXeDDo2yYBXJ4uEu... (flutter/flutter#177754) 2025-10-30 [email protected] impeller: allow setting image sampler uniforms by name (flutter/flutter#176749) 2025-10-30 [email protected] Roll Skia from 0a0c9f8c704f to 51267d4a2cea (21 revisions) (flutter/flutter#177752) 2025-10-30 [email protected] Copy symlinks when creating android cipd package, and update to package w/ symlinks (flutter/flutter#177638) 2025-10-30 [email protected] [web] Add GEMINI.md for web engine customizations (flutter/flutter#177413) 2025-10-30 [email protected] Added computeDryBaseline implementation in RenderAligningShiftedBox (flutter/flutter#171250) 2025-10-29 [email protected] Refactor OverlayPortal semantics (flutter/flutter#173005) 2025-10-29 [email protected] [web] Delete unused canvaskit utils (flutter/flutter#177684) 2025-10-29 [email protected] Fixed image links in //README.md (flutter/flutter#177750) 2025-10-29 [email protected] Disable LTO in CI builder configurations for Linux targets (flutter/flutter#177694) 2025-10-29 [email protected] [web] Move webparagraph tests to their right location (flutter/flutter#177739) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Many failures happening in [`Linux linux_web_engine_tests `](https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20linux_web_engine_tests) due to `ui/web_paragraph/font_collection_test.dart` being misplaced. This PR moves the test file to the correct directory so it runs with the correct test suite.
Many failures happening in [`Linux linux_web_engine_tests `](https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20linux_web_engine_tests) due to `ui/web_paragraph/font_collection_test.dart` being misplaced. This PR moves the test file to the correct directory so it runs with the correct test suite.
Many failures happening in
Linux linux_web_engine_testsdue toui/web_paragraph/font_collection_test.dartbeing misplaced.This PR moves the test file to the correct directory so it runs with the correct test suite.