Make sure that a Scaffold doesn't crash in 0x0 environment #177722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a regression test to ensure Scaffold does not crash when rendered in a 0x0 environment. The test is a great addition, but as implemented, it doesn't fully exercise the code path that caused the original crash. I've left a comment with a suggested change to make the test more effective.
Also, as a minor process note, please remember to include the pre-launch checklist in the pull request description as per the repository's contributing guidelines.
Comment on lines
3680
to
3691
| testWidgets('Scaffold does not crash at zero area', (WidgetTester tester) async { | ||
| await tester.pumpWidget( | ||
| const MaterialApp( | ||
| home: Center(child: SizedBox.shrink(child: Scaffold())), | ||
| ), | ||
| ); | ||
| expect(tester.getSize(find.byType(Scaffold)), Size.zero); | ||
| }); |
Contributor
There was a problem hiding this comment.
The current test uses a Scaffold with no body. This means the code path that was causing the crash (_ScaffoldLayout.performLayout's body layout logic) is not executed, as it's guarded by if (hasChild(_ScaffoldSlot.body)). To properly test the fix and prevent regressions, the Scaffold should have at least a body.
Including an appBar would make the test more robust by ensuring layout calculations with non-zero contentTop are also tested under 0x0 size conditions, which was part of the original issue.
Suggested change
| testWidgets('Scaffold does not crash at zero area', (WidgetTester tester) async { | |
| await tester.pumpWidget( | |
| const MaterialApp( | |
| home: Center(child: SizedBox.shrink(child: Scaffold())), | |
| ), | |
| ); | |
| expect(tester.getSize(find.byType(Scaffold)), Size.zero); | |
| }); | |
| testWidgets('Scaffold does not crash at zero area', (WidgetTester tester) async { | |
| await tester.pumpWidget( | |
| const MaterialApp( | |
| home: Center(child: SizedBox.shrink(child: Scaffold(body: SizedBox(), appBar: AppBar()))), | |
| ), | |
| ); | |
| expect(tester.getSize(find.byType(Scaffold)), Size.zero); | |
| }); |
ahmedsameha1
force-pushed
the
handle#6537-Scaffold
branch
from
bcc90f0 to
f1154bc
Compare
victorsanni
approved these changes
Oct 30, 2025
dkwingsmt
approved these changes
Nov 2, 2025
Contributor
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
Checklist:
- The test is in the correct file
- The test name goes “does not crash at zero area”
- The target widget is wrapped by
Center(or is fullscreen) - The target widget does not have an overlay, or the overlay is tested
- The target widget is expected to have a size of exactly
Size.zero
dkwingsmt
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 4, 2025
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…77722) This is my attempt to handle flutter#6537 for the Scaffold widget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the Scaffold widget.