Allow the `RawAutocomplete` to display the options even when one is selected #177705

ValentinVignal · 2025-10-29T08:29:11Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

ValentinVignal · 2025-10-29T08:29:18Z

This kind of goes against #99749 and #100251. I'm opening this PR to start the discussion

cc @StraussPorcupine @LongCatIsLooong @justinmc since it is your issue/PR/review

gemini-code-assist

Code Review

This pull request updates RawAutocomplete to allow the options view to be displayed even when an option is already selected. This fixes an issue where refocusing the field would not show the options. The change is a simple modification to _canShowOptionsView to remove the check for a null selection. The tests have been updated accordingly, including a new test case to cover the fixed scenario. The changes look good and address the issue effectively.

gemini-code-assist · 2025-10-29T08:40:20Z

packages/flutter/test/widgets/autocomplete_test.dart

+
+      lastOnSelected(kOptions[0]);
+      await tester.pump();
+      expect(find.byKey(optionsKey), findsNothing);


This assertion seems inconsistent with the goal of the PR and the changes made to other tests. Most other tests were updated to expect the options view to be visible after selection (findsOne). If the intended behavior is for the options to remain visible, this should probably be expect(find.byKey(optionsKey), findsOne);.

victorsanni

I don't think this is the right fix because it's breaking. Is there a fix that adds this behavior without breaking? Or at least hides it under a flag.

I think the issue is minor enough that its difficult for me to justify even adding a flag for it. Since creating a text selection or editing the field will cause the options view to be displayed anyways.

ValentinVignal · 2025-10-30T15:11:03Z

I understand, the thing is that our users are expecting to see the dropdown when they re-focus the field and it brings friction at the moment.

If we were to merge this PR as it is today. Devs can keep the existing behavior by returning an empty iterable when an option is selected. When that's the case, the menu doesn't show.

This PR gives developers more control and flexibility to customize this behavior. I'm open to any suggestions for a cleaner implementation or a solid migration plan if you have a better approach!

victorsanni

Actually it's hard to see how breaking this is right now because the PR is referencing a non-existent variable. Can you change that so the failing tests become obvious?

packages/flutter/lib/src/widgets/autocomplete.dart

victorsanni · 2025-10-30T18:03:35Z

I fixed the PR locally and tested the issue in #99749 and it resurfaces with this PR:

autocomplete.inactive.mov

If we were to merge this PR as it is today. Devs can keep the existing behavior by returning an empty iterable when an option is selected. When that's the case, the menu doesn't show.

I don't think we want to break users even with this workaround. Communicating the workaround will be difficult, and the breakage is a lot of friction in itself.

Is there a solution that just opens the options view whenever the field is focused? There has to be a solution that fixes this issue and keeps the behavior of #99749 without broadening the API surface. Or do you think this is impossible?

justinmc

+1 to @victorsanni's suggestion to make this opt-in. It seems to me like most users will want the current behavior., or do you not think so @ValentinVignal?

If we were to merge this PR as it is today. Devs can keep the existing behavior by returning an empty iterable when an option is selected. When that's the case, the menu doesn't show.

Do you mean return an empty iterable in optionsBuilder?

ValentinVignal · 2025-10-31T03:00:09Z

Do you mean return an empty iterable in optionsBuilder?

@justinmc yes this is what I was suggesting

ValentinVignal · 2025-11-04T08:21:48Z

It seems to me like most users will want the current behavior., or do you not think so @ValentinVignal?

I'm having a fair amount of friction today with my users that expect the menu to open when they focus the field.
Let me try to investigate more to see if I can make it non breaking and still support #99749

ValentinVignal · 2025-11-04T09:36:56Z

@victorsanni @justinmc, what do you think of the current code? It hides the menu after selection, but allows the user to reopen it when refocusing it

Screen.Recording.2025-11-04.at.5.36.25.PM.mov

victorsanni

I like that this approach is non-breaking.

Can we document this new behavior somewhere? For posterity. Even if only private docs.

Can you also test locally in different scenarios that this doesn't cause any weird bugs? e.g with debouncing.

justinmc · 2025-11-04T23:15:43Z

@ValentinVignal Can you try updating with master to get the Google tests to run? It looks like they're stuck.

ValentinVignal · 2025-11-05T09:20:54Z

@victorsanni

Can we document this new behavior somewhere? For posterity. Even if only private docs.

I added Add comments, tell me what you think about it :)

Can you also test locally in different scenarios that this doesn't cause any weird bugs? e.g with debouncing.

Nice catch! There was indeed an issue with debouncing. When a value was selected, and the field refocused to the display the options, the menu was showing the previously fetched options without refetchings the new ones based on the new text in the text field Fix debouncing should fix it. I'm not sure you'll like the solution though

Screen.Recording.2025-11-05.at.5.16.33.PM.mov

justinmc · 2025-11-05T23:31:57Z

Pushing a merge commit since the tree was just fixed.

justinmc

LGTM but @victorsanni should also give his thoughts. I'm reassured that this is now non-breaking, plus it behaves the same as datalist. Also I'm not too concerned about the _select boolean if that's indeed the behavior we want.

ValentinVignal · 2025-11-06T07:40:12Z

@justinmc @victorsanni it looks like the Google testing failed :( Would you have any details about it?

victorsanni · 2025-11-06T19:26:11Z

it looks like the Google testing failed :( Would you have any details about it?

Failures seem legitimate. I will look into it and provide more details.

Co-authored-by: Victor Sanni <[email protected]>

victorsanni · 2025-11-17T18:40:36Z

Hi @ValentinVignal, thanks for the patience here. I looked at the failing google test and I think it's a problem with the test. I have a fix for it, so we can go ahead with merging this PR.

ValentinVignal · 2025-11-19T02:30:21Z

Thank you for helping out @victorsanni . Are we good to add the autosubmit label then?

…en-a-value-is-selected

…n one is selected (flutter/flutter#177705)

flutter/flutter@de4be4f...9f383e0 2025-11-20 [email protected] Roll Dart SDK from 331595776540 to 5b21f8a7d5d3 (1 revision) (flutter/flutter#178861) 2025-11-20 [email protected] Roll ICU from f27805b7d7d8 to a86a32e67b8d (1 revision) (flutter/flutter#178859) 2025-11-20 [email protected] Roll Dart SDK from d6f9477a2d9f to 331595776540 (1 revision) (flutter/flutter#178851) 2025-11-20 [email protected] Roll Skia from 5bdda9a41db9 to 6284b4f09e14 (3 revisions) (flutter/flutter#178849) 2025-11-20 [email protected] Roll Skia from 24c28206d912 to 5bdda9a41db9 (2 revisions) (flutter/flutter#178845) 2025-11-20 [email protected] Roll Dart SDK from 7506c64a5117 to d6f9477a2d9f (1 revision) (flutter/flutter#178844) 2025-11-20 [email protected] Roll Skia from fd41f3650729 to 24c28206d912 (2 revisions) (flutter/flutter#178841) 2025-11-20 [email protected] Use WidgetsBinding.instance.platformDispatcher in windowing instead of PlatformDispatcher.instance (flutter/flutter#178799) 2025-11-20 [email protected] [Impeller] Adds support for r32float textures (flutter/flutter#178418) 2025-11-20 [email protected] Roll Skia from a283da7a6b6c to fd41f3650729 (2 revisions) (flutter/flutter#178838) 2025-11-20 [email protected] [Impeller] Deny-list Adreno 640 and 650 for Vulkan eligibility. (flutter/flutter#178833) 2025-11-19 [email protected] Roll Skia from b5dc8c3494ac to a283da7a6b6c (8 revisions) (flutter/flutter#178832) 2025-11-19 [email protected] Roll Dart SDK from f7e9bd245fd9 to 7506c64a5117 (3 revisions) (flutter/flutter#178828) 2025-11-19 [email protected] Allow the `RawAutocomplete` to display the options even when one is selected (flutter/flutter#177705) 2025-11-19 [email protected] [web] Skip flaky service worker test (flutter/flutter#178820) 2025-11-19 [email protected] Only call glCheckFrameBufferStatus in the render pass in debug builds (flutter/flutter#178707) 2025-11-19 [email protected] Manual pub roll (flutter/flutter#178687) 2025-11-19 [email protected] Document that `error` parameter must be initialized (flutter/flutter#177730) 2025-11-19 [email protected] Update `_CircularProgressIndicatorState` to use `transform` directly (flutter/flutter#178569) 2025-11-19 [email protected] Fix layout for macOS frameworks for code assets (flutter/flutter#178625) 2025-11-19 [email protected] Roll Packages from 34746bb to 8f72e4b (7 revisions) (flutter/flutter#178800) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 29, 2025

ValentinVignal requested review from LongCatIsLooong and justinmc October 29, 2025 08:29

gemini-code-assist bot reviewed Oct 29, 2025

View reviewed changes

dkwingsmt requested review from QuncCccccc and victorsanni October 29, 2025 18:04

victorsanni reviewed Oct 29, 2025

View reviewed changes

victorsanni reviewed Oct 30, 2025

View reviewed changes

packages/flutter/lib/src/widgets/autocomplete.dart Outdated Show resolved Hide resolved

justinmc reviewed Oct 30, 2025

View reviewed changes

ValentinVignal force-pushed the flutter/autocomplete/show-dropdown-even-when-a-value-is-selected branch from 9b83fa7 to 9d0d638 Compare November 4, 2025 09:34

victorsanni requested review from justinmc and victorsanni November 4, 2025 16:51

victorsanni reviewed Nov 4, 2025

View reviewed changes

ValentinVignal force-pushed the flutter/autocomplete/show-dropdown-even-when-a-value-is-selected branch from 9d0d638 to 4ab2ca8 Compare November 5, 2025 09:17

ValentinVignal requested a review from victorsanni November 5, 2025 09:20

justinmc approved these changes Nov 5, 2025

View reviewed changes

ValentinVignal force-pushed the flutter/autocomplete/show-dropdown-even-when-a-value-is-selected branch from 14bb6c6 to 04ca907 Compare November 6, 2025 05:44

victorsanni added this to Google Testing Queue Nov 6, 2025

victorsanni self-assigned this Nov 6, 2025

ValentinVignal and others added 9 commits November 7, 2025 10:48

Display the menu even when there is a selection

c44834f

Update the tests

8a84152

Force to hide the menu when selecting an option

1f1b181

use correct controller

543d7fa

Co-authored-by: Victor Sanni <[email protected]>

Hide the menu after selection

2dcc26a

Update the tests

7846971

Add comments

9227f83

Fix deboucing

ad76e94

Do not use intent

61604f1

ValentinVignal force-pushed the flutter/autocomplete/show-dropdown-even-when-a-value-is-selected branch from 04ca907 to 61604f1 Compare November 7, 2025 02:48

Merge branch 'master' into flutter/autocomplete/show-dropdown-even-wh…

c100316

…en-a-value-is-selected

victorsanni approved these changes Nov 19, 2025

View reviewed changes

victorsanni moved this from In Progress to Done in Google Testing Queue Nov 19, 2025

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 19, 2025

auto-submit bot added this pull request to the merge queue Nov 19, 2025

Merged via the queue into flutter:master with commit caa84ba Nov 19, 2025
71 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 19, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 20, 2025

caa84ba09 Allow the RawAutocomplete to display the options even whe…

c66b330

…n one is selected (flutter/flutter#177705)

engine-flutter-autoroll mentioned this pull request Nov 20, 2025

Roll Flutter from de4be4f3892d to 483505b8257e (20 revisions) flutter/packages#10479

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 20, 2025

caa84ba09 Allow the RawAutocomplete to display the options even whe…

b747f70

…n one is selected (flutter/flutter#177705)

engine-flutter-autoroll mentioned this pull request Nov 20, 2025

Roll Flutter from de4be4f3892d to 9f383e099033 (21 revisions) flutter/packages#10481

Merged

Piinks mentioned this pull request Nov 21, 2025

Flutter Notable Commits - 2025 #161460

Open

Allow the RawAutocomplete to display the options even when one is selected #177705

Allow the RawAutocomplete to display the options even when one is selected #177705

Uh oh!

Conversation

ValentinVignal commented Oct 29, 2025

Pre-launch Checklist

Uh oh!

ValentinVignal commented Oct 29, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

ValentinVignal commented Oct 30, 2025

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

victorsanni commented Oct 30, 2025

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

ValentinVignal commented Oct 31, 2025

Uh oh!

ValentinVignal commented Nov 4, 2025

Uh oh!

ValentinVignal commented Nov 4, 2025

Uh oh!

victorsanni left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc commented Nov 4, 2025

Uh oh!

ValentinVignal commented Nov 5, 2025

Uh oh!

justinmc commented Nov 5, 2025

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

ValentinVignal commented Nov 6, 2025

Uh oh!

victorsanni commented Nov 6, 2025

Uh oh!

victorsanni commented Nov 17, 2025

Uh oh!

ValentinVignal commented Nov 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Allow the `RawAutocomplete` to display the options even when one is selected #177705

Allow the `RawAutocomplete` to display the options even when one is selected #177705