[web] Delete unused canvaskit utils #177684
Merged
+0
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
engine
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a welcome cleanup that removes several unused utility functions and constants from the CanvasKit and engine utility files. The primary change is the removal of computeSkShadowBounds and its dependencies, which were implemented as a workaround and are no longer necessary. The PR also removes the unused clampInt function. These deletions are correct and improve the maintainability of the codebase by removing dead code. The changes are approved.
mdebbar
added
the
autosubmit
Contributor
|
Good catch! |
flutter-dashboard
bot
removed
the
autosubmit
walley892
pushed a commit
to walley892/flutter
that referenced
this pull request
Oct 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 30, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 30, 2025
flutter/flutter@df72035...6f8abdd 2025-10-30 [email protected] Roll Skia from 5035cdc7de31 to 18457971c30f (1 revision) (flutter/flutter#177767) 2025-10-30 [email protected] Roll Skia from 018e2cdba2fe to 5035cdc7de31 (3 revisions) (flutter/flutter#177764) 2025-10-30 [email protected] Roll Dart SDK from a0480f399f8f to 4785d5971d64 (21 revisions) (flutter/flutter#177760) 2025-10-30 [email protected] Roll Skia from c803f12d2e26 to 018e2cdba2fe (1 revision) (flutter/flutter#177759) 2025-10-30 [email protected] Roll Skia from 51267d4a2cea to c803f12d2e26 (2 revisions) (flutter/flutter#177756) 2025-10-30 [email protected] Roll Fuchsia Linux SDK from 3EF6k6lqXPWDwrdyj... to ksXeDDo2yYBXJ4uEu... (flutter/flutter#177754) 2025-10-30 [email protected] impeller: allow setting image sampler uniforms by name (flutter/flutter#176749) 2025-10-30 [email protected] Roll Skia from 0a0c9f8c704f to 51267d4a2cea (21 revisions) (flutter/flutter#177752) 2025-10-30 [email protected] Copy symlinks when creating android cipd package, and update to package w/ symlinks (flutter/flutter#177638) 2025-10-30 [email protected] [web] Add GEMINI.md for web engine customizations (flutter/flutter#177413) 2025-10-30 [email protected] Added computeDryBaseline implementation in RenderAligningShiftedBox (flutter/flutter#171250) 2025-10-29 [email protected] Refactor OverlayPortal semantics (flutter/flutter#173005) 2025-10-29 [email protected] [web] Delete unused canvaskit utils (flutter/flutter#177684) 2025-10-29 [email protected] Fixed image links in //README.md (flutter/flutter#177750) 2025-10-29 [email protected] Disable LTO in CI builder configurations for Linux targets (flutter/flutter#177694) 2025-10-29 [email protected] [web] Move webparagraph tests to their right location (flutter/flutter#177739) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73492