Skip to content

Revert "Resolve resolve native Flutter dependencies in Android Studio… #177605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Oct 28, 2025
Merged

Revert "Resolve resolve native Flutter dependencies in Android Studio… #177605

auto-submit merged 2 commits into from
Oct 28, 2025

Conversation

@reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Oct 27, 2025

Fixes #177037 on 3.38 branch.

This reverts commit 0c0406a.
Leaves isInvokedFromAndroidStudio

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@reidbaker reidbaker requested a review from a team as a code owner October 27, 2025 18:21
@flutter-dashboard
Copy link

flutter-dashboard bot commented Oct 27, 2025

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@github-actions github-actions bot added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Oct 27, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 27, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a revert of commit 0c0406a6158eb07d28a70350a22801ee8f6870c9 to fix issue #177037. The changes correctly remove the logic that added native Flutter dependencies when building from Android Studio. The revert is clean and also removes a try-catch block that was likely unnecessary. The changes look correct and align with the goal of fixing the regression.

@reidbaker reidbaker requested a review from camsim99 October 27, 2025 18:42
@camsim99 camsim99 added the cp: review Cherry-picks in the review queue label Oct 27, 2025
@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 28, 2025
@auto-submit auto-submit bot merged commit 46b0f4e into flutter:flutter-3.38-candidate.0 Oct 28, 2025
147 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
@engine-flutter-autoroll
46b0f4eae Revert "Resolve resolve native Flutter dependencies in Andr…
8f04b3e 
…oid Studio… (flutter/flutter#177605)
@reidbaker reidbaker mentioned this pull request Dec 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mboetger mboetger mboetger approved these changes

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

@camsim99 camsim99 Awaiting requested review from camsim99

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App cp: review Cherry-picks in the review queue platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@reidbaker @mboetger @fluttergithubbot @camsim99