Add support for Visual Studio 2026 #177458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for Visual Studio 2026 by mapping its version number to the appropriate CMake generator string. Additionally, it includes a test case to verify the correct CMake generator is selected when Visual Studio 2026 is detected. The code changes look correct, and the addition of the test case is good. However, the version number 2026 is hardcoded, and there is no way to configure it. I have added a review comment to address this.
Contributor
Author
|
Regarding the precise values used in the |
logiclrd
changed the title
bkonyi
approved these changes
Oct 31, 2025
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/177458, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
…r property in visual_studio.dart. Added a test for the Visual Studio 2026 mapping to visual_studio_test.dart.
Contributor
Author
|
Huh. Weird. Git says that upstream |
logiclrd
force-pushed
the
vs-2026-support
branch
from
3e149b0 to
629878a
Compare
Member
|
I checked the Google testing failures, they looked like flakes unrelated to your change. Rerunning... |
loic-sharma
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
Contributor
Author
|
🎉 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 4, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
bkonyi
added
cp: beta
flutteractionsbot
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Nov 13, 2025
Adds a mapping for Visual Studio 2026 to the `cmakeGenerator` property used to drive Windows builds, enabling Flutter to be used for development on a system with Visual Studio 2026 installed and not Visual Studio 2022 or Visual Studio 2019. Closes: flutter#176399 Related-To: flutter#93426 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
|
Failed to create CP due to merge conflicts. |
bkonyi
removed
the
cp: beta
Contributor
|
This change was submitted after the 3.38 stable release was branched. I've created a cherrypick request to have this included in the 3.38.2 release (assuming 3.38.1 is released to resolve #178400). |
bufffun
pushed a commit
to bufffun/flutter
that referenced
this pull request
Nov 26, 2025
Adds a mapping for Visual Studio 2026 to the `cmakeGenerator` property used to drive Windows builds, enabling Flutter to be used for development on a system with Visual Studio 2026 installed and not Visual Studio 2022 or Visual Studio 2019. Closes: flutter#176399 Related-To: flutter#93426 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
Adds a mapping for Visual Studio 2026 to the `cmakeGenerator` property used to drive Windows builds, enabling Flutter to be used for development on a system with Visual Studio 2026 installed and not Visual Studio 2022 or Visual Studio 2019. Closes: flutter#176399 Related-To: flutter#93426 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a mapping for Visual Studio 2026 to the
cmakeGeneratorproperty used to drive Windows builds, enabling Flutter to be used for development on a system with Visual Studio 2026 installed and not Visual Studio 2022 or Visual Studio 2019.Closes: #176399
Related-To: #93426
Pre-launch Checklist
///).