[web] Use SkPathBuilder because SkPath is becoming immutable #177343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
engine
mdebbar
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 25, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 25, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 26, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 26, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 27, 2025
flutter/flutter@cb18290...4c91098 2025-10-26 [email protected] Roll ICU from ff35c4f9df23 to f27805b7d7d8 (1 revision) (flutter/flutter#177558) 2025-10-26 [email protected] Roll Skia from b85c7ae19092 to de52b3a7585a (1 revision) (flutter/flutter#177550) 2025-10-25 [email protected] Make sure that a DropdownMenu doesn't crash in 0x0 environment (flutter/flutter#174809) 2025-10-25 [email protected] Fix DropdownMenu filtering is broken (flutter/flutter#177450) 2025-10-25 [email protected] Roll Skia from f352da2d607f to b85c7ae19092 (1 revision) (flutter/flutter#177539) 2025-10-25 [email protected] Roll Skia from e91d238ce638 to f352da2d607f (4 revisions) (flutter/flutter#177525) 2025-10-24 [email protected] Add more docs to TextBaseline (flutter/flutter#177507) 2025-10-24 [email protected] Bump Templates To Correct Versions (flutter/flutter#177416) 2025-10-24 [email protected] [web] Use SkPathBuilder because SkPath is becoming immutable (flutter/flutter#177343) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…#177343) Skia is working on making `SkPath` immutable: https://skia-review.googlesource.com/c/skia/+/1075478 In Flutter Web's CanvasKit renderer, we use `SkPath` as a mutable object, which made the [Skia roll](flutter#177184) fail. To fix this, we should start using `SkPathBuilder` instead. Remaining work: - [x] Figure out the deletion/disposal of `SkPath`s generated from `.snapshot()` calls. - [ ] `LazyPath` should be restructured to better accommodate a world of immutable paths and path builders (coming in a future PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skia is working on making
SkPathimmutable: https://skia-review.googlesource.com/c/skia/+/1075478In Flutter Web's CanvasKit renderer, we use
SkPathas a mutable object, which made the Skia roll fail. To fix this, we should start usingSkPathBuilderinstead.Remaining work:
SkPaths generated from.snapshot()calls.LazyPathshould be restructured to better accommodate a world of immutable paths and path builders (coming in a future PR).