[CP-beta][ Tool ] Output DTD URI for Flutter web applications #177321
Conversation
|
@bkonyi please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
github-actions
bot
added
the
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the dtdUri parameter to the DebugConnectionInfo class and updates the resident web runner and associated tests to surface the DTD URI for Flutter web applications. The code changes are straightforward and seem correct.
Only includes changes relevant to flutter#176310
…16fb94a15988e5b5d5a3dd60
camsim99
added
the
autosubmit
auto-submit
bot
merged commit 46485b1
into
flutter:flutter-3.38-candidate.0
3 participants
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#176310
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
app.dtdevent is not emitted for Flutter web applications run with--machine.Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
Makes it impossible for tooling to connect to the DTD instance associated with a Flutter web application. This impacts the Flutter MCP extension.
Workaround:
Is there a workaround for this issue?
No workaround available.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
Run a web application using
flutter run -d chrome --machineand verify there's anapp.dtdevent once the application has started.