Roll Skia from 2d9df7c70b6f to def78efc6f5c (36 revisions) #177184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://skia.googlesource.com/skia.git/+log/2d9df7c70b6f..def78efc6f5c 2025-10-17 [email protected] Fix DMSrcSink choice of PNG encoder 2025-10-17 [email protected] SG slides to fScene->revalidate when needed 2025-10-17 [email protected] Make SkPath immutable on GN build 2025-10-17 [email protected] [graphite] Conditionalize call to prepareForReturnToCache 2025-10-17 [email protected] Roll vulkan-deps from d7da3806ac80 to 5f4499eff7b1 (4 revisions) 2025-10-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2025-10-17 [email protected] Roll ANGLE from 3add1bfa10cd to 012c4998642a (21 revisions) 2025-10-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2025-10-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2025-10-17 [email protected] Roll Skia Infra from 97b75fbdfdf0 to 9602f241b417 (7 revisions) 2025-10-16 [email protected] Use pathdata to transform in drawPath 2025-10-16 [email protected] Update CanvasKit to have immutable Path objects 2025-10-16 [email protected] Speculative fix for flaky dawn builds 2025-10-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2025-10-16 [email protected] Use SkCanvas::baseRecorder for SkImage::isValid 2025-10-16 [email protected] [rust png] Add `SkDynamicMemoryWStream::detachAsVector` method. 2025-10-16 [email protected] Refactor makeTransform() so it can be a factory as well 2025-10-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2025-10-16 [email protected] Roll vulkan-deps from a3749d19263e to d7da3806ac80 (3 revisions) 2025-10-16 [email protected] In TextLine::getGlyphPositionAtCoordinate, return the last position in the text if iterateThroughVisualRuns reaches the ellipsis run 2025-10-16 [email protected] Tidy up SkResolveConvexity 2025-10-16 [email protected] [rust png] Support for using `SkPngRustEncoder` from `SkXPSDevice.cpp`. 2025-10-16 [email protected] Further restrict the jobs that run the PersistentPipelineStorageTest 2025-10-16 [email protected] Have GN shell out to CMake to build Dawn 2025-10-16 [email protected] Treat kGraphiteVulkan_BackendType as Vulkan 2025-10-16 [email protected] Disable failing OpenGLES SkSL test on Pixel10 2025-10-16 [email protected] [graphite] Add MappedAllocationInfo using declaration 2025-10-16 [email protected] Change PathRaw to store convexity enum, not just bool 2025-10-16 [email protected] Add explicit keyword to many public single argument constructors 2025-10-16 [email protected] Miscellaneous code cleanup 2025-10-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2025-10-16 [email protected] Roll ANGLE from 2027314b341f to 3add1bfa10cd (16 revisions) 2025-10-16 [email protected] Roll Dawn from 32017614bc6b to 6c7ec7c76611 (23 revisions) 2025-10-16 [email protected] Roll Skia Infra from fb1930c766c4 to 97b75fbdfdf0 (6 revisions) 2025-10-16 [email protected] Roll SwiftShader from e608e2130d25 to 3d536c0fc62b (1 revision) 2025-10-16 [email protected] Roll vulkan-deps from c4b9a2688979 to a3749d19263e (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added
the
autosubmit
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
fluttergithubbot
approved these changes
Oct 17, 2025
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/177184, because - The status or check suite Linux linux_web_engine_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Contributor
Author
|
Commit queue failed; closing this roll. |
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 24, 2025
Skia is working on making `SkPath` immutable: https://skia-review.googlesource.com/c/skia/+/1075478 In Flutter Web's CanvasKit renderer, we use `SkPath` as a mutable object, which made the [Skia roll](#177184) fail. To fix this, we should start using `SkPathBuilder` instead. Remaining work: - [x] Figure out the deletion/disposal of `SkPath`s generated from `.snapshot()` calls. - [ ] `LazyPath` should be restructured to better accommodate a world of immutable paths and path builders (coming in a future PR).
engine-flutter-autoroll
deleted the
skia-flutter-autoroll-75e3bb49-a521-476b-b80b-0d6fe09c6663-1760731909
branch
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…#177343) Skia is working on making `SkPath` immutable: https://skia-review.googlesource.com/c/skia/+/1075478 In Flutter Web's CanvasKit renderer, we use `SkPath` as a mutable object, which made the [Skia roll](flutter#177184) fail. To fix this, we should start using `SkPathBuilder` instead. Remaining work: - [x] Figure out the deletion/disposal of `SkPath`s generated from `.snapshot()` calls. - [ ] `LazyPath` should be restructured to better accommodate a world of immutable paths and path builders (coming in a future PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roll Skia from 2d9df7c70b6f to def78efc6f5c (36 revisions)
https://skia.googlesource.com/skia.git/+log/2d9df7c70b6f..def78efc6f5c
2025-10-17 [email protected] Fix DMSrcSink choice of PNG encoder
2025-10-17 [email protected] SG slides to fScene->revalidate when needed
2025-10-17 [email protected] Make SkPath immutable on GN build
2025-10-17 [email protected] [graphite] Conditionalize call to prepareForReturnToCache
2025-10-17 [email protected] Roll vulkan-deps from d7da3806ac80 to 5f4499eff7b1 (4 revisions)
2025-10-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2025-10-17 [email protected] Roll ANGLE from 3add1bfa10cd to 012c4998642a (21 revisions)
2025-10-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2025-10-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2025-10-17 [email protected] Roll Skia Infra from 97b75fbdfdf0 to 9602f241b417 (7 revisions)
2025-10-16 [email protected] Use pathdata to transform in drawPath
2025-10-16 [email protected] Update CanvasKit to have immutable Path objects
2025-10-16 [email protected] Speculative fix for flaky dawn builds
2025-10-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2025-10-16 [email protected] Use SkCanvas::baseRecorder for SkImage::isValid
2025-10-16 [email protected] [rust png] Add
SkDynamicMemoryWStream::detachAsVectormethod.2025-10-16 [email protected] Refactor makeTransform() so it can be a factory as well
2025-10-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2025-10-16 [email protected] Roll vulkan-deps from a3749d19263e to d7da3806ac80 (3 revisions)
2025-10-16 [email protected] In TextLine::getGlyphPositionAtCoordinate, return the last position in the text if iterateThroughVisualRuns reaches the ellipsis run
2025-10-16 [email protected] Tidy up SkResolveConvexity
2025-10-16 [email protected] [rust png] Support for using
SkPngRustEncoderfromSkXPSDevice.cpp.2025-10-16 [email protected] Further restrict the jobs that run the PersistentPipelineStorageTest
2025-10-16 [email protected] Have GN shell out to CMake to build Dawn
2025-10-16 [email protected] Treat kGraphiteVulkan_BackendType as Vulkan
2025-10-16 [email protected] Disable failing OpenGLES SkSL test on Pixel10
2025-10-16 [email protected] [graphite] Add MappedAllocationInfo using declaration
2025-10-16 [email protected] Change PathRaw to store convexity enum, not just bool
2025-10-16 [email protected] Add explicit keyword to many public single argument constructors
2025-10-16 [email protected] Miscellaneous code cleanup
2025-10-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2025-10-16 [email protected] Roll ANGLE from 2027314b341f to 3add1bfa10cd (16 revisions)
2025-10-16 [email protected] Roll Dawn from 32017614bc6b to 6c7ec7c76611 (23 revisions)
2025-10-16 [email protected] Roll Skia Infra from fb1930c766c4 to 97b75fbdfdf0 (6 revisions)
2025-10-16 [email protected] Roll SwiftShader from e608e2130d25 to 3d536c0fc62b (1 revision)
2025-10-16 [email protected] Roll vulkan-deps from c4b9a2688979 to a3749d19263e (3 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
...