3.38.0 beta engine version #177178
3.38.0 beta engine version #177178
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the content-aware hashing scripts to correctly detect the LUCI CI environment by checking for the LUCI_CONTEXT environment variable instead of LUCI_CI. The corresponding tests are updated to reflect this change. Additionally, a temporary file, engine/TRIGGER.md, is added to trigger a new engine release build by changing the engine's content-aware hash.
My PR updating engine.version (#177178) for the 3.38.0 beta release isn't passing the analyzer because the engine artifacts don't exist. This PR will trigger another engine build, and then I'll use its merge SHA in engine.version. And it conveniently deletes the file used for this same purpose in #176842.
github-actions
bot
removed
the
engine
|
Alright I have merged another PR that deletes the engine file (#177181) and updated the SHA to that merge commit. The analyzer test just failed because the engine artifacts haven't finished building yet. After they finish I will rerun and, if we're right, it should pass. |
justinmc
added
the
autosubmit
auto-submit
bot
merged commit 7e592fe
into
flutter:flutter-3.38-candidate.0
2 participants
The version I set in #176799 was incorrect so the release build failed. This updates it to the correct engine version.