Move the Fuchsia SDK to //third_party/fuchsia-sdk #177118
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
engine
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors build scripts to use the new path for the Fuchsia SDK, //third_party/fuchsia-sdk/sdk. The changes are applied consistently across multiple GN and Python files, and simplify some scripts by removing platform-specific path logic. I have identified a couple of areas where path duplication could be reduced to improve maintainability and prevent potential bugs.
engine/src/build/fuchsia/sdk.gni
Outdated
| } | ||
|
|
||
| _fuchsia_sdk_path = "//fuchsia/sdk/$host_os" | ||
| _fuchsia_sdk_path = "//third_party/fuchsia-sdk/sdk" |
There was a problem hiding this comment.
This hardcoded path duplicates the value of fuchsia_sdk_path defined on line 20. If fuchsia_sdk_path is overridden as a build argument, this variable will not be updated, which could lead to inconsistent paths and build failures. To ensure consistency and adhere to the "Avoid duplicating state" principle, you should assign this from fuchsia_sdk_path.1
| _fuchsia_sdk_path = "//third_party/fuchsia-sdk/sdk" | |
| _fuchsia_sdk_path = fuchsia_sdk_path |
Style Guide References
Footnotes
-
Avoid duplicating state: Keep only one source of truth. ↩
There was a problem hiding this comment.
I think this suggestion is very accurate.
| } | ||
|
|
||
| vulkan_dist = "//fuchsia/sdk/$host_os/arch/$target_cpu/dist" | ||
| vulkan_dist = "//third_party/fuchsia-sdk/sdk/arch/$target_cpu/dist" |
There was a problem hiding this comment.
The base path //third_party/fuchsia-sdk/sdk is repeated on line 100 for vulkan_data_dir. To improve maintainability and adhere to the "Avoid duplicating state" principle, consider defining a local variable for this path and reusing it in both places.1
Style Guide References
Footnotes
-
Avoid duplicating state: Keep only one source of truth. ↩
|
Originally the path was enforced by the Flutter coding style / directory structure, but I have no concern to any location. If Flutter owners do not like the new folder, we can also change abseil-cpp.git to respect gn args in https://crsrc.org/c/build/config/fuchsia/gn_configs.gni, e.g. fuchsia_sdk. |
engine/src/build/fuchsia/sdk.gni
Outdated
| } | ||
|
|
||
| _fuchsia_sdk_path = "//fuchsia/sdk/$host_os" | ||
| _fuchsia_sdk_path = "//third_party/fuchsia-sdk/sdk" |
There was a problem hiding this comment.
I think this suggestion is very accurate.
| } | ||
|
|
||
| vulkan_dist = "//fuchsia/sdk/$host_os/arch/$target_cpu/dist" | ||
| vulkan_dist = "//third_party/fuchsia-sdk/sdk/arch/$target_cpu/dist" |
The //third_party/fuchsia-sdk path is expected by the build scripts for other packages in the Chromium tree such as Abseil.
jason-simmons
force-pushed
the
fuchsia_sdk_third_party
branch
from
5c375d1 to
d5196ae
Compare
jason-simmons
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
Previously the license script looked for licenses within the engine/src/flutter tree. This PR updates the script to support the move of Abseil and the Fuchsia SDK from engine/src/flutter to engine/src/third_party. See flutter#177059 and flutter#177118
Roll Flutter from 2d3416713fe8 to 75004a639ae4 (39 revisions) flutter/flutter@2d34167...75004a6 2025-10-22 [email protected] [Impeller] Add the paint color to the key of the text shadow cache (flutter/flutter#177140) 2025-10-22 [email protected] Roll Skia from 96e75ca8e24b to 928b5cf727c1 (2 revisions) (flutter/flutter#177387) 2025-10-22 [email protected] Roll reclient to version 185 (flutter/flutter#177293) 2025-10-22 [email protected] Roll Skia from b157f6b95f95 to 96e75ca8e24b (4 revisions) (flutter/flutter#177366) 2025-10-22 [email protected] Fix InputDatePickerFormField does not inherit local InputDecorationTheme (flutter/flutter#177090) 2025-10-22 [email protected] Roll Skia from 2c6162c977db to b157f6b95f95 (2 revisions) (flutter/flutter#177362) 2025-10-22 [email protected] Roll Skia from cadf8e7e6fca to 2c6162c977db (4 revisions) (flutter/flutter#177359) 2025-10-22 [email protected] Cleanup after -news_toolkit, +google_fonts, and some leftover `team-go_router` (flutter/flutter#176841) 2025-10-21 [email protected] don't break sheet's snap from physics (flutter/flutter#171157) 2025-10-21 [email protected] Roll Dart SDK from 913c2ae1b367 to c23010c4f9e6 (8 revisions) (flutter/flutter#177348) 2025-10-21 [email protected] Fix typo in comment about screen availibility (flutter/flutter#177168) 2025-10-21 [email protected] Fix(AnimatedScrollView): exclude outgoing items in removeAllItems (flutter/flutter#176452) 2025-10-21 [email protected] Enable deprecated_member_use_from_same_package for all packages containing tests of Dart fixes defined within the package (flutter/flutter#177341) 2025-10-21 [email protected] Roll Skia from 19bff385f7e8 to cadf8e7e6fca (3 revisions) (flutter/flutter#177331) 2025-10-21 [email protected] Revert "[Android 16] Update `android_engine_vulkan_tests` to Test Against SDK 36 Emulator" (flutter/flutter#177292) 2025-10-21 [email protected] Fix SliverMainAxisGroup.cacheOrigin (flutter/flutter#175760) 2025-10-21 [email protected] Roll Skia from 75c756e029c9 to 19bff385f7e8 (3 revisions) (flutter/flutter#177316) 2025-10-21 [email protected] Fix typo in overlay.dart documentation comment (flutter/flutter#176612) 2025-10-21 [email protected] [ Tool ] Output DTD URI for Flutter web applications (flutter/flutter#177310) 2025-10-21 [email protected] Roll Skia from 982988b472a4 to 75c756e029c9 (1 revision) (flutter/flutter#177305) 2025-10-21 [email protected] Roll Skia from 42ff13a91c80 to 982988b472a4 (8 revisions) (flutter/flutter#177300) 2025-10-21 [email protected] Fix DateRangePickerDialog does not inherit local InputDecorationTheme (flutter/flutter#177086) 2025-10-21 [email protected] Remove references to dart:_js_annotations (flutter/flutter#176698) 2025-10-20 [email protected] Make `FlutterSceneLifeCycleProvider.sceneLifeCycleDelegate` readonly (flutter/flutter#177240) 2025-10-20 [email protected] Make sure that a CupertinoDesktopTextSelectionToolbar doesn't crash i… (flutter/flutter#173964) 2025-10-20 [email protected] Make sure that a BottomSheet doesn't crash in 0x0 environment (flutter/flutter#172229) 2025-10-20 [email protected] Move the Fuchsia SDK to //third_party/fuchsia-sdk (flutter/flutter#177118) 2025-10-20 [email protected] Roll Skia from 641994569415 to 42ff13a91c80 (8 revisions) (flutter/flutter#177283) 2025-10-20 [email protected] Make sure that a NavigationDrawer doesn't crash in 0x0 environment (flutter/flutter#176951) 2025-10-20 [email protected] Fix ink features painting in TabBar. (flutter/flutter#177155) 2025-10-20 [email protected] Make sure that SimpleDialog and SimpleDialogOption do not crash in 0x0 environment (flutter/flutter#174229) 2025-10-20 [email protected] Fix ink features painting in YearPicker. (flutter/flutter#177014) 2025-10-20 [email protected] Update `image.error_builder.0.dart` to replace the emoji with some text (flutter/flutter#176886) 2025-10-20 [email protected] Roll Skia from ed4294faecde to 641994569415 (4 revisions) (flutter/flutter#177264) 2025-10-20 [email protected] Remove redundant name field form `TargetPlatform` and `XCDeviceEventInterface` enums (flutter/flutter#176890) 2025-10-20 [email protected] Added support to pass in texture type while creating textures. (flutter/flutter#175376) 2025-10-20 [email protected] Roll Packages from 3747006 to d113bbc (6 revisions) (flutter/flutter#177270) 2025-10-20 [email protected] Roll Dart SDK from 2cd2106f2cef to 913c2ae1b367 (2 revisions) (flutter/flutter#177258) 2025-10-20 [email protected] Added link to ClipRect from ImageFilter in the docstring (flutter/flutter#177196) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. ...
Previously the license script looked for licenses within the engine/src/flutter tree. This PR updates the script to support the move of Abseil and the Fuchsia SDK from engine/src/flutter to engine/src/third_party. See flutter#177059 and flutter#177118
|
@jason-simmons https://github.com/flutter/flutter/blob/master/engine/src/flutter/tools/download_fuchsia_sdk.py hasn't been changed and broke the LSC workflow. |
…_party/fuchsia-sdk See flutter#177118
The //third_party/fuchsia-sdk path is expected by the build scripts for other packages in the Chromium tree such as Abseil.
Previously the license script looked for licenses within the engine/src/flutter tree. This PR updates the script to support the move of Abseil and the Fuchsia SDK from engine/src/flutter to engine/src/third_party. See flutter#177059 and flutter#177118
…_party/fuchsia-sdk (flutter#177794) See flutter#177118
3 participants
The //third_party/fuchsia-sdk path is expected by the build scripts for other packages in the Chromium tree such as Abseil.