Search all the build configurations for sky_snapshot #177
+25
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we assumed the first build configuration would have one. Now we keep looking until we find one. Also, re-ordered the configurations so that you'll get the Android one if you have both, which is probably what you would expect. Fixes flutter#100
Contributor
|
LGTM |
abarth
added a commit
that referenced
this pull request
Nov 9, 2015
Search all the build configurations for sky_snapshot
Closed
Closed
This was referenced Jul 19, 2018
Closed
This was referenced Dec 16, 2019
This was referenced Dec 17, 2019
This was referenced Jan 4, 2020
This was referenced Jan 11, 2020
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we assumed the first build configuration would have one. Now we
keep looking until we find one. Also, re-ordered the configurations so that
you'll get the Android one if you have both, which is probably what you would
expect.
Fixes #100