[Android 16] Update android_engine_vulkan_tests to Test Against SDK 36 Emulator
#176985
Conversation
reidbaker
left a comment
reidbaker
left a comment
There was a problem hiding this comment.
I dont think deleting stable and using unstable is what we want to do. The point of those monikers was to let us canary a jdk or android sdk or avd change.
I think what should happen is to make sure some tests are with with unstable and use "8701084295319811169". Then when we see those are all green update stable to also use avd "8701084295319811169"
To clarify, you basically want me to use a |
Yes :) If there a reason I am not seeing why that is a bad idea let me know. |
The platform configuration Let me know if it would be better though to canary just the one test target. |
jesswrd
added
the
autosubmit
jesswrd
changed the title
android_engine_vulkan_tests to Test Against SDK 36 Emulator
flutter-dashboard
bot
removed
the
autosubmit
…gainst SDK 36 Emulator (flutter/flutter#176985)
…gainst SDK 36 Emulator (flutter/flutter#176985)
…gainst SDK 36 Emulator (flutter/flutter#176985)
…gainst SDK 36 Emulator (flutter/flutter#176985)
…gainst SDK 36 Emulator (flutter/flutter#176985)
…gainst SDK 36 Emulator (flutter/flutter#176985)
…10244) Manual roll requested by [email protected] flutter/flutter@7cd821c...a873a27 2025-10-16 [email protected] [tool] makes listing a shader also as an asset a build failure (flutter/flutter#176866) 2025-10-16 [email protected] Roll Packages from d062181 to 835dccb (7 revisions) (flutter/flutter#177100) 2025-10-16 [email protected] Handle the new location of Perfetto in create_updated_flutter_deps.py (flutter/flutter#177099) 2025-10-16 [email protected] Implement dialog windows for the win32 platform (flutter/flutter#176309) 2025-10-16 [email protected] `SelectableRegion` should not show flutter rendered context menu when web context menu is enabled (flutter/flutter#176855) 2025-10-16 [email protected] Manual roll Skia to 2d9df7c70b6f (flutter/flutter#177074) 2025-10-16 [email protected] feat: add `OptionsViewOpenDirection.mostSpace` to `RawAutocomplete` (flutter/flutter#172997) 2025-10-16 [email protected] [Android] Refactor `ImageReaderSurfaceProducer` restoration after app resumes (flutter/flutter#175937) 2025-10-15 [email protected] Refactor: migrate fade upwards page transition builder to widgets (flutter/flutter#175560) 2025-10-15 [email protected] Marks Windows windowing_test to be unflaky (flutter/flutter#176701) 2025-10-15 [email protected] fix: 🐛 Add equality and hashCode implementations to ScrollAwareImageProvider (flutter/flutter#175038) 2025-10-15 [email protected] Updates `sliver_tree.1.dart` to use `MediaQuery.widthOf(context)` (flutter/flutter#176888) 2025-10-15 [email protected] [web] Fix focus issues in newer versions of Chrome (flutter/flutter#176938) 2025-10-15 [email protected] [Android 16] Update `android_engine_vulkan_tests` to Test Against SDK 36 Emulator (flutter/flutter#176985) 2025-10-15 [email protected] Fix key events interception by RadioGroup when no Radio is focused. (flutter/flutter#176335) 2025-10-15 [email protected] Update cherry-pick instructions to include instructions for pre-release CPs (flutter/flutter#177020) 2025-10-15 [email protected] Manual roll Skia to c501c727a007 (flutter/flutter#177015) 2025-10-15 [email protected] Update examples to latest Linux runner style (flutter/flutter#177033) 2025-10-15 [email protected] [material/menu_anchor.dart] Create internal menu controller if external controller is changed to null. (flutter/flutter#176375) 2025-10-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix - TalkBack does not announce list information (#174374)" (flutter/flutter#177062) 2025-10-14 [email protected] Implement Regular Windows for Linux (flutter/flutter#176187) 2025-10-14 [email protected] Fix - TalkBack does not announce list information (flutter/flutter#174374) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…inst SDK 36 Emulator" (#177292) Reverts #176985 Issue #170024 `android_engine_vulkan_tests` is very flaky https://flutter-dashboard.appspot.com/#/build?repo=flutter&branch=master&showMac=false&showWindows=false&showiOS=false&showAndroid=false&showBringup=true. We were waiting on android for a 36 system image that passed android testing. I believe the 36 image I am using is up to date, but it's possible an incompatible avd version was used (I chose the latest at the time). Before filing a ticket against android, check if the avd version is compatible.
… 36 Emulator (flutter#176985) Update `android_engine_vulkan_tests` to test against a system image and an AVD that supports Android 16. With that all android tests in CI test against a 36 emulator. `android_engine_vulkan_tests` will dogfood the `Linux_android_emu_unstable` configurations, including the latest from https://chrome-infra-packages.appspot.com/p/chromium/tools/android/avd/linux-amd64 . If there are no flakes after around ~200 commits, then I will update `Linux_android_emu` with `Linux_android_emu_unstable` configs. Fixes flutter#170024 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
…inst SDK 36 Emulator" (flutter#177292) Reverts flutter#176985 Issue flutter#170024 `android_engine_vulkan_tests` is very flaky https://flutter-dashboard.appspot.com/#/build?repo=flutter&branch=master&showMac=false&showWindows=false&showiOS=false&showAndroid=false&showBringup=true. We were waiting on android for a 36 system image that passed android testing. I believe the 36 image I am using is up to date, but it's possible an incompatible avd version was used (I chose the latest at the time). Before filing a ticket against android, check if the avd version is compatible.
2 participants
Update
android_engine_vulkan_teststo test against a system image and an AVD that supports Android 16. With that all android tests in CI test against a 36 emulator.android_engine_vulkan_testswill dogfood theLinux_android_emu_unstableconfigurations, including the latest from https://chrome-infra-packages.appspot.com/p/chromium/tools/android/avd/linux-amd64 . If there are no flakes after around ~200 commits, then I will updateLinux_android_emuwithLinux_android_emu_unstableconfigs.Fixes #170024
Partially Addresses #163071
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.