Roll dart sdk to 3.11.0-17.0.dev #176947
Merged
Roll dart sdk to 3.11.0-17.0.dev #176947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes since last roll ``` 2d8e0359a76 (tag: 3.11.0-17.0.dev, origin/lkgr-dev) Version 3.11.0-17.0.dev 06be66b5b60 [cfe] Don't nest deferred prefix scopes 07c9599ead5 [vm] Tweak location of Perfetto protos ``` Includes build changes to accommodate perfetto move.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the perfetto_root_path in engine/src/build_overrides/build.gni to point to a new location within the Dart SDK's third-party dependencies. This change is part of rolling the Dart SDK to version 3.11.0-17.0.dev and accommodates the relocation of Perfetto. My review includes a suggestion to adhere to the GN style guide regarding path formatting.
| perfetto_build_with_embedder = true | ||
|
|
||
| perfetto_root_path = "//flutter/third_party/perfetto/" | ||
| perfetto_root_path = "//flutter/third_party/dart/third_party/perfetto/src/" |
Contributor
There was a problem hiding this comment.
The repository style guide requires following the GN Style Guide.1 The GN Style Guide specifies that directory paths should not have a trailing slash. Please remove the trailing slash from this path.
For reference, the GN Style Guide says: 'Directory names should not have a trailing slash. So use //path/to/foo, not //path/to/foo/.'
Suggested change
| perfetto_root_path = "//flutter/third_party/dart/third_party/perfetto/src/" | |
| perfetto_root_path = "//flutter/third_party/dart/third_party/perfetto/src" |
Style Guide References
Footnotes
-
The repository style guide specifies that GN code should follow the official GN Style Guide. ↩
Member
Author
There was a problem hiding this comment.
The repository style guide requires following the GN Style Guide.1 The GN Style Guide specifies that directory paths should not have a trailing slash. Please remove the trailing slash from this path.
For reference, the GN Style Guide says: 'Directory names should not have a trailing slash. So use
//path/to/foo, not//path/to/foo/.'Style Guide References
Footnotes
- The repository style guide specifies that GN code should follow the official GN Style Guide. ↩
Trailing slash is needed here, without it the build fails:
╰─➤ git diff | cat
diff --git a/engine/src/build_overrides/build.gni b/engine/src/build_overrides/build.gni
index 5cb0d86dcd9..36a4c53233f 100644
--- a/engine/src/build_overrides/build.gni
+++ b/engine/src/build_overrides/build.gni
@@ -12,5 +12,5 @@ build_with_chromium = false
# builds in the Android tree.
perfetto_build_with_embedder = true
-perfetto_root_path = "//flutter/third_party/dart/third_party/perfetto/src/"
+perfetto_root_path = "//flutter/third_party/dart/third_party/perfetto/src"
╰─➤ engine/src/flutter/bin/et build
[2025-10-13 12:30:22.084947][linux/host_debug: GN]: FAILED
COMMAND:
~/p/f/f1/flutter/engine/src/flutter/tools/gn --runtime-mode debug --no-stripped --no-lto --rbe --no-goma
STDOUT:
ERROR at //third_party/protobuf/proto_library.gni:407:19: Can't load input file.
deps += [ plugin_host_label ]
^----------------
Unable to load:
~/p/f/f1/flutter/engine/src/flutter/third_party/dart/third_party/perfetto/srcsrc/protozero/protoc_plugin/BUILD.gn
I also checked in the secondary tree for:
~/p/f/f1/flutter/engine/src/flutter/build/secondary/flutter/third_party/dart/third_party/perfetto/srcsrc/protozero/protoc_plugin/BUILD.gn
Using prebuilt Dart SDK binary. If you are editing Dart sources and wish to compile the Dart SDK, set `--no-prebuilt-dart-sdk`.
Generating GN files in: out/host_debug
STDERR:
rmacnak-google
approved these changes
Oct 13, 2025
mraleph
approved these changes
Oct 13, 2025
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 15, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 15, 2025
…10229) Manual roll Flutter from e11e2c11288b to 7cd821c21093 (73 revisions) Manual roll requested by [email protected] flutter/flutter@e11e2c1...7cd821c 2025-10-14 [email protected] Fix computeDistanceToActualBaseline throws when accessing child size (flutter/flutter#176906) 2025-10-14 [email protected] iOS can set application locale before view controller is set (flutter/flutter#176592) 2025-10-14 [email protected] Roll ANGLE to a branch based on d9fa255a5c22 (flutter/flutter#176747) 2025-10-14 [email protected] Relands "Fixes keyboard selects disabled radio" (flutter/flutter#176977) 2025-10-14 [email protected] Fix expansion tile is missing state announcement on non-Apple platforms (flutter/flutter#175480) 2025-10-14 [email protected] impeller: allows access of float uniforms by name (flutter/flutter#176728) 2025-10-14 [email protected] Roll dart sdk to 3.11.0-17.0.dev (flutter/flutter#176947) 2025-10-13 [email protected] Move iOS integration tests (flutter/flutter#176940) 2025-10-13 [email protected] Make sure that an InputDatePickerFormField doesn't crash in 0x0 envir… (flutter/flutter#176047) 2025-10-13 [email protected] [web] Match the behavior of other platforms in Web Locale.toString if the country code is an empty string (flutter/flutter#176862) 2025-10-13 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fixes keyboard selects disabled radio (#176727)" (flutter/flutter#176958) 2025-10-13 [email protected] Fixes keyboard selects disabled radio (flutter/flutter#176727) 2025-10-13 [email protected] Roll Packages from e319c40 to d062181 (2 revisions) (flutter/flutter#176916) 2025-10-13 [email protected] Roll SwiftShader to 794b0cfce1d8 (flutter/flutter#176806) 2025-10-13 [email protected] Make DropdownMenu generic type non nullable (flutter/flutter#176711) 2025-10-12 [email protected] Roll Fuchsia Linux SDK from BWGpRvpdQh-HJpq1c... to _dd0Jv50H0oUI2Ad8... (flutter/flutter#176895) 2025-10-11 [email protected] Roll Fuchsia Linux SDK from JpiUsek1hU5r9QVKP... to BWGpRvpdQh-HJpq1c... (flutter/flutter#176880) 2025-10-11 [email protected] fix: content hash check for LUCI_CONTEXT (flutter/flutter#176867) 2025-10-11 [email protected] Feat: make tooltip position customizeable (flutter/flutter#175047) 2025-10-11 [email protected] Roll Dart SDK from d88d8bf2b53c to 65b171958c93 (3 revisions) (flutter/flutter#176871) 2025-10-11 [email protected] feat: apply radioGroup role to segmented control widgets (flutter/flutter#176157) 2025-10-10 [email protected] Make sure that a CheckboxMenuButton doesn't crash in 0x0 environment (flutter/flutter#176450) 2025-10-10 [email protected] [WebParagraph] Support for more styles, placeholders, decorations, etc (flutter/flutter#172853) 2025-10-10 [email protected] Set up a version of build_ios_framework_module_test that only runs on x64 machines and extend its timeout (flutter/flutter#176811) 2025-10-10 [email protected] Roll Packages from 0b41de3 to e319c40 (1 revision) (flutter/flutter#176833) 2025-10-10 [email protected] [tool/dap] Forward app.warning events from Flutter to DAP client (flutter/flutter#176827) 2025-10-10 [email protected] Roll Dart SDK from 70c00d3ceb3a to d88d8bf2b53c (1 revision) (flutter/flutter#176830) 2025-10-10 [email protected] Remove unnecessary nullable types in examples. (flutter/flutter#176713) 2025-10-10 [email protected] Roll Fuchsia Linux SDK from xArtL4DH0FsdwSqG_... to JpiUsek1hU5r9QVKP... (flutter/flutter#176822) 2025-10-10 [email protected] Cleanup OutlinedButton.icon documentation and implementation (flutter/flutter#176630) 2025-10-10 [email protected] [HCPP] Properly remove hcpp views that are no longer visible (flutter/flutter#176742) 2025-10-10 [email protected] Make sure that an InputChip doesn't crash in 0x0 environment (flutter/flutter#175930) 2025-10-10 [email protected] Update Flutter templates' Dart style (flutter/flutter#175963) 2025-10-10 [email protected] Make sure that a DropdownButtonFormField doesn't crash in 0x0 environ… (flutter/flutter#174958) 2025-10-10 [email protected] Make sure that an InkWell doesn't crash in 0x0 environment (flutter/flutter#175871) 2025-10-10 [email protected] Handle#6537 end drawer button (flutter/flutter#173026) 2025-10-10 [email protected] Roll Dart SDK from a9b7bd4b0b32 to 70c00d3ceb3a (4 revisions) (flutter/flutter#176815) 2025-10-10 [email protected] Change default Linux thread policy to merge platform and UI threads. (flutter/flutter#176759) 2025-10-09 [email protected] [ Tool ] Roll package:dwds to 26.0.0 (flutter/flutter#176808) 2025-10-09 [email protected] Update `CHANGELOG` to include 3.35.6 notes (flutter/flutter#176803) 2025-10-09 [email protected] Announce text and button together when DropdownMenu is treated as a button (flutter/flutter#176428) 2025-10-09 [email protected] [native_assets] create macOS CCompilerConfig via xcrun --find (flutter/flutter#175717) 2025-10-09 [email protected] [Impeller] Fix broken links in README. (flutter/flutter#176770) 2025-10-09 [email protected] Fix links to Custom Flutter Engine Embedders in README. (flutter/flutter#175807) ...
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
Changes since last roll ``` 2d8e0359a76 (tag: 3.11.0-17.0.dev, origin/lkgr-dev) Version 3.11.0-17.0.dev 06be66b5b60 [cfe] Don't nest deferred prefix scopes 07c9599ead5 [vm] Tweak location of Perfetto protos ``` Includes build changes to accommodate perfetto move.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes since last roll
Includes build changes to accommodate perfetto move.