[CP-Beta] fix: content hash check for LUCI_CONTEXT (#176867) #176883
Conversation
When running on LUCI, the environment variable is LUCI_CONTEXT fixes: flutter#176838
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in detecting the LUCI continuous integration environment. The fix involves replacing the environment variable LUCI_CI with the correct LUCI_CONTEXT. This change has been consistently applied across the PowerShell script (content_aware_hash.ps1), the shell script (content_aware_hash.sh), and the corresponding Dart test file (content_aware_hash_test.dart). The update to the test ensures the fix is verified. The changes are correct and address the issue described.
jtmcdole
added
the
autosubmit
auto-submit
bot
merged commit ced5a93
into
flutter:flutter-3.38-candidate.0
2 participants
When running on LUCI, the environment variable is LUCI_CONTEXT
fixes: #176838