[CP-stable]fix: remove final class modifier on MenuController #176725

flutteractionsbot · 2025-10-08T16:29:10Z

This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

Issue Link:

What is the link to the issue this cherry-pick is addressing?

#174082

Changelog Description:

Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples

#174082 Apps, on all platforms, that extend MenuController class see a compile time failure when building.

Impact Description:

What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Apps that used to rely on extended MenuControllers won't build.

Workaround:

Is there a workaround for this issue?

The app will have to modify their local Flutter repository. Otherwise, if the app really rely on extending the MenuController class to do custom logic, I can think of no ways for them to continue this customization under this restriction.

Risk:

What is the risk level of this cherry-pick?

Low
Medium
High

Test Coverage:

Are you confident that your fix is well-tested by automated tests?

Yes
No

Validation Steps:

What are the steps to validate that this fix works?

The following snippet builds.

import 'package:flutter/material.dart';

class ExtendedMenuController extends MenuController {
  ExtendedMenuController();
}

fix: remove final class modifier on MenuController fixes: flutter#174082 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

flutteractionsbot · 2025-10-08T16:29:12Z

@dkwingsmt please fill out the PR description above, afterwards the release team will review this request.

flutter-dashboard · 2025-10-08T16:29:14Z

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

gemini-code-assist

Code Review

This pull request removes the final modifier from the MenuController class, allowing it to be extended. A corresponding test case has been added to verify that MenuController can be subclassed and its methods overridden. The changes are correct and well-tested. I've added a couple of suggestions to improve documentation in the new test code to align with the Flutter style guide.

gemini-code-assist · 2025-10-08T16:32:16Z

packages/flutter/test/widgets/raw_menu_anchor_test.dart

+// Custom MenuController that extends the base MenuController
+// This verifies that the final modifier has been removed


According to the Flutter Style Guide, it's recommended to use /// for documentation, even for test-only classes. This improves readability and maintainability.

Ref: Flutter Style Guide - Documentation (line 62).

Suggested change

// Custom MenuController that extends the base MenuController

// This verifies that the final modifier has been removed

/// A custom [MenuController] that extends the base [MenuController] to verify

/// that the `final` modifier has been removed.

gemini-code-assist · 2025-10-08T16:32:16Z

packages/flutter/test/widgets/raw_menu_anchor_test.dart

+  int openCallCount = 0;
+  int closeCallCount = 0;


According to the Flutter Style Guide, all public members should have documentation. Please add doc comments for these fields to improve code clarity.

Ref: Flutter Style Guide - Documentation (line 53).

Suggested change

int openCallCount = 0;

int closeCallCount = 0;

/// The number of times [open] has been called.

int openCallCount = 0;

/// The number of times [close] has been called.

int closeCallCount = 0;

reidbaker · 2025-10-21T14:26:09Z

@dkwingsmt can you update the pr description to a changelog that meets our guidelines.

@justinmc for framework approval + autosubmit.

justinmc

LGTM 👍 . And confirmed that this is a high value low risk thing to cherry pick.

dkwingsmt · 2025-10-21T17:21:57Z

@reidbaker Can you tell me where it doesn't meet? I specifically read the guideline before writing the current one.

reidbaker · 2025-10-21T17:30:18Z

The MenuController class is marked final and breaks apps that extend this class.

https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md

"What the scenario is (describe the problem). What platforms it affects. In what context it may occur. How likely it is to occur"
and
"When $scenario [on $platform], $problem_description"

Here is my attempt at following the guidelines.

flutter/174082 Apps, on all platforms, that extend MenuController class see a compile time failure when building.

Starts with the issue, describes where in the developers code would be impacted, describes the problem in the state prior to being fixed and describes what platforms are impacted.

dkwingsmt · 2025-10-21T17:43:35Z

I see. Yeah, I thought I would skip the platforms since they apply to all platforms. Thank you.

reidbaker · 2025-10-21T17:48:02Z

No worries you are far from the first person to be confused.
I put up #177333 to try to make it easier for cherry pick requesters.

reidbaker · 2025-10-21T17:48:27Z

I see. Yeah, I thought I would skip the platforms since they apply to all platforms. Thank you.

The issue is users dont actually think that no platform information means all platforms.

…er (flutter/flutter#176725)

flutteractionsbot added the cp: review Cherry-picks in the review queue label Oct 8, 2025

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 8, 2025

gemini-code-assist bot reviewed Oct 8, 2025

View reviewed changes

reidbaker requested review from dkwingsmt and justinmc October 21, 2025 14:24

reidbaker approved these changes Oct 21, 2025

View reviewed changes

justinmc approved these changes Oct 21, 2025

View reviewed changes

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 21, 2025

auto-submit bot merged commit 284ec68 into flutter:flutter-3.35-candidate.0 Oct 21, 2025
139 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 23, 2025

284ec6804 [CP-stable]fix: remove final class modifier on MenuControll…

b399fc6

…er (flutter/flutter#176725)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 23, 2025

284ec6804 [CP-stable]fix: remove final class modifier on MenuControll…

1e4ff09

…er (flutter/flutter#176725)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2025

284ec6804 [CP-stable]fix: remove final class modifier on MenuControll…

81f4c78

…er (flutter/flutter#176725)

		// Custom MenuController that extends the base MenuController
		// This verifies that the final modifier has been removed

[CP-stable]fix: remove final class modifier on MenuController #176725

[CP-stable]fix: remove final class modifier on MenuController #176725

Conversation

flutteractionsbot commented Oct 8, 2025 • edited by dkwingsmt Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Link:

Changelog Description:

Impact Description:

Workaround:

Risk:

Test Coverage:

Validation Steps:

Uh oh!

flutteractionsbot commented Oct 8, 2025

Uh oh!

flutter-dashboard bot commented Oct 8, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

reidbaker commented Oct 21, 2025

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dkwingsmt commented Oct 21, 2025

Uh oh!

reidbaker commented Oct 21, 2025

Uh oh!

dkwingsmt commented Oct 21, 2025

Uh oh!

reidbaker commented Oct 21, 2025

Uh oh!

reidbaker commented Oct 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

flutteractionsbot commented Oct 8, 2025 •

edited by dkwingsmt

Loading