-
Notifications
You must be signed in to change notification settings - Fork 29.7k
fix: build windows_arm artifacts for cah #176723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds target to merge queue, the only place that the CAH is used to produce artifacts. Today this is built in post submit and only uploads to the githash artifact. This should not add these artifacts to release builders as the enabled branches are "master"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
Thank you for your contribution. I have one suggestion regarding code consistency to improve readability. Please see the inline comment.
| release_build: "true" | ||
| add_recipes_cq: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with other targets in this file, it would be better to place add_recipes_cq before release_build.
Most other targets in this file that have both of these properties list add_recipes_cq first. For example:
Linux linux_arm_host_engineLinux linux_host_engineLinux linux_android_aot_engine
Maintaining a consistent order for properties improves the readability and maintainability of this large configuration file. This aligns with the style guide's philosophy to optimize for readability.
<style_guide_reference start_line="29" end_line="29" guide="REPO" />
add_recipes_cq: "true"
release_build: "true"|
autosubmit label was removed for flutter/flutter/176723, because - The status or check suite Linux mac_android_aot_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/176723, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Autosubmit is drunk; google3 testing wasn't failing. |
Adds target to merge queue, the only place that the CAH is used to produce artifacts. Today this is built in post submit and only uploads to the githash artifact. This should not add these artifacts to release builders as the `enabled_branches` is set to "master" fixes flutter#176603
Adds target to merge queue, the only place that the CAH is used to produce artifacts. Today this is built in post submit and only uploads to the githash artifact.
This should not add these artifacts to release builders as the
enabled_branchesis set to "master"fixes #176603