Skip to content

Conversation

@hellohuanlin
Copy link
Contributor

@hellohuanlin hellohuanlin commented Oct 6, 2025

This PR is an MVP version to address web view not tappable issue on iOS 26 (#175099). This issue cannot be fixed with pointer_interceptor, so if your issue can be fixed by it, it would be a different issue.

This PR performance a naive hit test that decides to block platform view gestures if the touch falls within the "overlap" region between Flutter widgets and platform view. This is not a complete solution since there are a few drawback:

  1. There can be use cases where even if we touch outside of "overlap" (or no overlap at all), we still want to block gestures.
  2. overlaps are merged into a single UIView in our current implementation. This means if you have multiple overlaps, the blocking region would be a bounding box that contains all overlaps.

To address the above drawbacks, a complete solution would require accessing Flutter's gesture arena, which will take longer time.

IMG_0078.mp4

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

Part of #175099

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@github-actions github-actions bot added platform-ios iOS applications specifically engine flutter/engine related. See also e: labels. team-ios Owned by iOS platform team labels Oct 6, 2025
@hellohuanlin hellohuanlin force-pushed the pv_hit_test_overlay branch 5 times, most recently from ac7fe9e to e8128a3 Compare October 9, 2025 19:49
@hellohuanlin hellohuanlin requested a review from jmagman October 9, 2025 19:53
@hellohuanlin hellohuanlin marked this pull request as ready for review October 9, 2025 19:53
@hellohuanlin hellohuanlin requested a review from a team as a code owner October 9, 2025 19:53
@hellohuanlin hellohuanlin requested a review from vashworth October 9, 2025 19:53
@hellohuanlin hellohuanlin changed the title [DRAFT][ios][platform_view]block gesture with hitTest by overlay layers [ios][platform_view]block gesture with hitTest by overlay layers Oct 9, 2025
@hellohuanlin
Copy link
Contributor Author

I'm closing this - the complete solution went smoother than what i anticipated, so we are gonna skip this MVP version. @jmagman @vashworth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels. platform-ios iOS applications specifically team-ios Owned by iOS platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant