Build engine for windows_arm on beta and stable #176385
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables the windows_arm_host_engine build for beta and stable branches by removing the enabled_branches restriction. While this aligns with the updated Dart SDK support, enabling a build on release branches without a trial period can be risky. If the build is unstable, it could block releases. I have provided a suggestion to mitigate this risk by using the bringup: true flag, which will allow the build's stability to be monitored without blocking the tree on failures.
|
This is also needed on the "master" channel. If checking out the stable version tags of git e.g. via subosito/flutter-action, it still uses the engine builds of the according stable versions, which do not exist yet and then falls back to x64: flutter/bin/internal/update_dart_sdk.ps1 Line 63 in 908012d There don't exist any arm64 windows engine builds (in contrast to linux-arm64) at the moment. Is there a browsable index of all builds? E.g. for this one? |
|
The patch and the verification of the dependent issues no longer being relevant looks good to me. |
|
@chinmaygarde I think the team-infra label doesn't apply to Pull Requests |
There are! dart compile for flutter: |
|
I created this PR before #176723 was merged, and didn't update. |
|
@jtmcdole Do you want to review this? For the additional channels? |
|
@jtmcdole Gentle ping. |
3 participants
According to #113931 and #123288 and flutter/engine#40546 (comment) the beta and stable builds were removed because Dart didn't support arm64 on stable, too. This is now obsolete as the Dart SDK for arm64 is available on stable (since Dart 3.3.0): https://dart.dev/get-dart/archive
Basically reverts flutter/engine#40546
Contributes to #164431, #62597
Probably closes #137161
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.