Make sure that a MenuAnchor doesn't crash in 0x0 environment #176302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a new widget test for MenuAnchor to ensure it does not crash when placed in a zero-sized environment, such as a SizedBox.shrink. The test verifies that the MenuAnchor widget correctly handles being laid out with zero area by asserting its size is Size.zero.
Contributor
|
Since |
ahmedsameha1
force-pushed
the
handle#6537-MenuAnchor
branch
from
0ca9be5 to
efbb457
Compare
dkwingsmt
approved these changes
Oct 20, 2025
Contributor
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
LGTM.
(I don't know why the unit tests keep failing. They don't fail on my computer. Let me retry them again.)
victorsanni
reviewed
Oct 20, 2025
ahmedsameha1
force-pushed
the
handle#6537-MenuAnchor
branch
from
2c913fa to
0a30f06
Compare
victorsanni
reviewed
Oct 20, 2025
| }); | ||
|
|
||
| testWidgets('MenuAnchor does not crash at zero area', (WidgetTester tester) async { | ||
| final Size temp = tester.view.physicalSize; |
Contributor
There was a problem hiding this comment.
Instead of creating a new local variable, you can just add this one-liner instead:
addTearDown(tester.view.reset);
Contributor
|
Ohhhh right, we haven't reverted the view size after setting it. |
victorsanni
approved these changes
Oct 20, 2025
dkwingsmt
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 3, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 4, 2025
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…#176302) This is my attempt to handle flutter#6537 for the MenuAnchor widget. --------- Co-authored-by: Tong Mu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the MenuAnchor widget.