Add an AppDelegate callback for implicit FlutterEngines #176240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vashworth
requested review from
hellohuanlin and
stuartmorgan-g
and removed request for
a team
github-actions
bot
added
platform-ios
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable FlutterImplicitEngineDelegate for add-to-app scenarios, allowing plugin registration with implicitly created engines. The refactoring of FlutterPluginRegistrar is well-executed, enhancing the API's structure and clarity. The changes are well-tested. I have a few minor suggestions regarding code style and maintainability to further improve the quality of the code.
Comment on lines
+17
to
+20
| let batteryChannel = FlutterMethodChannel( | ||
| name: "samples.flutter.dev/battery", | ||
| binaryMessenger: engineBridge.applicationRegistrar.messenger() | ||
| ) |
Contributor
There was a problem hiding this comment.
The batteryChannel constant is created but never used. If this is for demonstration purposes, consider commenting it out or removing it to avoid confusion and prevent potential compiler warnings about unused variables.
// Example of creating a method channel:
// let batteryChannel = FlutterMethodChannel(
// name: "samples.flutter.dev/battery",
// binaryMessenger: engineBridge.applicationRegistrar.messenger()
// )|
|
||
| import XCTest | ||
|
|
||
| final class xcode_uikit_swiftUITests: XCTestCase { |
Contributor
There was a problem hiding this comment.
The class name xcode_uikit_swiftUITests does not follow the UpperCamelCase convention for type names as recommended by the Google Swift Style Guide.1 Please consider renaming it to XcodeUIKitSwiftUITests.
This also applies to UITests-SceneEvents-NoApplicationEvents.swift and UITests-SceneEventsNoConnect-NoApplicationEvents.swift.
Suggested change
| final class xcode_uikit_swiftUITests: XCTestCase { | |
| final class XcodeUIKitSwiftUITests: XCTestCase { |
Style Guide References
Footnotes
-
The Flutter style guide specifies that Swift code should follow the Google Swift Style Guide, which recommends
UpperCamelCasefor type names. ↩
|
|
||
| import XCTest | ||
|
|
||
| final class xcode_uikit_swiftUITests: XCTestCase { |
Contributor
There was a problem hiding this comment.
The class name xcode_uikit_swiftUITests does not follow the UpperCamelCase convention for type names as recommended by the Google Swift Style Guide.1 Please consider renaming it to XcodeUIKitSwiftUITests.
Suggested change
| final class xcode_uikit_swiftUITests: XCTestCase { | |
| final class XcodeUIKitSwiftUITests: XCTestCase { |
Style Guide References
Footnotes
-
The Flutter style guide specifies that Swift code should follow the Google Swift Style Guide, which recommends
UpperCamelCasefor type names. ↩
|
|
||
| import XCTest | ||
|
|
||
| final class xcode_uikit_swiftUITests: XCTestCase { |
Contributor
There was a problem hiding this comment.
The class name xcode_uikit_swiftUITests does not follow the UpperCamelCase convention for type names as recommended by the Google Swift Style Guide.1 Please consider renaming it to XcodeUIKitSwiftUITests.
Suggested change
| final class xcode_uikit_swiftUITests: XCTestCase { | |
| final class XcodeUIKitSwiftUITests: XCTestCase { |
Style Guide References
Footnotes
-
The Flutter style guide specifies that Swift code should follow the Google Swift Style Guide, which recommends
UpperCamelCasefor type names. ↩
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm
Outdated
Show resolved
Hide resolved
stuartmorgan-g
requested changes
Oct 2, 2025
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine_Internal.h
Outdated
Show resolved
Hide resolved
.../src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPluginAppLifeCycleDelegate.mm
Outdated
Show resolved
Hide resolved
...tter/shell/platform/darwin/ios/framework/Source/FlutterPluginAppLifeCycleDelegate_internal.h
Outdated
Show resolved
Hide resolved
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
Outdated
Show resolved
Hide resolved
engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterEngine.h
Outdated
Show resolved
Hide resolved
engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterEngine.h
Outdated
Show resolved
Hide resolved
engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterEngine.h
Outdated
Show resolved
Hide resolved
.../src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPluginAppLifeCycleDelegate.mm
Show resolved
Hide resolved
| self = [super init]; | ||
| _pluginRegistry = engine; | ||
| _applicationRegistrar = | ||
| [engine registrarForApplication:@"io.flutter.flutter.application_registrar"]; |
Contributor
There was a problem hiding this comment.
Why the double-flutter?
Contributor
Author
There was a problem hiding this comment.
I'm assuming I copied from here:
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm
Outdated
Show resolved
Hide resolved
9 tasks
stuartmorgan-g
requested changes
Oct 3, 2025
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm
Outdated
Show resolved
Hide resolved
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm
Outdated
Show resolved
Hide resolved
engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterEngine.h
Outdated
Show resolved
Hide resolved
engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterEngine.h
Outdated
Show resolved
Hide resolved
engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterEngine.h
Outdated
Show resolved
Hide resolved
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
Show resolved
Hide resolved
stuartmorgan-g
approved these changes
Oct 3, 2025
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with some minor final suggestions. They should be straightforward changes, so approving now to avoid an extra review cycle.
engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterEngine.h
Outdated
Show resolved
Hide resolved
engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterViewController.mm
Outdated
Show resolved
Hide resolved
vashworth
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 7, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 7, 2025
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Oct 7, 2025
This PR introduces a new protocol `FlutterImplicitEngineDelegate`, which adds a callback called `didInitializeImplicitFlutterEngine`, which returns a new interface called `FlutterImplicitEngineBridge`. This was added to expose parts of an implicit `FlutterEngine`, such as when created from a `FlutterViewController` in a storyboard. ``` swift diff @objc class AppDelegate: FlutterAppDelegate, FlutterImplicitEngineDelegate { override func application( _ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? ) -> Bool { return super.application(application, didFinishLaunchingWithOptions: launchOptions) } } func didInitializeImplicitFlutterEngine(_ engineBridge: FlutterImplicitEngineBridge) { // Register plugins with `engineBridge.pluginRegistry` GeneratedPluginRegistrant.register(with: engineBridge.pluginRegistry) // Create method channels with `engineBridge.applicationRegistrar.messenger()` let batteryChannel = FlutterMethodChannel( name: "samples.flutter.dev/battery", binaryMessenger: engineBridge.applicationRegistrar.messenger() ) ... // Create platform views with `engineBridge.applicationRegistrar.messenger()` let factory = FLNativeViewFactory(messenger: engineBridge.applicationRegistrar.messenger()) ... } ``` This PR also refactors `FlutterPluginRegistrar` into 3 separate protocols: * `FlutterBaseRegistrar` * `FlutterApplicationRegistrar` * `FlutterPluginRegistrar` Most methods are moved from `FlutterPluginRegistrar` to `FlutterBaseRegistrar` and then `FlutterPluginRegistrar` and `FlutterApplicationRegistrar` inherit from `FlutterBaseRegistrar`. `FlutterPluginRegistrar` also has additional methods specific to it - there are no meaningful/breaking changes to `FlutterPluginRegistrar`. Fixes flutter#173357. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
okorohelijah
pushed a commit
to okorohelijah/flutter
that referenced
this pull request
Oct 7, 2025
This PR introduces a new protocol `FlutterImplicitEngineDelegate`, which adds a callback called `didInitializeImplicitFlutterEngine`, which returns a new interface called `FlutterImplicitEngineBridge`. This was added to expose parts of an implicit `FlutterEngine`, such as when created from a `FlutterViewController` in a storyboard. ``` swift diff @objc class AppDelegate: FlutterAppDelegate, FlutterImplicitEngineDelegate { override func application( _ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? ) -> Bool { return super.application(application, didFinishLaunchingWithOptions: launchOptions) } } func didInitializeImplicitFlutterEngine(_ engineBridge: FlutterImplicitEngineBridge) { // Register plugins with `engineBridge.pluginRegistry` GeneratedPluginRegistrant.register(with: engineBridge.pluginRegistry) // Create method channels with `engineBridge.applicationRegistrar.messenger()` let batteryChannel = FlutterMethodChannel( name: "samples.flutter.dev/battery", binaryMessenger: engineBridge.applicationRegistrar.messenger() ) ... // Create platform views with `engineBridge.applicationRegistrar.messenger()` let factory = FLNativeViewFactory(messenger: engineBridge.applicationRegistrar.messenger()) ... } ``` This PR also refactors `FlutterPluginRegistrar` into 3 separate protocols: * `FlutterBaseRegistrar` * `FlutterApplicationRegistrar` * `FlutterPluginRegistrar` Most methods are moved from `FlutterPluginRegistrar` to `FlutterBaseRegistrar` and then `FlutterPluginRegistrar` and `FlutterApplicationRegistrar` inherit from `FlutterBaseRegistrar`. `FlutterPluginRegistrar` also has additional methods specific to it - there are no meaningful/breaking changes to `FlutterPluginRegistrar`. Fixes flutter#173357. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 8, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 8, 2025
Roll Flutter from 908012d58baa to e11e2c11288b (39 revisions) flutter/flutter@908012d...e11e2c1 2025-10-08 [email protected] Configure FfiNative resolver on dart:io (flutter/flutter#176621) 2025-10-08 [email protected] Marks Linux_pixel_7pro service_extensions_test to be unflaky (flutter/flutter#176700) 2025-10-08 [email protected] Keyboard Animation Fix (flutter/flutter#176418) 2025-10-08 [email protected] Feat: Add carousel view builder (flutter/flutter#172837) 2025-10-08 [email protected] Roll Skia from d10a0d877ff4 to ea7cdbc6b986 (15 revisions) (flutter/flutter#176686) 2025-10-08 [email protected] Roll Fuchsia Linux SDK from jJr3my9C6TwYWPygi... to xrIAL91ngrd-wNr9S... (flutter/flutter#176682) 2025-10-08 [email protected] Fix InputDecoration helper/error padding is not compliant (flutter/flutter#176353) 2025-10-08 [email protected] Fix PopupMenu does not update when PopupMenuTheme in Theme changes. (flutter/flutter#175513) 2025-10-07 [email protected] Roll Dart SDK to 3.10.0-290.1.beta (flutter/flutter#176629) 2025-10-07 [email protected] [ Tool ] Output `app.dtd` and `app.devTools` in machine mode (flutter/flutter#176655) 2025-10-07 [email protected] Rename UIScene integration test projects and fix Xcode compatibility (flutter/flutter#176635) 2025-10-07 [email protected] Selecting an implementation widget with the on-device inspector opens the code location for the nearest project widget (flutter/flutter#176530) 2025-10-07 [email protected] Migrate to `WidgetStateInputBorder` (flutter/flutter#176386) 2025-10-07 [email protected] Make it clear that you need to install clangd in VSCode intellisense c++ config (flutter/flutter#176609) 2025-10-07 [email protected] Bump the customer tests to pick up an update to Zulip's tests. (flutter/flutter#176463) 2025-10-07 [email protected] Roll Packages from d3ef88b to 8ca6416 (2 revisions) (flutter/flutter#176633) 2025-10-07 [email protected] Add fallback for 'scene:willConnectToSession:options' (flutter/flutter#176580) 2025-10-07 [email protected] Roll Skia from d09786dfb854 to d10a0d877ff4 (11 revisions) (flutter/flutter#176616) 2025-10-07 [email protected] [ Widget Preview ] Rework UI and theming (flutter/flutter#176581) 2025-10-07 [email protected] Handle FlutterEngine registration when embedded in Multi-Scene apps (flutter/flutter#176490) 2025-10-07 [email protected] Fix code style in Linux embedder template (flutter/flutter#176256) 2025-10-07 [email protected] Add tooling to migrate to UIScene (flutter/flutter#176427) 2025-10-06 [email protected] Bump customer tests.version to 986c4326b4e4bb4e37bc963c2cc2aaa10b943859 (flutter/flutter#176594) 2025-10-06 [email protected] Fix typo in pages.dart (flutter/flutter#176438) 2025-10-06 [email protected] Fix: Update anchorRect for overlayBuilder when anchor moves (flutter/flutter#169814) 2025-10-06 [email protected] Roll Fuchsia Linux SDK from Zm6K_3gP3VCaMy9rH... to jJr3my9C6TwYWPygi... (flutter/flutter#176591) 2025-10-06 [email protected] Fix deprecated configureStatusBarForFullscreenFlutterExperience for Android 15+ (flutter/flutter#175501) 2025-10-06 [email protected] updates docs for flutter engine footprint (flutter/flutter#176217) 2025-10-06 [email protected] [ Widget Preview ] Fix `WidgetInspectorService` override (flutter/flutter#176550) 2025-10-06 [email protected] Fix NavigatorBar lacks visual feedback (flutter/flutter#175182) 2025-10-06 [email protected] Roll Packages from e401aeb to d3ef88b (4 revisions) (flutter/flutter#176582) 2025-10-06 [email protected] Roll Dart SDK from 898380a41c90 to 6b0193498f09 (2 revisions) (flutter/flutter#176576) 2025-10-06 [email protected] Roll Skia from bc7cf194f4ee to d09786dfb854 (1 revision) (flutter/flutter#176577) 2025-10-06 [email protected] Roll vulkan-deps to a9e2ca3b (flutter/flutter#176322) 2025-10-06 [email protected] Add an AppDelegate callback for implicit FlutterEngines (flutter/flutter#176240) 2025-10-06 [email protected] Roll Skia from 45191c22b15c to bc7cf194f4ee (2 revisions) (flutter/flutter#176572) 2025-10-06 [email protected] [ Widget Preview ] Fix type error when retrieving flags from persistent preferences (flutter/flutter#176546) 2025-10-06 [email protected] Roll Skia from 1fd0ca1f2120 to 45191c22b15c (3 revisions) (flutter/flutter#176556) 2025-10-05 [email protected] Roll Dart SDK from 016a8c0045fd to 898380a41c90 (1 revision) (flutter/flutter#176549) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
This PR introduces a new protocol `FlutterImplicitEngineDelegate`, which adds a callback called `didInitializeImplicitFlutterEngine`, which returns a new interface called `FlutterImplicitEngineBridge`. This was added to expose parts of an implicit `FlutterEngine`, such as when created from a `FlutterViewController` in a storyboard. ``` swift diff @objc class AppDelegate: FlutterAppDelegate, FlutterImplicitEngineDelegate { override func application( _ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? ) -> Bool { return super.application(application, didFinishLaunchingWithOptions: launchOptions) } } func didInitializeImplicitFlutterEngine(_ engineBridge: FlutterImplicitEngineBridge) { // Register plugins with `engineBridge.pluginRegistry` GeneratedPluginRegistrant.register(with: engineBridge.pluginRegistry) // Create method channels with `engineBridge.applicationRegistrar.messenger()` let batteryChannel = FlutterMethodChannel( name: "samples.flutter.dev/battery", binaryMessenger: engineBridge.applicationRegistrar.messenger() ) ... // Create platform views with `engineBridge.applicationRegistrar.messenger()` let factory = FLNativeViewFactory(messenger: engineBridge.applicationRegistrar.messenger()) ... } ``` This PR also refactors `FlutterPluginRegistrar` into 3 separate protocols: * `FlutterBaseRegistrar` * `FlutterApplicationRegistrar` * `FlutterPluginRegistrar` Most methods are moved from `FlutterPluginRegistrar` to `FlutterBaseRegistrar` and then `FlutterPluginRegistrar` and `FlutterApplicationRegistrar` inherit from `FlutterBaseRegistrar`. `FlutterPluginRegistrar` also has additional methods specific to it - there are no meaningful/breaking changes to `FlutterPluginRegistrar`. Fixes flutter#173357. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new protocol
FlutterImplicitEngineDelegate, which adds a callback calleddidInitializeImplicitFlutterEngine, which returns a new interface calledFlutterImplicitEngineBridge.This was added to expose parts of an implicit
FlutterEngine, such as when created from aFlutterViewControllerin a storyboard.This PR also refactors
FlutterPluginRegistrarinto 3 separate protocols:FlutterBaseRegistrarFlutterApplicationRegistrarFlutterPluginRegistrarMost methods are moved from
FlutterPluginRegistrartoFlutterBaseRegistrarand thenFlutterPluginRegistrarandFlutterApplicationRegistrarinherit fromFlutterBaseRegistrar.FlutterPluginRegistraralso has additional methods specific to it - there are no meaningful/breaking changes toFlutterPluginRegistrar.Fixes #173357.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.