Implement framework interface for the dialog window archetype #176202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
the
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the concept of dialog windows to the Flutter windowing API. It adds new classes like DialogWindowController and DialogWindow, and refactors common windowing functionality into a WindowControllerCommon mixin. The implementation for dialogs on specific platforms is not included in this change, which focuses only on the API definition.
mattkae
requested review from
justinmc,
knopp,
loic-sharma and
robert-ancell
mattkae
commented
Sep 29, 2025
justinmc
reviewed
Sep 29, 2025
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
Mostly small stuff in the comments, the only real thing is tests. We should probably test this even though it's incomplete. I guess we can't test anything related to the engine, but just writing unit tests for the framework code that's here should be fine.
| FlutterView? parent, | ||
| String? title, | ||
| }) { | ||
| throw UnimplementedError('Dialog windows are not yet implemented on Windows.'); |
Contributor
There was a problem hiding this comment.
Assuming it makes sense to you, could you add this kind of error message to the other UnimplementedErrors in this PR?
Contributor
Author
There was a problem hiding this comment.
This is the only UnimplementedError in this work right now
Contributor
Author
|
@justinmc Added tests and responded to your feedback 🎉 |
justinmc
approved these changes
Sep 30, 2025
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
Thanks for doing all the work to add those monotonous tests 🙏 .
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 1, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 1, 2025
…10145) Manual roll requested by [email protected] flutter/flutter@96fe3b3...c9608e2 2025-09-30 [email protected] Implement framework interface for the dialog window archetype (flutter/flutter#176202) 2025-09-30 [email protected] Update flutter test to use SemanticsFlags (flutter/flutter#175987) 2025-09-30 [email protected] Set minimum supported java version to 17 (flutter/flutter#176226) 2025-09-30 [email protected] Reduce timeout for Linux web_tool_tests back to 60 (flutter/flutter#176286) 2025-09-30 [email protected] Roll Packages from 34eec78 to 287739d (9 revisions) (flutter/flutter#176284) 2025-09-30 [email protected] [web] Bump Firefox to 143.0 (flutter/flutter#176110) 2025-09-30 [email protected] Migrate to `WidgetStateBorderSide` (flutter/flutter#176164) 2025-09-30 [email protected] Enhance input decorator padding logic for character counter in text f… (flutter/flutter#175706) 2025-09-30 [email protected] Update the test package for the web engine unit test bits. (flutter/flutter#176241) 2025-09-30 [email protected] Warn if embedder API calls don't return success (flutter/flutter#176184) 2025-09-30 [email protected] Roll Fuchsia Test Scripts from APSBP-sS-3FX69Ihf... to JUeFbA8y0E-_pj-bg... (flutter/flutter#176243) 2025-09-30 [email protected] Roll GN to 81b24e01 (flutter/flutter#176119) 2025-09-29 [email protected] Rename DisplayMonitor to DisplayManager on Win32 (flutter/flutter#175619) 2025-09-29 [email protected] [Android] Use headingLevel for heading accessibility property (flutter/flutter#175416) 2025-09-29 [email protected] BUILD.gn: Support LTO build on Linux (flutter/flutter#176191) 2025-09-29 [email protected] fix `assertEquals` arguments are in wrong order in `FlutterJNITest.java` (flutter/flutter#175728) 2025-09-29 [email protected] Add tests for `Project` getters (flutter/flutter#175994) 2025-09-29 [email protected] Roll Fuchsia Linux SDK from 8zjcJic_DtvB2Bo2x... to rcOl0yxJb4znJ903Y... (flutter/flutter#176215) 2025-09-29 [email protected] Clean up typos in `PlatformViewsControllerTest.java` (flutter/flutter#175725) 2025-09-29 [email protected] Migrate java 11 usage to java 17 usage for templates (flutter/flutter#176203) 2025-09-29 [email protected] User Invoke-Expression instead of call operator for nested Powershell scripts invocations (on Windows) (flutter/flutter#175941) 2025-09-29 [email protected] Update changelog as on 3.35 branch (flutter/flutter#176216) 2025-09-29 [email protected] fix typo in `Crashes.md` (flutter/flutter#175959) 2025-09-29 [email protected] Add scene plugin lifecycle events (flutter/flutter#175866) 2025-09-29 [email protected] Migrate tests and documentation to set java version to 17 (flutter/flutter#176204) 2025-09-29 [email protected] Update Engine CI to use NDK r28c (flutter/flutter#175870) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bufffun
pushed a commit
to bufffun/flutter
that referenced
this pull request
Oct 3, 2025
…r#176202) ## What's new? - 🍏 Added the concept of dialogs to the windowing API. New symbols: - `DialogWindowControllerDelegate` - `DialogWindowController` - `WindowingOwner.createDialogWindowController` - `DialogWindow` - `WindowControllerCommon` - 🥘 Introduced the `WindowControllerCommon` mixin to share common windowing functionality between controller types - I have NOT yet implemented dialogs. This pull request ONLY adds the idea to the API. Win32 implementation to follow :) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
okorohelijah
pushed a commit
to okorohelijah/flutter
that referenced
this pull request
Oct 7, 2025
…r#176202) ## What's new? - 🍏 Added the concept of dialogs to the windowing API. New symbols: - `DialogWindowControllerDelegate` - `DialogWindowController` - `WindowingOwner.createDialogWindowController` - `DialogWindow` - `WindowControllerCommon` - 🥘 Introduced the `WindowControllerCommon` mixin to share common windowing functionality between controller types - I have NOT yet implemented dialogs. This pull request ONLY adds the idea to the API. Win32 implementation to follow :) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…r#176202) ## What's new? - 🍏 Added the concept of dialogs to the windowing API. New symbols: - `DialogWindowControllerDelegate` - `DialogWindowController` - `WindowingOwner.createDialogWindowController` - `DialogWindow` - `WindowControllerCommon` - 🥘 Introduced the `WindowControllerCommon` mixin to share common windowing functionality between controller types - I have NOT yet implemented dialogs. This pull request ONLY adds the idea to the API. Win32 implementation to follow :) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
DialogWindowControllerDelegateDialogWindowControllerWindowingOwner.createDialogWindowControllerDialogWindowWindowControllerCommonWindowControllerCommonmixin to share common windowing functionality between controller typesPre-launch Checklist
///).