User Invoke-Expression instead of call operator for nested Powershell scripts invocations (on Windows) #175941
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request changes how a nested PowerShell script is called in update_engine_version.ps1, switching from the call operator (&) to Invoke-Expression to resolve an issue with modern pwsh.exe. However, the current implementation is not robust and will fail if the Flutter SDK path contains spaces. My review provides a critical comment with a code suggestion to fix this by ensuring the path is correctly quoted for Invoke-Expression, thus supporting paths with spaces.
| # engine artifacts built from CI. | ||
| } else { | ||
| $engineVersion = & "$flutterRoot/bin/internal/content_aware_hash.ps1" | ||
| $engineVersion = Invoke-Expression "$flutterRoot/bin/internal/content_aware_hash.ps1" |
There was a problem hiding this comment.
Using Invoke-Expression directly on a path string is unsafe if the path contains spaces. If $flutterRoot has a space, Invoke-Expression will misinterpret the path, causing the command to fail. The original use of the call operator (&) with a quoted path correctly handles spaces.
To ensure your fix for pwsh.exe also works for paths with spaces, you should include the call operator (&) and quotes inside the string that Invoke-Expression executes. This will ensure the path is treated as a single, complete argument.
$engineVersion = Invoke-Expression "& '$flutterRoot/bin/internal/content_aware_hash.ps1'"
|
Today we say we support Powershell 5.1 - which ships default on windows. Our testing infra I think is correctly finding a problem here. We should make sure the PR works for both environments of powershell. Invoke-Expression : The term 'C:\b\s\w\ir\x\w\rc\tmp22nzoqt0\flutter' is not recognized as the name of a cmdlet,
function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the
path is correct and try again.
At C:\b\s\w\ir\x\w\rc\tmp22nzoqt0\flutter sdk\bin\internal\update_engine_version.ps1:60 char:20
+ ... neVersion = Invoke-Expression "$flutterRoot/bin/internal/content_awar ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : ObjectNotFound: (C:\b\s\w\ir\x\w\rc\tmp22nzoqt0\flutter:String) [Invoke-Expression], Com
mandNotFoundException
+ FullyQualifiedErrorId : CommandNotFoundException,Microsoft.PowerShell.Commands.InvokeExpressionCommand |
Locally forcing powershell.exe, rather than pwsh.exe(via commenting out powershell_executable logic in
gemini-code-assist code review was very helpful as it pointed out that quoting filename is important to handle spaces in file name properly. |
|
Looks like this is now passing. |
flutter-dashboard
bot
removed
the
autosubmit
…Powershell scripts invocations (on Windows) (flutter/flutter#175941)
…Powershell scripts invocations (on Windows) (flutter/flutter#175941)
…Powershell scripts invocations (on Windows) (flutter/flutter#175941)
…Powershell scripts invocations (on Windows) (flutter/flutter#175941)
…Powershell scripts invocations (on Windows) (flutter/flutter#175941)
…Powershell scripts invocations (on Windows) (flutter/flutter#175941)
…Powershell scripts invocations (on Windows) (flutter/flutter#175941)
…Powershell scripts invocations (on Windows) (flutter/flutter#175941)
…Powershell scripts invocations (on Windows) (flutter/flutter#175941)
…10145) Manual roll requested by [email protected] flutter/flutter@96fe3b3...c9608e2 2025-09-30 [email protected] Implement framework interface for the dialog window archetype (flutter/flutter#176202) 2025-09-30 [email protected] Update flutter test to use SemanticsFlags (flutter/flutter#175987) 2025-09-30 [email protected] Set minimum supported java version to 17 (flutter/flutter#176226) 2025-09-30 [email protected] Reduce timeout for Linux web_tool_tests back to 60 (flutter/flutter#176286) 2025-09-30 [email protected] Roll Packages from 34eec78 to 287739d (9 revisions) (flutter/flutter#176284) 2025-09-30 [email protected] [web] Bump Firefox to 143.0 (flutter/flutter#176110) 2025-09-30 [email protected] Migrate to `WidgetStateBorderSide` (flutter/flutter#176164) 2025-09-30 [email protected] Enhance input decorator padding logic for character counter in text f… (flutter/flutter#175706) 2025-09-30 [email protected] Update the test package for the web engine unit test bits. (flutter/flutter#176241) 2025-09-30 [email protected] Warn if embedder API calls don't return success (flutter/flutter#176184) 2025-09-30 [email protected] Roll Fuchsia Test Scripts from APSBP-sS-3FX69Ihf... to JUeFbA8y0E-_pj-bg... (flutter/flutter#176243) 2025-09-30 [email protected] Roll GN to 81b24e01 (flutter/flutter#176119) 2025-09-29 [email protected] Rename DisplayMonitor to DisplayManager on Win32 (flutter/flutter#175619) 2025-09-29 [email protected] [Android] Use headingLevel for heading accessibility property (flutter/flutter#175416) 2025-09-29 [email protected] BUILD.gn: Support LTO build on Linux (flutter/flutter#176191) 2025-09-29 [email protected] fix `assertEquals` arguments are in wrong order in `FlutterJNITest.java` (flutter/flutter#175728) 2025-09-29 [email protected] Add tests for `Project` getters (flutter/flutter#175994) 2025-09-29 [email protected] Roll Fuchsia Linux SDK from 8zjcJic_DtvB2Bo2x... to rcOl0yxJb4znJ903Y... (flutter/flutter#176215) 2025-09-29 [email protected] Clean up typos in `PlatformViewsControllerTest.java` (flutter/flutter#175725) 2025-09-29 [email protected] Migrate java 11 usage to java 17 usage for templates (flutter/flutter#176203) 2025-09-29 [email protected] User Invoke-Expression instead of call operator for nested Powershell scripts invocations (on Windows) (flutter/flutter#175941) 2025-09-29 [email protected] Update changelog as on 3.35 branch (flutter/flutter#176216) 2025-09-29 [email protected] fix typo in `Crashes.md` (flutter/flutter#175959) 2025-09-29 [email protected] Add scene plugin lifecycle events (flutter/flutter#175866) 2025-09-29 [email protected] Migrate tests and documentation to set java version to 17 (flutter/flutter#176204) 2025-09-29 [email protected] Update Engine CI to use NDK r28c (flutter/flutter#175870) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
… scripts invocations (on Windows) (flutter#175941) With modern pwsh.exe there seems to be a problem with call operator making nested powershell script invocation. Use Invoke-Expression instead. Fixes flutter#173554
…Powershell scripts invocations (on Windows) (flutter/flutter#175941)
… scripts invocations (on Windows) (flutter#175941) With modern pwsh.exe there seems to be a problem with call operator making nested powershell script invocation. Use Invoke-Expression instead. Fixes flutter#173554
2 participants
With modern pwsh.exe there seems to be a problem with call operator making nested powershell script invocation. Use Invoke-Expression instead.
Fixes #173554