Fix RadioButton is not vocalized as unselected by VoiceOver #175926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
huycozy
force-pushed
the
fix-RadioButton-is-not-vocalized-as-unselected-by-VoiceOver-170422
branch
2 times, most recently
from
1073ed7 to
0c1a097
Compare
Member
Author
|
/gemini |
Contributor
|
Thank you for the detailed explanation and the thorough solution to address the VoiceOver vocalization issue for unselected radio buttons on iOS/macOS. I appreciate the in-depth investigation into why simpler The approach of introducing a localized This is a great example of a meticulous and well-thought-out accessibility fix. Excellent work! |
Signed-off-by: huycozy <[email protected]>
huycozy
force-pushed
the
fix-RadioButton-is-not-vocalized-as-unselected-by-VoiceOver-170422
branch
from
0c1a097 to
bfab2ac
Compare
chunhtai
reviewed
Sep 26, 2025
Contributor
There was a problem hiding this comment.
LGTM except one minor comment, @QuncCccccc do you know if we need to do anything to trigger translation once this pr landed?
Contributor
Once it's rolling into g3, the translation team will translate the new text. And when the translation is finished, we will need to back-integrate the translation to Flutter. So for now, there's nothing we need to do. |
Contributor
Do we get a notification somehow? because I saw some of the old strings are not translated yet |
Contributor
We don't get notification I think. Which old strings do you see? We can use go/flutter-l10n to check the status. Seems most of the languages have the 100% translation. |
Contributor
|
noResultsFound and searchResultsFound was added recently, but hasn't been translated yet |
Signed-off-by: huycozy <[email protected]>
chunhtai
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/175926, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
…cted-by-VoiceOver-170422
chunhtai
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2025
This was referenced Oct 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 13, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 15, 2025
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…175926) ### Issue - Fix flutter#170422 ### Description This PR proposes a fix by adding a hint to Semantics here: https://github.com/flutter/flutter/blob/b220f5a2abf53c28623514b223b20a46c69a8ca6/packages/flutter/lib/src/widgets/raw_radio.dart#L217-L222 The hint is only available on iOS &macOS platforms with a localized string for `unselected` state to prevent regression on Android, which works as expected currently and this seems to be the only solution as investigated below ⬇️ <details open> <summary>Demo the fix</summary> https://github.com/user-attachments/assets/56c1c6c9-5178-45be-a633-47145a0543d6 </details> #### Why can't we make it simpler with Semantics flags only? - I looked at [UIAccessibilityTraits](https://developer.apple.com/documentation/uikit/uiaccessibilitytraits), it seems the [selected](https://developer.apple.com/documentation/uikit/uiaccessibilitytraits/selected) property does announce `selected` state, but it does not mention or give hints for `unselected` state. - [L824-L828](https://github.com/flutter/flutter/blob/e8bef98051944f0faee9913f76d22f2d0cc91712/engine/src/flutter/shell/platform/darwin/ios/framework/Source/SemanticsObject.mm#L824-L828) in Flutter source code does mention radio button: Looks like I can try marking both toggle and check, but it's impossible, due to an assertion: [A semantics node cannot be toggled and checked at the same time](https://github.com/flutter/flutter/blob/35375e43fbae661f41dd8a6bda7454f8d55a4d54/packages/flutter/lib/src/rendering/object.dart#L4807-L4809) ➡️ Not sure which flags can trigger `unselected` state implicitly. #### How do iOS native apps work? I did test with two approaches: 1. iOS Reminders app: VoiceOver vocalizes as follows: Unchecked radio: "...Incomplete..." checked radio:"...Completed..." <details> <summary>Demo video</summary> https://github.com/user-attachments/assets/6bed5d14-ded8-47c2-9c09-7afc266898cc </details> 2. Build Radio with SwiftUI Looks like [there is no built-in widget for Radio provided by Apple](https://www.reddit.com/r/SwiftUI/comments/1gsh7zo/does_swiftui_have_a_builtin_radiobutton_in_2024/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button). [Is it really a native iOS component?](https://www.reddit.com/r/SwiftUI/comments/1gsh7zo/comment/lxea1uf/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button) Most of results I have found suggest building radio from a button with changing image source(selected/unselected, respectively), as I do in this SwiftUI code here: https://gist.github.com/huycozy/93b12c030651c4fde6fe8fceda1ba1ee. We can control what the reader vocalizes by setting traits and value for it manually. This being said, setting accessibility hint or value from Flutter side makes sense in this case. Please let me know if I am missing something. <details> <summary>Demo video</summary> https://github.com/user-attachments/assets/118c89c5-46a3-497f-8b2a-6f7c5ae8edf3 </details> ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Signed-off-by: huycozy <[email protected]> Co-authored-by: chunhtai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
This PR proposes a fix by adding a hint to Semantics here:
flutter/packages/flutter/lib/src/widgets/raw_radio.dart
Lines 217 to 222 in b220f5a
The hint is only available on iOS &macOS platforms with a localized string for
unselectedstate to prevent regression on Android, which works as expected currently and this seems to be the only solution as investigated below ⬇️Demo the fix
Flutter.ios.-.fixed.mov
Why can't we make it simpler with Semantics flags only?
selectedstate, but it does not mention or give hints forunselectedstate.➡️ Not sure which flags can trigger
unselectedstate implicitly.How do iOS native apps work?
I did test with two approaches:
VoiceOver vocalizes as follows:
Unchecked radio: "...Incomplete..."
checked radio:"...Completed..."
Demo video
iOS.Reminders.app.mov
Looks like there is no built-in widget for Radio provided by Apple. Is it really a native iOS component?
Most of results I have found suggest building radio from a button with changing image source(selected/unselected, respectively), as I do in this SwiftUI code here: https://gist.github.com/huycozy/93b12c030651c4fde6fe8fceda1ba1ee. We can control what the reader vocalizes by setting traits and value for it manually. This being said, setting accessibility hint or value from Flutter side makes sense in this case. Please let me know if I am missing something.
Demo video
iOS.SwiftUI.mov
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.