[ Tool / l10n ] Fix issue where localization generator assumed current directory was the target project #175881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t directory was the target project When running `flutter pub get` from the root of a Pub workspace, localizations are generated for each subproject. However, we were trying to write the untranslated messages file relative to the current directory, not the target project's directory. This change updates the logic for determining the output location of the untranslated messages file to include the target project root. Fixes #174205
github-actions
bot
added
the
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where the localization generator was incorrectly using the current working directory instead of the target project's directory to resolve file paths. The fix involves making the projectPathString a required, non-nullable parameter in the LocalizationsGenerator, which ensures that all paths are correctly resolved relative to the project root. The changes are well-implemented, improving code robustness by removing nullability, and include a valuable regression test. I have one minor suggestion to enhance the robustness of the new test.
packages/flutter_tools/test/general.shard/generate_localizations_test.dart
Outdated
Show resolved
Hide resolved
chingjun
approved these changes
Oct 1, 2025
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/175881, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/flutter/175881, because - The status or check suite Mac plugin_test_android_variants has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 2, 2025
…med current directory was the target project (flutter/flutter#175881)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 2, 2025
flutter/flutter@7811e89...65aca36 2025-10-02 [email protected] Roll Skia from 257c1f94afaa to 05c1f5803415 (4 revisions) (flutter/flutter#176402) 2025-10-02 [email protected] [ Widget Preview ] Fix resolution for workspace "hosted" dependencies (flutter/flutter#176358) 2025-10-02 [email protected] Roll Skia from b5d8ae8d3410 to 257c1f94afaa (6 revisions) (flutter/flutter#176389) 2025-10-02 [email protected] Delete Skia-specific performance overlay implementation (flutter/flutter#176364) 2025-10-02 [email protected] Roll Fuchsia Linux SDK from 1Ai6VL4vb_GdGnWhg... to Vnoygds8HtDUvGLCK... (flutter/flutter#176381) 2025-10-01 [email protected] [ Widget Preview ] Persist "Filter by Selected File" toggle (flutter/flutter#176289) 2025-10-01 [email protected] Roll Skia from c44a36470d07 to b5d8ae8d3410 (5 revisions) (flutter/flutter#176367) 2025-10-01 [email protected] Reapply "Update the AccessibilityPlugin::Announce method to account f… (flutter/flutter#176107) 2025-10-01 [email protected] Roll Dart SDK from 8ffec1435cf3 to 4f90a06328cb (3 revisions) (flutter/flutter#176369) 2025-10-01 [email protected] [ Tool / l10n ] Fix issue where localization generator assumed current directory was the target project (flutter/flutter#175881) 2025-10-01 [email protected] Make sure that a DateRangePickerDialog doesn't crash in 0x0 environments (flutter/flutter#173754) 2025-10-01 [email protected] Make sure that a DrawerButton doesn't crash in 0x0 environment (flutter/flutter#172948) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
okorohelijah
pushed a commit
to okorohelijah/flutter
that referenced
this pull request
Oct 7, 2025
…t directory was the target project (flutter#175881) When running `flutter pub get` from the root of a Pub workspace, localizations are generated for each subproject. However, we were trying to write the untranslated messages file relative to the current directory, not the target project's directory. This change updates the logic for determining the output location of the untranslated messages file to include the target project root. Fixes flutter#174205
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
…med current directory was the target project (flutter/flutter#175881)
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…t directory was the target project (flutter#175881) When running `flutter pub get` from the root of a Pub workspace, localizations are generated for each subproject. However, we were trying to write the untranslated messages file relative to the current directory, not the target project's directory. This change updates the logic for determining the output location of the untranslated messages file to include the target project root. Fixes flutter#174205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
flutter pub getfrom the root of a Pub workspace, localizations are generated for each subproject. However, we were trying to write the untranslated messages file relative to the current directory, not the target project's directory.This change updates the logic for determining the output location of the untranslated messages file to include the target project root.
Fixes #174205