Skip to content

Conversation

@jesswrd
Copy link
Contributor

@jesswrd jesswrd commented Sep 23, 2025

After uploading a revision of Android 36 SDK (36v3) to CIPD, I am updating Engine CI to test against 36v3.

super fun: There is a new Android header in 28rc ndk (a part of 36v3) AHARDWAREBUFFER_FORMAT_YCbCr_P210 here that did not exist in the 27 ndk version (a part of 36v2). Confirmed by downloading both 36v2 and 36v3 from CIPD and checking hardware.buffer.h.

Partially Addresses #175022

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Sep 23, 2025
@github-actions github-actions bot added the e: impeller Impeller rendering backend issues and features requests label Sep 23, 2025
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@jesswrd jesswrd changed the title Update Engine CIPD to use NDK 28rc Update Engine CIPD to use NDK r28c Sep 25, 2025
@jesswrd jesswrd added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Sep 25, 2025
@jesswrd jesswrd added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2025
@jesswrd jesswrd changed the title Update Engine CIPD to use NDK r28c Update Engine CI to use NDK r28c Sep 29, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Sep 29, 2025
Merged via the queue into flutter:master with commit 5d00bf8 Sep 29, 2025
188 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 1, 2025
…10145)

Manual roll requested by [email protected]

flutter/flutter@96fe3b3...c9608e2

2025-09-30 [email protected] Implement framework interface for the dialog window archetype (flutter/flutter#176202)
2025-09-30 [email protected] Update flutter test to use SemanticsFlags (flutter/flutter#175987)
2025-09-30 [email protected] Set minimum supported java version to 17  (flutter/flutter#176226)
2025-09-30 [email protected] Reduce timeout for Linux web_tool_tests back to 60 (flutter/flutter#176286)
2025-09-30 [email protected] Roll Packages from 34eec78 to 287739d (9 revisions) (flutter/flutter#176284)
2025-09-30 [email protected] [web] Bump Firefox to 143.0 (flutter/flutter#176110)
2025-09-30 [email protected] Migrate to `WidgetStateBorderSide` (flutter/flutter#176164)
2025-09-30 [email protected] Enhance input decorator padding logic for character counter in text f… (flutter/flutter#175706)
2025-09-30 [email protected] Update the test package for the web engine unit test bits. (flutter/flutter#176241)
2025-09-30 [email protected] Warn if embedder API calls don't return success (flutter/flutter#176184)
2025-09-30 [email protected] Roll Fuchsia Test Scripts from APSBP-sS-3FX69Ihf... to JUeFbA8y0E-_pj-bg... (flutter/flutter#176243)
2025-09-30 [email protected] Roll GN to 81b24e01 (flutter/flutter#176119)
2025-09-29 [email protected] Rename DisplayMonitor to DisplayManager on Win32 (flutter/flutter#175619)
2025-09-29 [email protected] [Android] Use headingLevel for heading accessibility property (flutter/flutter#175416)
2025-09-29 [email protected] BUILD.gn: Support LTO build on Linux (flutter/flutter#176191)
2025-09-29 [email protected] fix `assertEquals` arguments are in wrong order in `FlutterJNITest.java` (flutter/flutter#175728)
2025-09-29 [email protected] Add tests for `Project` getters  (flutter/flutter#175994)
2025-09-29 [email protected] Roll Fuchsia Linux SDK from 8zjcJic_DtvB2Bo2x... to rcOl0yxJb4znJ903Y... (flutter/flutter#176215)
2025-09-29 [email protected] Clean up typos in `PlatformViewsControllerTest.java` (flutter/flutter#175725)
2025-09-29 [email protected] Migrate java 11 usage to java 17 usage for templates (flutter/flutter#176203)
2025-09-29 [email protected] User Invoke-Expression instead of call operator for nested Powershell scripts invocations (on Windows) (flutter/flutter#175941)
2025-09-29 [email protected] Update changelog as on 3.35 branch (flutter/flutter#176216)
2025-09-29 [email protected] fix typo in `Crashes.md` (flutter/flutter#175959)
2025-09-29 [email protected] Add scene plugin lifecycle events (flutter/flutter#175866)
2025-09-29 [email protected] Migrate tests and documentation to set java version to 17 (flutter/flutter#176204)
2025-09-29 [email protected] Update Engine CI to use NDK r28c  (flutter/flutter#175870)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
okorohelijah pushed a commit to okorohelijah/flutter that referenced this pull request Oct 7, 2025
After uploading a revision of Android 36 SDK (36v3) to CIPD, I am
updating Engine CI to test against 36v3.

super fun: There is a new Android header in 28rc ndk (a part of 36v3)
`AHARDWAREBUFFER_FORMAT_YCbCr_P210`
[here](https://cs.android.com/android/platform/superproject/main/+/main:frameworks/native/libs/nativewindow/include/android/hardware_buffer.h;l=178-183?q=libs%2Fnativewindow%2Finclude%2Fandroid%2Fhardware_buffer.h)
that did not exist in the 27 ndk version (a part of 36v2). Confirmed by
downloading both 36v2 and 36v3 from CIPD and checking
`hardware.buffer.h`.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
reidbaker pushed a commit to AbdeMohlbi/flutter that referenced this pull request Dec 10, 2025
After uploading a revision of Android 36 SDK (36v3) to CIPD, I am
updating Engine CI to test against 36v3.

super fun: There is a new Android header in 28rc ndk (a part of 36v3)
`AHARDWAREBUFFER_FORMAT_YCbCr_P210`
[here](https://cs.android.com/android/platform/superproject/main/+/main:frameworks/native/libs/nativewindow/include/android/hardware_buffer.h;l=178-183?q=libs%2Fnativewindow%2Finclude%2Fandroid%2Fhardware_buffer.h)
that did not exist in the 27 ndk version (a part of 36v2). Confirmed by
downloading both 36v2 and 36v3 from CIPD and checking
`hardware.buffer.h`.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e: impeller Impeller rendering backend issues and features requests engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants