Add scene plugin lifecycle events #175866

vashworth · 2025-09-23T17:40:28Z

This PR forwards scene lifecycle events from the SceneDelegate to registered plugins.

This PR introduced 3 new public APIs:

FlutterSceneLifeCycleDelegate (protocol) - This is the protocol that plugins conform to
FlutterSceneLifeCycleProvider (protocol) - This is the protocol that a SceneDelegate can conform to instead of FlutterSceneDelegate
FlutterPluginSceneLifeCycleDelegate (interface) - This is the class object that a SceneDelegate using FlutterSceneLifeCycleProvider can use to forward scene events to

The flow of events are as followed when SceneDelegate subclasses the FlutterSceneDelegate:

FlutterSceneDelegate receives sceneDidBecomeActive event from UIKit
FlutterSceneDelegate forwards sceneDidBecomeActive to FlutterPluginSceneLifeCycleDelegate
FlutterPluginSceneLifeCycleDelegate loops through each FlutterEngine it has and forwards sceneDidBecomeActive to the engine's FlutterEnginePluginSceneLifeCycleDelegate
- FlutterEnginePluginSceneLifeCycleDelegate loops through each plugin that conforms to FlutterSceneLifeCycleDelegate it has and forwards sceneDidBecomeActive to the plugin
FlutterPluginSceneLifeCycleDelegate forwards sceneDidBecomeActive to FlutterPluginAppLifeCycleDelegate using sceneDidBecomeActiveFallback
- FlutterPluginAppLifeCycleDelegate loops through all plugins and calls applicationDidBecomeActive if the plugin does not conform to FlutterSceneLifeCycleDelegate

When using FlutterSceneLifeCycleProvider instead of FlutterSceneDelegate, scene events are manually forwarded to FlutterPluginSceneLifeCycleDelegate by the iOS developer. For example:

class SceneDelegate: UIResponder, UIWindowSceneDelegate, FlutterSceneLifeCycleProvider {

  var sceneLifeCycleDelegate: FlutterPluginSceneLifeCycleDelegate = FlutterPluginSceneLifeCycleDelegate()

  func sceneDidBecomeActive(_ scene: UIScene) {
    sceneLifeCycleDelegate.sceneDidBecomeActive(scene)
  }

Fixes #174398.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

vashworth · 2025-09-23T17:41:34Z

engine/src/flutter/shell/platform/darwin/ios/BUILD.gn

  "framework/Headers/FlutterEngineGroup.h",
  "framework/Headers/FlutterHeadlessDartRunner.h",
  "framework/Headers/FlutterPlatformViews.h",
  "framework/Headers/FlutterPlugin.h",


All changes above this point are for the integration test

stuartmorgan-g · 2025-09-24T17:33:51Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces support for UIScene lifecycle events in Flutter plugins. It adds new public APIs (FlutterSceneLifeCycleDelegate, FlutterSceneLifeCycleProvider, FlutterPluginSceneLifeCycleDelegate) to allow plugins to receive scene-specific lifecycle events. The changes include a fallback mechanism to forward application-level lifecycle events to plugins that have not yet migrated to the new scene-based APIs. The implementation is well-structured, separating concerns between scene and application lifecycle delegates. A comprehensive integration test suite is also added to verify the behavior across various migration scenarios. My review focuses on the correctness and robustness of the new event forwarding logic.

.../src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPluginAppLifeCycleDelegate.mm

stuartmorgan-g

All my comments are minor, and almost all optional, so I don't think this needs another review from me, but let me know if you want me to take another look at anything you change.

The integration testing here is really, really nice!

stuartmorgan-g · 2025-09-24T17:36:23Z

dev/devicelab/bin/tasks/module_uiscene_test_ios.dart

+  const String moduleName = 'my_module';
+  await flutter(
+    'create',
+    options: <String>['--org', 'io.flutter.devicelab', '--template=module', moduleName],


Do flutter/flutter tests still use io.flutter rather than dev.flutter? For flutter/plugins we phased out as much use of io.flutter as possible.

(Doesn't really matter, just curious.)

Yes, we do. I'll swap it. Do you know why we replaced it?

No clue; I assume it was a marketing decision. (We still have flutter.io, but it redirects to flutter.dev).

dev/devicelab/bin/tasks/module_uiscene_test_ios.dart

dev/integration_tests/ios_add2app_uiscene/flutterapp/pubspec-LifeCycleTest.yaml

.../src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPluginAppLifeCycleDelegate.mm

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterSceneLifecycle.mm

engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterSceneLifeCycle.h

LongCatIsLooong · 2025-09-23T23:41:51Z

engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterSceneLifeCycle.h

+
+/**
+ * Protocol for listener of events from the UIWindowSceneDelegate, typically a FlutterPlugin.
+ */


is FLUTTER_DARWIN_EXPORT needed here?

tbh, I don't really understand what does and doesn't need FLUTTER_DARWIN_EXPORT. My integration tests worked without it.

engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterSceneLifeCycle.h

LongCatIsLooong · 2025-09-24T18:56:29Z

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm

-  id<UIApplicationDelegate> appDelegate = [[UIApplication sharedApplication] delegate];
+- (void)addApplicationDelegate:(NSObject<FlutterPlugin>*)delegate {
+  // If the plugin conforms to FlutterSceneLifeCycleDelegate, add it to the engine.
+  if ([delegate conformsToProtocol:@protocol(FlutterSceneLifeCycleDelegate)]) {


We're expecting FlutterPlugin to conform to FlutterSceneLifeCycleDelegate, but it doesn't seem to be documented or implied in the interface (also I think even with documentation that says FlutterPlugin also needs to conform to FlutterSceneLifecycleDelegate, it will be a bit difficult to discover).

Would it be possible to add a separate method to the registrar for UISceneDelegate registration instead of reusing the one for UIAppDelegate?

I updated the doc comment for FlutterSceneLifeCycleDelegate. I also plan to write website documentation. We could definitely separate this into 2 methods. Do you think that would be better?

I'm leaning towards having a separate method for scene event registration since people don't always read docs (and the existing method is called addApplicationDelegate:).

Sounds good to me, I was on the fence about it. I added it and updated the integration test

LongCatIsLooong · 2025-09-24T20:14:38Z

engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterSceneLifeCycle.h

+/**
+ * Protocol for listener of events from the UIWindowSceneDelegate, typically a FlutterPlugin.
+ */
+@protocol FlutterSceneLifeCycleDelegate


nit: looks like we use "lifecycle" as a single word in most places? e.g.,

1: https://main-api.flutter.dev/flutter/dart-ui/AppLifecycleState.html,
2: https://api.flutter.dev/macos-embedder/category_flutter_app_delegate_07_08.html#a926aab76a90dbc4e9fba5033ac694183

The only place with this spelling I found is here: https://api.flutter.dev/ios-embedder/category_flutter_app_delegate_07_08.html#ab86a53588ed62c71760a9c5d52da18ff

It's already inconsistent but I suppose we should stick with the most prevalent spelling?

So there are already three public APIs with the 2-word spelling: FlutterApplicationLifeCycleDelegate, FlutterAppLifeCycleProvider, FlutterPluginAppLifeCycleDelegate. And the APIs added here are like the scene-equivalents to those, which is why I went this this spelling in the public headers. It also bums me out that it's different all over the place 🙈

.../src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPluginAppLifeCycleDelegate.mm

LongCatIsLooong · 2025-09-24T21:51:06Z

.../src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPluginAppLifeCycleDelegate.mm

+  // The fallback is unnecessary if the plugin conforms to FlutterSceneLifeCycleDelegate.
+  // This means that the plugin has migrated to scene lifecycle events and shouldn't require
+  // application events. However, the plugin may still have the application event implemented to
+  // maintain compatibility with un-migrated apps, which is why the fallback should be checked


It's pretty sad that now plugin authors will have to maintain two different implementations for migrated and unmigrated apps. I'm curious whether UIKit also posts a UISceneDidEnterBackgroundNotification for unmigrated apps so plugin authors don't have worry about unmigrated apps?

Hmm I tried that in a Flutter app and UIScene.willEnterForegroundNotification is posted even when the app is unmigrated. And the notification gives you the UIWindowScene:

There are scene notifications for like the basic events like active, disconnect, foreground, background, etc. However, there are not notifications for events like scene: openURLContexts, scene:continueUserActivity, etc. I personally think it's be more confusing if plugin authors only need to support both for specific ones rather than all of them.

Perhaps this is something we can come back to if we have time?

All unmigrated apps are single-scene apps (I think?) so I suppose we can get the scene from UIApplication.connectedScenes (not sure what's supposed to happen in shared extensions tho). Yeah we can come back to this later.

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterSceneLifeCycle.mm

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterSceneDelegateTest.m

engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterSceneLifecycle.h

engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterSceneLifeCycle.h

…cation version

LongCatIsLooong

LGTM in general modulo comments regarding skipping incoming URLs.

Additionally the applicationLifeCycleDelegate implementation where we have to guess to get access to the FlutterPluginAppDelegateLifeCycle instance to send the fallback events seems to be making too much assumptions but we can address this later.

LongCatIsLooong · 2025-09-26T22:08:40Z

engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterSceneLifeCycle.h

+/**
+ * Called if this has been registered for `UIWindowScene` callbacks.
+ *
+ * @return `YES` if this handles the request.


Hmm what if my plugin only handles a subset of the incoming URLContexts? I suppose the BOOL indicates any URL instead of all URLs?

Updated comment to say any. It's not clear in what situation UIKit would send more than one url, but I looked at other usages in g3 and Github and people are just using the first that succeeds.

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm

LongCatIsLooong · 2025-09-26T22:45:48Z

.../src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPluginAppLifeCycleDelegate.mm

+
+- (BOOL)sceneFallbackOpenURLContexts:(NSSet<UIOpenURLContext*>*)URLContexts {
+  for (UIOpenURLContext* context in URLContexts) {
+    return [self application:FlutterSharedApplication.application


I think we can't return early here? Or some URLs are going to be left unprocessed.

But I don't understand what we're supposed to return here, does the boolean flag mean all incoming URLs are processed or any URL?

Oops this was my bad, thank you for being such a great reviewer and catching 🙏 Yeah the bool means any url was processed.

I updated it. It now returns whichever succeeds first.

LongCatIsLooong · 2025-09-27T00:00:04Z

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterSceneLifeCycle.mm

+      consumedByPlugin = YES;
+    }
+  }
+  if (!consumedByPlugin) {


If I'm understanding correctly this is an example of converting a scene event to an app event, for unmigrated plugins. But it looks like the implementation is biased towards migrated plugins, as in if any of the migrated plugins returned YES the fallback won't happen (but all migrated plugins will get a chance to handle the event no matter what other plugins responded to the openURL request?

Basically only one plugin per engine should get to consume the event.

if any of the migrated plugins returned YES the fallback won't happen

Correct

but all migrated plugins will get a chance to handle the event no matter what other plugins responded to the openURL request

Nope, each FlutterEngine will get a change to handle the event with its plugins, but only one plugin per engine can handle the event. See below:

flutter/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterSceneLifeCycle.mm

Lines 316 to 326 in a640ddb

- (BOOL)scene:(UIScene*)scene openURLContexts:(NSSet<UIOpenURLContext*>*)URLContexts {

for (NSObject<FlutterSceneLifeCycleDelegate>* delegate in _delegates.allObjects) {

if ([delegate respondsToSelector:_cmd]) {

if ([delegate scene:scene openURLContexts:URLContexts]) {

// Only allow one plugin to process this event.

return YES;

}

}

}

return NO;

}

This is how it's handled for applications, which is what I'm mimicking:

flutter/engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPluginAppLifeCycleDelegate.mm

Lines 318 to 332 in f3ea7a1

- (BOOL)application:(UIApplication*)application

openURL:(NSURL*)url

options:(NSDictionary<UIApplicationOpenURLOptionsKey, id>*)options {

for (NSObject<FlutterApplicationLifeCycleDelegate>* delegate in _delegates) {

if (!delegate) {

continue;

}

if ([delegate respondsToSelector:_cmd]) {

if ([delegate application:application openURL:url options:options]) {

return YES;

}

}

}

return NO;

}

vashworth · 2025-09-29T17:53:16Z

Minor nits

I'll fix in my next PR so I don't have to wait for testing again lol

…10145) Manual roll requested by [email protected] flutter/flutter@96fe3b3...c9608e2 2025-09-30 [email protected] Implement framework interface for the dialog window archetype (flutter/flutter#176202) 2025-09-30 [email protected] Update flutter test to use SemanticsFlags (flutter/flutter#175987) 2025-09-30 [email protected] Set minimum supported java version to 17 (flutter/flutter#176226) 2025-09-30 [email protected] Reduce timeout for Linux web_tool_tests back to 60 (flutter/flutter#176286) 2025-09-30 [email protected] Roll Packages from 34eec78 to 287739d (9 revisions) (flutter/flutter#176284) 2025-09-30 [email protected] [web] Bump Firefox to 143.0 (flutter/flutter#176110) 2025-09-30 [email protected] Migrate to `WidgetStateBorderSide` (flutter/flutter#176164) 2025-09-30 [email protected] Enhance input decorator padding logic for character counter in text f… (flutter/flutter#175706) 2025-09-30 [email protected] Update the test package for the web engine unit test bits. (flutter/flutter#176241) 2025-09-30 [email protected] Warn if embedder API calls don't return success (flutter/flutter#176184) 2025-09-30 [email protected] Roll Fuchsia Test Scripts from APSBP-sS-3FX69Ihf... to JUeFbA8y0E-_pj-bg... (flutter/flutter#176243) 2025-09-30 [email protected] Roll GN to 81b24e01 (flutter/flutter#176119) 2025-09-29 [email protected] Rename DisplayMonitor to DisplayManager on Win32 (flutter/flutter#175619) 2025-09-29 [email protected] [Android] Use headingLevel for heading accessibility property (flutter/flutter#175416) 2025-09-29 [email protected] BUILD.gn: Support LTO build on Linux (flutter/flutter#176191) 2025-09-29 [email protected] fix `assertEquals` arguments are in wrong order in `FlutterJNITest.java` (flutter/flutter#175728) 2025-09-29 [email protected] Add tests for `Project` getters (flutter/flutter#175994) 2025-09-29 [email protected] Roll Fuchsia Linux SDK from 8zjcJic_DtvB2Bo2x... to rcOl0yxJb4znJ903Y... (flutter/flutter#176215) 2025-09-29 [email protected] Clean up typos in `PlatformViewsControllerTest.java` (flutter/flutter#175725) 2025-09-29 [email protected] Migrate java 11 usage to java 17 usage for templates (flutter/flutter#176203) 2025-09-29 [email protected] User Invoke-Expression instead of call operator for nested Powershell scripts invocations (on Windows) (flutter/flutter#175941) 2025-09-29 [email protected] Update changelog as on 3.35 branch (flutter/flutter#176216) 2025-09-29 [email protected] fix typo in `Crashes.md` (flutter/flutter#175959) 2025-09-29 [email protected] Add scene plugin lifecycle events (flutter/flutter#175866) 2025-09-29 [email protected] Migrate tests and documentation to set java version to 17 (flutter/flutter#176204) 2025-09-29 [email protected] Update Engine CI to use NDK r28c (flutter/flutter#175870) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This PR forwards scene lifecycle events from the SceneDelegate to registered plugins. This PR introduced 3 new public APIs: * `FlutterSceneLifeCycleDelegate` (protocol) - This is the protocol that plugins conform to * `FlutterSceneLifeCycleProvider` (protocol) - This is the protocol that a SceneDelegate can conform to instead of `FlutterSceneDelegate` * `FlutterPluginSceneLifeCycleDelegate` (interface) - This is the class object that a SceneDelegate using `FlutterSceneLifeCycleProvider` can use to forward scene events to The flow of events are as followed when SceneDelegate subclasses the `FlutterSceneDelegate`: * `FlutterSceneDelegate` receives `sceneDidBecomeActive` event from UIKit * `FlutterSceneDelegate` forwards `sceneDidBecomeActive` to `FlutterPluginSceneLifeCycleDelegate` * `FlutterPluginSceneLifeCycleDelegate` loops through each `FlutterEngine` it has and forwards `sceneDidBecomeActive` to the engine's `FlutterEnginePluginSceneLifeCycleDelegate` * `FlutterEnginePluginSceneLifeCycleDelegate` loops through each plugin that conforms to `FlutterSceneLifeCycleDelegate` it has and forwards `sceneDidBecomeActive` to the plugin * `FlutterPluginSceneLifeCycleDelegate` forwards `sceneDidBecomeActive` to `FlutterPluginAppLifeCycleDelegate` using `sceneDidBecomeActiveFallback` * `FlutterPluginAppLifeCycleDelegate` loops through all plugins and calls `applicationDidBecomeActive` if the plugin does not conform to `FlutterSceneLifeCycleDelegate` When using `FlutterSceneLifeCycleProvider` instead of `FlutterSceneDelegate`, scene events are manually forwarded to `FlutterPluginSceneLifeCycleDelegate` by the iOS developer. For example: ```swift class SceneDelegate: UIResponder, UIWindowSceneDelegate, FlutterSceneLifeCycleProvider { var sceneLifeCycleDelegate: FlutterPluginSceneLifeCycleDelegate = FlutterPluginSceneLifeCycleDelegate() func sceneDidBecomeActive(_ scene: UIScene) { sceneLifeCycleDelegate.sceneDidBecomeActive(scene) } ``` Fixes flutter#174398. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Add scene plugin lifecycle events

df53c1d

github-actions bot added platform-ios iOS applications specifically engine flutter/engine related. See also e: labels. team-ios Owned by iOS platform team labels Sep 23, 2025

vashworth commented Sep 23, 2025

View reviewed changes

fix formatting

75ab7e6

vashworth marked this pull request as ready for review September 23, 2025 18:43

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 23, 2025

vashworth requested a review from a team as a code owner September 23, 2025 18:43

vashworth requested review from LongCatIsLooong and stuartmorgan-g September 23, 2025 18:43

++

ae95d71

github-actions bot removed the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 24, 2025

gemini-code-assist bot reviewed Sep 24, 2025

View reviewed changes

.../src/flutter/shell/platform/darwin/ios/framework/Source/FlutterPluginAppLifeCycleDelegate.mm Show resolved Hide resolved

stuartmorgan-g approved these changes Sep 24, 2025

View reviewed changes

handle review comments

05d3ac6

vashworth commented Sep 24, 2025

View reviewed changes

engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterSceneLifeCycle.h Show resolved Hide resolved

LongCatIsLooong reviewed Sep 24, 2025

View reviewed changes

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterSceneDelegateTest.m Outdated Show resolved Hide resolved

more feedback

c1cc2a3

stuartmorgan-g approved these changes Sep 25, 2025

View reviewed changes

engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterSceneLifecycle.h Outdated Show resolved Hide resolved

engine/src/flutter/shell/platform/darwin/ios/framework/Headers/FlutterSceneLifeCycle.h Show resolved Hide resolved

LongCatIsLooong approved these changes Sep 25, 2025

View reviewed changes

vashworth added 5 commits September 25, 2025 14:05

Update comments, add separate addSceneDelegate method

429ba11

Fix capitalization in file names

a4c2028

fix captialization

737bce8

Mark new public APIs as only available 13+

50fdd86

Return a BOOL for some scene lifecycle events to be inline with appli…

a640ddb

…cation version

LongCatIsLooong reviewed Sep 27, 2025

View reviewed changes

feedback

34a9ef9

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2025

auto-submit bot added this pull request to the merge queue Sep 29, 2025

Merged via the queue into flutter:master with commit 7382e93 Sep 29, 2025
189 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2025

vashworth mentioned this pull request Sep 29, 2025

Add SwiftUI support for UIScene migration #176230

Merged

9 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2025

7382e9361 Add scene plugin lifecycle events (flutter/flutter#175866)

b7151c8

engine-flutter-autoroll mentioned this pull request Sep 30, 2025

Roll Flutter from 96fe3b3df509 to 4084680ede09 (20 revisions) flutter/packages#10138

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2025

7382e9361 Add scene plugin lifecycle events (flutter/flutter#175866)

0063da1

engine-flutter-autoroll mentioned this pull request Sep 30, 2025

Roll Flutter from 96fe3b3df509 to 3fb9ae79f555 (21 revisions) flutter/packages#10139

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2025

7382e9361 Add scene plugin lifecycle events (flutter/flutter#175866)

ed2596c

engine-flutter-autoroll mentioned this pull request Sep 30, 2025

Roll Flutter from 96fe3b3df509 to f9e14b57487e (22 revisions) flutter/packages#10142

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2025

7382e9361 Add scene plugin lifecycle events (flutter/flutter#175866)

c0a2500

engine-flutter-autoroll mentioned this pull request Sep 30, 2025

Roll Flutter from 96fe3b3df509 to 999fd04e1624 (23 revisions) flutter/packages#10143

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2025

7382e9361 Add scene plugin lifecycle events (flutter/flutter#175866)

b42f446

engine-flutter-autoroll mentioned this pull request Sep 30, 2025

Manual roll Flutter from 96fe3b3df509 to 999fd04e1624 (23 revisions) flutter/packages#10144

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2025

7382e9361 Add scene plugin lifecycle events (flutter/flutter#175866)

3de0242

engine-flutter-autoroll mentioned this pull request Sep 30, 2025

Manual roll Flutter from 96fe3b3df509 to c9608e28d01a (26 revisions) flutter/packages#10145

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2025

7382e9361 Add scene plugin lifecycle events (flutter/flutter#175866)

0ff3d4a

engine-flutter-autoroll mentioned this pull request Oct 1, 2025

Roll Flutter from 96fe3b3df509 to 72eec03e860a (43 revisions) flutter/packages#10156

Closed

vashworth mentioned this pull request Oct 1, 2025

Add deeplinking for UIScene migration #176303

Merged

9 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2025

7382e9361 Add scene plugin lifecycle events (flutter/flutter#175866)

781323b

engine-flutter-autoroll mentioned this pull request Oct 1, 2025

Roll Flutter from 96fe3b3df509 to 80496d7662ac (44 revisions) flutter/packages#10157

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2025

7382e9361 Add scene plugin lifecycle events (flutter/flutter#175866)

8331b3c

engine-flutter-autoroll mentioned this pull request Oct 1, 2025

Roll Flutter from 96fe3b3df509 to 7519cfd2515c (45 revisions) flutter/packages#10158

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

7382e9361 Add scene plugin lifecycle events (flutter/flutter#175866)

44e065d

	- (BOOL)scene:(UIScene)scene openURLContexts:(NSSet<UIOpenURLContext>*)URLContexts {
	for (NSObject<FlutterSceneLifeCycleDelegate>* delegate in _delegates.allObjects) {
	if ([delegate respondsToSelector:_cmd]) {
	if ([delegate scene:scene openURLContexts:URLContexts]) {
	// Only allow one plugin to process this event.
	return YES;
	}
	}
	}
	return NO;
	}

	- (BOOL)application:(UIApplication*)application
	openURL:(NSURL*)url
	options:(NSDictionary<UIApplicationOpenURLOptionsKey, id>*)options {
	for (NSObject<FlutterApplicationLifeCycleDelegate>* delegate in _delegates) {
	if (!delegate) {
	continue;
	}
	if ([delegate respondsToSelector:_cmd]) {
	if ([delegate application:application openURL:url options:options]) {
	return YES;
	}
	}
	}
	return NO;
	}

Add scene plugin lifecycle events #175866

Add scene plugin lifecycle events #175866

Uh oh!

Conversation

vashworth commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Sep 24, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LongCatIsLooong left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vashworth commented Sep 23, 2025 •

edited

Loading

vashworth Sep 27, 2025 •

edited

Loading

vashworth commented Sep 29, 2025 •

edited

Loading