In Gradle Flutter task, correctly replace '\ ' with ' '. #175815

mboetger · 2025-09-22T22:08:50Z

Gradle does not like paths with '\ ' in them.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

flutter-dashboard · 2025-09-22T22:08:53Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

gemini-code-assist

Code Review

This pull request addresses an issue where paths with escaped spaces were causing problems for Gradle. The change replaces escaped spaces (\ ) with regular spaces in dependency file paths. My review includes a suggestion to simplify the implementation by using a single regular expression, which makes the code more concise and robust.

packages/flutter_tools/gradle/src/main/kotlin/tasks/FlutterTaskHelper.kt

gmackall

LGTM, I think this should be easy to test by writing another test for getSourceFiles in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/gradle/src/test/kotlin/tasks/FlutterTaskHelperTest.kt#L106

Also discussed offline that this is a regression because the old groovy logic was using replaceAll which takes a regex

flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy

Line 1816 in ea121f8

def depList = matcher.collect{ it[0].replaceAll("\\\\ ", " ") }

and this was mistakenly replaced with a replacement method taking a string, so the escaping was no longer needed, which is the explanation of why this was a regression

mboetger · 2025-09-22T22:40:42Z

his was mistakenly replaced with a replacement method taking a string, so the escaping was no longer needed, which is the explanation o

Added a test. PTAL.

gmackall

LGTM!

jmagman

Can we also update an existing integration test that create, builds, and validates a project to instead be created in a directory with a space in it?

packages/flutter_tools/gradle/src/test/kotlin/tasks/FlutterTaskHelperTest.kt

auto-submit · 2025-09-23T20:43:44Z

autosubmit label was removed for flutter/flutter/175815, because - The status or check suite Windows tool_integration_tests_2_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-09-23T21:40:25Z

autosubmit label was removed for flutter/flutter/175815, because - The status or check suite Windows tool_integration_tests_2_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2025-09-24T16:41:24Z

autosubmit label was removed for flutter/flutter/175815, because - The status or check suite Windows tool_integration_tests_2_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.

gmackall

Looks like there is a test actually failing on line 33 of FlutterTaskHelperTest, presumably because the method it is testing doesn't actually handle windows slashes properly:
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/gradle/src/main/kotlin/tasks/FlutterTaskHelper.kt#L22

mboetger · 2025-09-24T19:44:02Z

y because the method it is testing doesn't

Updated to use File.separator there too.

packages/flutter_tools/gradle/src/main/kotlin/tasks/FlutterTaskHelper.kt

auto-submit · 2025-09-24T20:24:10Z

autosubmit label was removed for flutter/flutter/175815, because - The status or check suite Windows tool_integration_tests_2_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.

…lutter/flutter#175815)

Roll Flutter from 4a042046a0f1 to b1a28bc065b0 (44 revisions) flutter/flutter@4a04204...b1a28bc 2025-09-25 [email protected] web_ui: avoid crash for showPerformanceOverlay; log 'not supported' once (flutter/flutter#173518) 2025-09-25 [email protected] Ignore upcoming `experimental_member_use` warnings. (flutter/flutter#175969) 2025-09-25 [email protected] Roll Skia from 753ce2221ce7 to 55436d87e414 (16 revisions) (flutter/flutter#176004) 2025-09-25 [email protected] Add google_fonts to team-framework triage guidelines (flutter/flutter#175675) 2025-09-25 [email protected] Add tests for InputDecoration borders (M3 and theme normalization) (flutter/flutter#175838) 2025-09-24 [email protected] Update Flutter's templates to use dot shorthands (flutter/flutter#175891) 2025-09-24 [email protected] In Gradle Flutter task, correctly replace '\ ' with ' '. (flutter/flutter#175815) 2025-09-24 [email protected] Cleans up navigator pop and remove logic (flutter/flutter#175612) 2025-09-24 [email protected] Fix docs in `EditableText` (flutter/flutter#175787) 2025-09-24 [email protected] Fixes SemanticsFlags.isLink mis-translated in dart ui ffi (flutter/flutter#175812) 2025-09-24 [email protected] Update AGP/Java/Gradle comparison when using analyze --suggestions (flutter/flutter#175808) 2025-09-24 [email protected] Fix SliverMainAxisGroup SliverEnsureSemantics support (flutter/flutter#175671) 2025-09-24 [email protected] Migrate to `WidgetStateColor` (flutter/flutter#175573) 2025-09-24 [email protected] Make sure that a FlexibleSpaceBar doesn't crash in 0x0 environment (flutter/flutter#175228) 2025-09-24 [email protected] Roll Fuchsia Test Scripts from BWj3yYC74ud58QhN0... to APSBP-sS-3FX69Ihf... (flutter/flutter#175944) 2025-09-24 [email protected] Make sure that a MaterialApp doesn't crash in 0x0 environment (flutter/flutter#173090) 2025-09-24 [email protected] feat(cupertino): Add selectableDayPredicate parameter to CupertinoDatePicker for selectable day control #171332 (flutter/flutter#171334) 2025-09-24 [email protected] Refactor `FlutterInjectorTest` to use lambdas/method reference (flutter/flutter#175777) 2025-09-24 [email protected] Replace curly braces with lambdas in `KeyEventChannelTest` (flutter/flutter#175729) 2025-09-24 [email protected] [ Widget Preview ] Fix filter by file on Windows (flutter/flutter#175783) 2025-09-24 [email protected] use lambda expressions /method reference to fix linter issue in `DartMessengerTest.java` (flutter/flutter#175733) 2025-09-24 [email protected] Roll Packages from 3413b65 to 117bf63 (9 revisions) (flutter/flutter#175935) 2025-09-24 [email protected] refactor code to use method reference and lambdas in `DartMessengerTest.java` (flutter/flutter#175731) 2025-09-24 [email protected] Simplify/fix ordering of asserts in `TextInputPluginTest` (flutter/flutter#175784) 2025-09-24 [email protected] Introduce a getter for `Project` to get `gradle-wrapper.properties` directly (flutter/flutter#175485) 2025-09-24 [email protected] Change the arguments order in `assertEquals` to fix linter issues (flutter/flutter#175719) 2025-09-24 [email protected] Broken link in NavigationRail documentation (flutter/flutter#175852) 2025-09-24 [email protected] Updates to flutter web triage links (flutter/flutter#175791) 2025-09-24 [email protected] Do not present textures in FlutterMetalLayer if the drawable size changed and the texture's size does not match the new drawable size (flutter/flutter#175450) 2025-09-24 [email protected] Remove comment about trailing commas from templates (flutter/flutter#175864) 2025-09-24 [email protected] Roll Skia from 1c1b19f2ffc3 to 753ce2221ce7 (4 revisions) (flutter/flutter#175909) 2025-09-24 [email protected] Roll Skia from 3191a822cf10 to 1c1b19f2ffc3 (2 revisions) (flutter/flutter#175896) 2025-09-24 [email protected] Roll Skia from cabeab8cb22c to 3191a822cf10 (14 revisions) (flutter/flutter#175894) 2025-09-24 [email protected] Roll Dart SDK from 14b4ced3022a to 899c7340cc4c (4 revisions) (flutter/flutter#175893) 2025-09-24 [email protected] Roll `package:analyzer` forward to `8.2.0`. (flutter/flutter#175849) 2025-09-24 [email protected] Make sure that a VerticalDivider doesn't crash at 0x0 environment (flutter/flutter#174761) 2025-09-24 [email protected] Make sure that Drawer & DrawerHeader don't crash in 0x0 environment (flutter/flutter#174772) 2025-09-24 [email protected] Add an assertion for the relationship between `Visibility.maintainState` and `Visibility.maintainFocusability` (flutter/flutter#175552) 2025-09-24 [email protected] fix: remove final class modifier on MenuController (flutter/flutter#174490) 2025-09-24 [email protected] fix: cupertino sheet broken example with programatic pop (flutter/flutter#175709) 2025-09-24 [email protected] [web] Fix assertion thrown when hot restarting during animation (flutter/flutter#175856) 2025-09-24 [email protected] Add non uniform TableBorder (flutter/flutter#175773) 2025-09-23 [email protected] fix small typo in test docs (flutter/flutter#175776) 2025-09-23 [email protected] Use `assertNull` to simplify code (flutter/flutter#175720) If this roll has caused a breakage, revert this CL and stop the roller ...

…lutter/flutter#175815)

) Gradle does not like paths with '\ ' in them. Fixes: flutter#174043 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing.

mboetger requested a review from a team as a code owner September 22, 2025 22:08

github-actions bot added platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Sep 22, 2025

gemini-code-assist bot reviewed Sep 22, 2025

View reviewed changes

packages/flutter_tools/gradle/src/main/kotlin/tasks/FlutterTaskHelper.kt Outdated Show resolved Hide resolved

gmackall approved these changes Sep 22, 2025

View reviewed changes

Replace '\ ' with ' '

46f68fd

mboetger force-pushed the space-174043 branch from 7c8ab74 to 46f68fd Compare September 22, 2025 22:34

'Add tests'

57a798e

Merge branch 'master' into space-174043

7d06324

gmackall approved these changes Sep 22, 2025

View reviewed changes

mboetger changed the title ~~Replace '\ ' with ' '~~ In Gradle Flutter task, correctly replace '\ ' with ' '. Sep 22, 2025

Merge branch 'master' into space-174043

f864ec8

mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 22, 2025

jmagman reviewed Sep 22, 2025

View reviewed changes

mboetger removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 22, 2025

ash2moon reviewed Sep 23, 2025

View reviewed changes

packages/flutter_tools/gradle/src/test/kotlin/tasks/FlutterTaskHelperTest.kt Outdated Show resolved Hide resolved

reidbaker reviewed Sep 23, 2025

View reviewed changes

packages/flutter_tools/gradle/src/test/kotlin/tasks/FlutterTaskHelperTest.kt Outdated Show resolved Hide resolved

reidbaker approved these changes Sep 23, 2025

View reviewed changes

mboetger and others added 4 commits September 23, 2025 09:54

Review feedback and formatting

34071ec

Use File.separator

ebebd95

Updating integration test with a space

1a9233b

Merge branch 'master' into space-174043

f10b570

mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2025

gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2025

mboetger added 2 commits September 23, 2025 15:21

Merge branch 'master' into space-174043

3871213

Merge branch 'master' into space-174043

238a34f

mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2025

gmackall reviewed Sep 24, 2025

View reviewed changes

Update FlutterTaskHelper to use File.separator

788e149

mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2025

mboetger commented Sep 24, 2025

View reviewed changes

packages/flutter_tools/gradle/src/main/kotlin/tasks/FlutterTaskHelper.kt Show resolved Hide resolved

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2025

mboetger and others added 2 commits September 24, 2025 14:41

one last file separator

014f40f

Merge branch 'master' into space-174043

773ac5b

mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2025

auto-submit bot added this pull request to the merge queue Sep 24, 2025

Merged via the queue into flutter:master with commit 2d5c26c Sep 25, 2025
158 of 159 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 25, 2025

engine-flutter-autoroll mentioned this pull request Sep 25, 2025

Roll Flutter from 4a042046a0f1 to 57b7c46d0120 (43 revisions) flutter/packages#10076

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2025

2d5c26c0d In Gradle Flutter task, correctly replace '\ ' with ' '. (f…

ca77875

…lutter/flutter#175815)

engine-flutter-autoroll mentioned this pull request Sep 25, 2025

Roll Flutter from 4a042046a0f1 to b1a28bc065b0 (44 revisions) flutter/packages#10077

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2025

2d5c26c0d In Gradle Flutter task, correctly replace '\ ' with ' '. (f…

f02ee93

…lutter/flutter#175815)

chinmaygarde mentioned this pull request Sep 29, 2025

Android debug_compile_after_edit millseconds regressed by around 33%. #176228

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

2d5c26c0d In Gradle Flutter task, correctly replace '\ ' with ' '. (f…

f010b89

…lutter/flutter#175815)

In Gradle Flutter task, correctly replace '\ ' with ' '. #175815

In Gradle Flutter task, correctly replace '\ ' with ' '. #175815

Uh oh!

Conversation

mboetger commented Sep 22, 2025

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Sep 22, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gmackall left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mboetger commented Sep 22, 2025

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

auto-submit bot commented Sep 23, 2025

Uh oh!

auto-submit bot commented Sep 23, 2025

Uh oh!

auto-submit bot commented Sep 24, 2025

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

mboetger commented Sep 24, 2025

Uh oh!

Uh oh!

auto-submit bot commented Sep 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gmackall left a comment •

edited

Loading