[ Tool ] Don't delete .dart_tool/widget_preview_scaffold during flutter clean
#175664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utter clean` Fixes #175058
github-actions
bot
added
the
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the flutter clean command to prevent it from deleting the .dart_tool/widget_preview_scaffold directory, which is a sensible change to avoid crashing the widget previewer. The implementation is sound, and the tests have been refactored to accommodate this new behavior. However, I found a small but important issue in one of the new tests where it doesn't correctly verify the new functionality due to a likely copy-paste error.
packages/flutter_tools/test/commands.shard/hermetic/clean_test.dart
Outdated
Show resolved
Hide resolved
….dart Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
vashworth
approved these changes
Oct 9, 2025
Contributor
vashworth
left a comment
vashworth
left a comment
There was a problem hiding this comment.
So sorry I missed this 🤦♀️ LGTM!
flutter-dashboard
bot
removed
the
autosubmit
bkonyi
added
cp: beta
flutteractionsbot
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Nov 12, 2025
…utter clean` (flutter#175664) Fixes flutter#175058 --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
flutteractionsbot
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Nov 12, 2025
…utter clean` (flutter#175664) Fixes flutter#175058 --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
…during `flutter clean` (flutter/flutter#175664)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
…during `flutter clean` (flutter/flutter#175664)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
…during `flutter clean` (flutter/flutter#175664)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 13, 2025
…during `flutter clean` (flutter/flutter#175664)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
…during `flutter clean` (flutter/flutter#175664)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
…during `flutter clean` (flutter/flutter#175664)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
…during `flutter clean` (flutter/flutter#175664)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 14, 2025
…during `flutter clean` (flutter/flutter#175664)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2025
…during `flutter clean` (flutter/flutter#175664)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2025
…during `flutter clean` (flutter/flutter#175664)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2025
…during `flutter clean` (flutter/flutter#175664)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2025
…during `flutter clean` (flutter/flutter#175664)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2025
…during `flutter clean` (flutter/flutter#175664)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
…during `flutter clean` (flutter/flutter#175664)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
…during `flutter clean` (flutter/flutter#175664)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
…during `flutter clean` (flutter/flutter#175664)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
…during `flutter clean` (flutter/flutter#175664)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
…during `flutter clean` (flutter/flutter#175664)
Contributor
Author
|
Reason for revert: deemed not an acceptable fix. |
Contributor
|
Time to revert pull request flutter/flutter/175664 has elapsed. |
auto-submit
bot
removed
the
revert
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 17, 2025
…during `flutter clean` (flutter/flutter#175664)
IvoneDjaja
pushed a commit
to IvoneDjaja/flutter
that referenced
this pull request
Nov 22, 2025
…utter clean` (flutter#175664) Fixes flutter#175058 --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
IvoneDjaja
pushed a commit
to IvoneDjaja/flutter
that referenced
this pull request
Nov 22, 2025
…ring `flutter clean` (flutter#175664)" (flutter#178672) This reverts commit e983e4b.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
…utter clean` (flutter#175664) Fixes flutter#175058 --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
…ring `flutter clean` (flutter#175664)" (flutter#178672) This reverts commit e983e4b.
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…utter clean` (flutter#175664) Fixes flutter#175058 --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…ring `flutter clean` (flutter#175664)" (flutter#178672) This reverts commit e983e4b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175058