Skip to content

Upgrade command shouldn’t validate project, fixes #1745 - #1756

Merged
collinjackson merged 1 commit into
flutter:masterfrom
collinjackson:upgrade_anywhere
Feb 10, 2016
Merged

collinjackson merged 1 commit into
flutter:masterfrom
collinjackson:upgrade_anywhere

Conversation

@collinjackson

Copy link
Copy Markdown
Contributor

No description provided.

@collinjackson collinjackson changed the title Upgrade command shouldn’t require being in the project root, fixes #1745 Upgrade command shouldn’t validate project, fixes #1745 Feb 10, 2016
@devoncarew

Copy link
Copy Markdown
Contributor

@collinjackson, this will remove the engine check, but also the project directory check. The upgrade command runs pub upgrade; that'll fail if its not run from a dir w/ a pubspec. Can you check that the error from pub upgrade makes sense for flutter. lgtm in that case :)

@collinjackson

Copy link
Copy Markdown
Contributor Author

The error you get if you're in the wrong directory is

Could not find a file named "pubspec.yaml" in "<current directory>".

This seems pretty reasonable to me.

collinjackson added a commit that referenced this pull request Feb 10, 2016
Upgrade command shouldn’t validate project, fixes #1745
@collinjackson
collinjackson merged commit 96405fb into flutter:master Feb 10, 2016
@collinjackson
collinjackson deleted the upgrade_anywhere branch February 10, 2016 18:48
TahaTesser pushed a commit to NevercodeHQ/flutter that referenced this pull request Aug 13, 2020
…lt in incorrect thread (flutter#1756)

* [firebase_messaging] fix crash when calling func deleteInstanceID (flutter#1756)
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants