Fix PopupMenu does not update when PopupMenuTheme in Theme changes. #175513

ksokolovskyi · 2025-09-17T12:44:28Z

Description

Fixes PopupMenu does not update when PopupMenuTheme in Theme changes

Code sample

import 'package:flutter/material.dart';

void main() => runApp(const App());

class App extends StatelessWidget {
  const App({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        colorScheme: const ColorScheme.light(),
        popupMenuTheme: PopupMenuThemeData(
          elevation: 10,
          color: Colors.red,
          shadowColor: Colors.black,
          surfaceTintColor: Colors.white,
          shape: RoundedRectangleBorder(
            borderRadius: BorderRadius.circular(10),
          ),
          menuPadding: EdgeInsets.all(10),
        ),
      ),
      darkTheme: ThemeData(
        colorScheme: const ColorScheme.dark(),
        popupMenuTheme: PopupMenuThemeData(
          elevation: 20,
          color: Colors.blue,
          shadowColor: Colors.white,
          surfaceTintColor: Colors.black,
          shape: RoundedRectangleBorder(
            borderRadius: BorderRadius.circular(20),
          ),
          menuPadding: EdgeInsets.all(20),
        ),
      ),
      home: const HomePage(),
    );
  }
}

class HomePage extends StatelessWidget {
  const HomePage({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Hello Flutter'),
        actions: [
          PopupMenuButton<int>(
            itemBuilder: (context) => <PopupMenuEntry<int>>[
              const PopupMenuItem<int>(value: 1, child: Text('Item 1')),
              const PopupMenuItem<int>(value: 2, child: Text('Item 2')),
              const PopupMenuItem<int>(value: 3, child: Text('Item 3')),
            ],
          )
        ],
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: const [Text('Nothing here')],
        ),
      ),
    );
  }
}

BEFORE	AFTER
before.mov	after.mov

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

gemini-code-assist

Code Review

This pull request effectively addresses the issue where PopupMenu would not update its theme when the PopupMenuTheme in the Theme changes. The fix correctly removes the cached theme properties from PopupMenuButtonState and delegates the theme resolution to the showMenu implementation, which properly handles dynamic theme updates. The newly added regression test is comprehensive and accurately verifies that the menu's visual properties update correctly after a theme change. The changes are clean, well-targeted, and improve the framework's consistency.

QuncCccccc · 2025-10-06T18:56:43Z

packages/flutter/lib/src/material/popup_menu.dart

  void showButtonMenu() {
    // Ensure cached render objects are initialized
    _updateCachedObjects();
-    final PopupMenuThemeData popupMenuTheme = _popupMenuTheme;


If we remove the use of _popupMenuTheme here, do we still need it at all? Can we just remove this property?

Hi, thanks a lot for taking a look at this PR!
Unfortunately, no, as it is used in the _positionBuilder method to fix a possible crash. Some details can be found here: #171970.

dkwingsmt

LGTM. Thank you!

QuncCccccc

LGTM!

ksokolovskyi · 2025-10-08T08:29:53Z

Thanks a lot for your review!

…changes. (flutter/flutter#175513)

dkwingsmt · 2025-10-08T17:04:40Z

Thank you for your contribution! :)

…changes. (flutter/flutter#175513)

Roll Flutter from 908012d58baa to e11e2c11288b (39 revisions) flutter/flutter@908012d...e11e2c1 2025-10-08 [email protected] Configure FfiNative resolver on dart:io (flutter/flutter#176621) 2025-10-08 [email protected] Marks Linux_pixel_7pro service_extensions_test to be unflaky (flutter/flutter#176700) 2025-10-08 [email protected] Keyboard Animation Fix (flutter/flutter#176418) 2025-10-08 [email protected] Feat: Add carousel view builder (flutter/flutter#172837) 2025-10-08 [email protected] Roll Skia from d10a0d877ff4 to ea7cdbc6b986 (15 revisions) (flutter/flutter#176686) 2025-10-08 [email protected] Roll Fuchsia Linux SDK from jJr3my9C6TwYWPygi... to xrIAL91ngrd-wNr9S... (flutter/flutter#176682) 2025-10-08 [email protected] Fix InputDecoration helper/error padding is not compliant (flutter/flutter#176353) 2025-10-08 [email protected] Fix PopupMenu does not update when PopupMenuTheme in Theme changes. (flutter/flutter#175513) 2025-10-07 [email protected] Roll Dart SDK to 3.10.0-290.1.beta (flutter/flutter#176629) 2025-10-07 [email protected] [ Tool ] Output `app.dtd` and `app.devTools` in machine mode (flutter/flutter#176655) 2025-10-07 [email protected] Rename UIScene integration test projects and fix Xcode compatibility (flutter/flutter#176635) 2025-10-07 [email protected] Selecting an implementation widget with the on-device inspector opens the code location for the nearest project widget (flutter/flutter#176530) 2025-10-07 [email protected] Migrate to `WidgetStateInputBorder` (flutter/flutter#176386) 2025-10-07 [email protected] Make it clear that you need to install clangd in VSCode intellisense c++ config (flutter/flutter#176609) 2025-10-07 [email protected] Bump the customer tests to pick up an update to Zulip's tests. (flutter/flutter#176463) 2025-10-07 [email protected] Roll Packages from d3ef88b to 8ca6416 (2 revisions) (flutter/flutter#176633) 2025-10-07 [email protected] Add fallback for 'scene:willConnectToSession:options' (flutter/flutter#176580) 2025-10-07 [email protected] Roll Skia from d09786dfb854 to d10a0d877ff4 (11 revisions) (flutter/flutter#176616) 2025-10-07 [email protected] [ Widget Preview ] Rework UI and theming (flutter/flutter#176581) 2025-10-07 [email protected] Handle FlutterEngine registration when embedded in Multi-Scene apps (flutter/flutter#176490) 2025-10-07 [email protected] Fix code style in Linux embedder template (flutter/flutter#176256) 2025-10-07 [email protected] Add tooling to migrate to UIScene (flutter/flutter#176427) 2025-10-06 [email protected] Bump customer tests.version to 986c4326b4e4bb4e37bc963c2cc2aaa10b943859 (flutter/flutter#176594) 2025-10-06 [email protected] Fix typo in pages.dart (flutter/flutter#176438) 2025-10-06 [email protected] Fix: Update anchorRect for overlayBuilder when anchor moves (flutter/flutter#169814) 2025-10-06 [email protected] Roll Fuchsia Linux SDK from Zm6K_3gP3VCaMy9rH... to jJr3my9C6TwYWPygi... (flutter/flutter#176591) 2025-10-06 [email protected] Fix deprecated configureStatusBarForFullscreenFlutterExperience for Android 15+ (flutter/flutter#175501) 2025-10-06 [email protected] updates docs for flutter engine footprint (flutter/flutter#176217) 2025-10-06 [email protected] [ Widget Preview ] Fix `WidgetInspectorService` override (flutter/flutter#176550) 2025-10-06 [email protected] Fix NavigatorBar lacks visual feedback (flutter/flutter#175182) 2025-10-06 [email protected] Roll Packages from e401aeb to d3ef88b (4 revisions) (flutter/flutter#176582) 2025-10-06 [email protected] Roll Dart SDK from 898380a41c90 to 6b0193498f09 (2 revisions) (flutter/flutter#176576) 2025-10-06 [email protected] Roll Skia from bc7cf194f4ee to d09786dfb854 (1 revision) (flutter/flutter#176577) 2025-10-06 [email protected] Roll vulkan-deps to a9e2ca3b (flutter/flutter#176322) 2025-10-06 [email protected] Add an AppDelegate callback for implicit FlutterEngines (flutter/flutter#176240) 2025-10-06 [email protected] Roll Skia from 45191c22b15c to bc7cf194f4ee (2 revisions) (flutter/flutter#176572) 2025-10-06 [email protected] [ Widget Preview ] Fix type error when retrieving flags from persistent preferences (flutter/flutter#176546) 2025-10-06 [email protected] Roll Skia from 1fd0ca1f2120 to 45191c22b15c (3 revisions) (flutter/flutter#176556) 2025-10-05 [email protected] Roll Dart SDK from 016a8c0045fd to 898380a41c90 (1 revision) (flutter/flutter#176549) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. ...

…changes. (flutter/flutter#175513)

@OverRide

…lutter#175513) Fixes flutter#43824 ### Description - Fixes `PopupMenu` does not update when `PopupMenuTheme` in `Theme` changes <details closed><summary>Code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const App()); class App extends StatelessWidget { const App({Key? key}) : super(key: key); @OverRide Widget build(BuildContext context) { return MaterialApp( title: 'Flutter Demo', debugShowCheckedModeBanner: false, theme: ThemeData( colorScheme: const ColorScheme.light(), popupMenuTheme: PopupMenuThemeData( elevation: 10, color: Colors.red, shadowColor: Colors.black, surfaceTintColor: Colors.white, shape: RoundedRectangleBorder( borderRadius: BorderRadius.circular(10), ), menuPadding: EdgeInsets.all(10), ), ), darkTheme: ThemeData( colorScheme: const ColorScheme.dark(), popupMenuTheme: PopupMenuThemeData( elevation: 20, color: Colors.blue, shadowColor: Colors.white, surfaceTintColor: Colors.black, shape: RoundedRectangleBorder( borderRadius: BorderRadius.circular(20), ), menuPadding: EdgeInsets.all(20), ), ), home: const HomePage(), ); } } class HomePage extends StatelessWidget { const HomePage({Key? key}) : super(key: key); @OverRide Widget build(BuildContext context) { return Scaffold( appBar: AppBar( title: const Text('Hello Flutter'), actions: [ PopupMenuButton<int>( itemBuilder: (context) => <PopupMenuEntry<int>>[ const PopupMenuItem<int>(value: 1, child: Text('Item 1')), const PopupMenuItem<int>(value: 2, child: Text('Item 2')), const PopupMenuItem<int>(value: 3, child: Text('Item 3')), ], ) ], ), body: Center( child: Column( mainAxisAlignment: MainAxisAlignment.center, children: const [Text('Nothing here')], ), ), ); } } ``` </details> | BEFORE | AFTER | | - | - | | <video alt="before" src="https://github.com/user-attachments/assets/cb8450fe-9426-481f-bff8-2d690486a36a" /> | <video alt="after" src="https://github.com/user-attachments/assets/86bbfb46-8b9c-4ad0-b45e-8733861123ad" /> | ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Fix PopupMenu does not update when PopupMenuTheme in Theme changes.

3abe813

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 17, 2025

gemini-code-assist bot reviewed Sep 17, 2025

View reviewed changes

dkwingsmt requested review from QuncCccccc and dkwingsmt September 17, 2025 18:40

ksokolovskyi added 3 commits September 29, 2025 08:09

Merge branch 'master' into fix-popup-menu-theme-updates

673316c

Merge branch 'master' into fix-popup-menu-theme-updates

2418648

Merge branch 'master' into fix-popup-menu-theme-updates

6e1ab89

QuncCccccc reviewed Oct 6, 2025

View reviewed changes

dkwingsmt approved these changes Oct 7, 2025

View reviewed changes

ksokolovskyi requested a review from QuncCccccc October 7, 2025 11:20

QuncCccccc approved these changes Oct 8, 2025

View reviewed changes

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2025

auto-submit bot added this pull request to the merge queue Oct 8, 2025

Merged via the queue into flutter:master with commit 1cee136 Oct 8, 2025
78 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2025

engine-flutter-autoroll mentioned this pull request Oct 8, 2025

Roll Flutter from 908012d58baa to 7100df24f611 (36 revisions) flutter/packages#10189

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2025

1cee13682 Fix PopupMenu does not update when PopupMenuTheme in Theme …

072d472

…changes. (flutter/flutter#175513)

engine-flutter-autoroll mentioned this pull request Oct 8, 2025

Roll Flutter from 908012d58baa to 3379c7f0654b (37 revisions) flutter/packages#10190

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2025

1cee13682 Fix PopupMenu does not update when PopupMenuTheme in Theme …

b750c1f

…changes. (flutter/flutter#175513)

engine-flutter-autoroll mentioned this pull request Oct 8, 2025

Roll Flutter from 908012d58baa to 44c77df80a87 (38 revisions) flutter/packages#10191

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2025

1cee13682 Fix PopupMenu does not update when PopupMenuTheme in Theme …

056f73a

…changes. (flutter/flutter#175513)

engine-flutter-autoroll mentioned this pull request Oct 8, 2025

Roll Flutter from 908012d58baa to e11e2c11288b (39 revisions) flutter/packages#10192

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2025

1cee13682 Fix PopupMenu does not update when PopupMenuTheme in Theme …

d296104

…changes. (flutter/flutter#175513)

engine-flutter-autoroll mentioned this pull request Oct 8, 2025

Roll Flutter from 908012d58baa to c56e52be0710 (40 revisions) flutter/packages#10194

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2025

1cee13682 Fix PopupMenu does not update when PopupMenuTheme in Theme …

bc2f844

…changes. (flutter/flutter#175513)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

1cee13682 Fix PopupMenu does not update when PopupMenuTheme in Theme …

8470fff

…changes. (flutter/flutter#175513)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix PopupMenu does not update when PopupMenuTheme in Theme changes. #175513

Fix PopupMenu does not update when PopupMenuTheme in Theme changes. #175513

Uh oh!

ksokolovskyi commented Sep 17, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

QuncCccccc Oct 6, 2025

Uh oh!

ksokolovskyi Oct 6, 2025

Uh oh!

dkwingsmt left a comment

Uh oh!

QuncCccccc left a comment

Uh oh!

Uh oh!

ksokolovskyi commented Oct 8, 2025

Uh oh!

dkwingsmt commented Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix PopupMenu does not update when PopupMenuTheme in Theme changes. #175513

Fix PopupMenu does not update when PopupMenuTheme in Theme changes. #175513

Uh oh!

Conversation

ksokolovskyi commented Sep 17, 2025

Description

Pre-launch Checklist

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

QuncCccccc Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

ksokolovskyi Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ksokolovskyi commented Oct 8, 2025

Uh oh!

dkwingsmt commented Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants