Skip to content

Conversation

@chinmaygarde
Copy link
Member

That readme contained outdated instructions.

That readme contained outdated instructions.
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Sep 15, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request consolidates documentation by moving the content from engine/src/flutter/README.md into engine/src/README.md and deleting the former. This updates the main engine README with more relevant information, replacing outdated instructions. My review identifies a couple of broken relative links in the updated README that resulted from the file move.

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 15, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Sep 15, 2025
Merged via the queue into master with commit 324c0ee Sep 15, 2025
191 of 192 checks passed
@auto-submit auto-submit bot deleted the readmes branch September 15, 2025 23:37
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 16, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 16, 2025
flutter/flutter@29a238d...8d0b31d

2025-09-16 [email protected] Roll Packages from fcd5f68 to 0255ac9 (2 revisions) (flutter/flutter#175427)
2025-09-16 [email protected] Adds a11y section locale support for iOS (flutter/flutter#175005)
2025-09-16 [email protected] Roll Skia from 4e9c86d4a6d9 to 7d160bbf9403 (3 revisions) (flutter/flutter#175404)
2025-09-16 [email protected] [native_assets] Find more `CCompilerConfig` on Linux (flutter/flutter#175323)
2025-09-16 [email protected] Roll Dart SDK from 50e61e5bff51 to 700de52f29a9 (3 revisions) (flutter/flutter#175395)
2025-09-16 [email protected] Fix default overlay color in `TabBar` (flutter/flutter#175270)
2025-09-16 [email protected] Migrate to widget state (flutter/flutter#175242)
2025-09-16 [email protected] Roll Skia from 01b0ede33ae9 to 4e9c86d4a6d9 (1 revision) (flutter/flutter#175387)
2025-09-15 [email protected] Merge the engine README into the README of the old buildroot. (flutter/flutter#175384)
2025-09-15 [email protected] Marks Mac_ios microbenchmarks_ios to be unflaky (flutter/flutter#171146)
2025-09-15 [email protected] Deprecate Objective-C plugin template (flutter/flutter#174003)
2025-09-15 [email protected] Add a gn --ccache argument (flutter/flutter#174621)
2025-09-15 [email protected] Update `build.gradle` to remove deprecation warning in `flutter\engine\src\flutter\shell\platform\android` (flutter/flutter#175305)
2025-09-15 [email protected] Show cursor after swipe only if TextField has focus (flutter/flutter#175044)
2025-09-15 [email protected] Roll Skia from f950263bb3d4 to 01b0ede33ae9 (7 revisions) (flutter/flutter#175373)
2025-09-15 [email protected] Update Chromium sysroot to pick up RISC-V support. (flutter/flutter#173671)
2025-09-15 [email protected] Set Gemini Code Assist `include_drafts` to false (flutter/flutter#175098)
2025-09-15 [email protected] Roll Packages from 15e7e89 to fcd5f68 (3 revisions) (flutter/flutter#175366)
2025-09-15 [email protected] Remove 'v' Open DevTools from help on web in profile/release mode (flutter/flutter#172829)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
dixita0607 pushed a commit to dixita0607/flutter that referenced this pull request Sep 17, 2025
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
Jaineel-Mamtora pushed a commit to Jaineel-Mamtora/flutter_forked that referenced this pull request Sep 24, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants