Make sure that an IconButton doesn't crash in 0x0 environment #175372
Conversation
github-actions
bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a regression test to ensure that an IconButton does not crash when it has a zero size. The test case correctly reproduces the scenario using a SizedBox.shrink().
However, the pull request appears to be incomplete as it's missing the actual fix for the crash. Without the fix, this new test is expected to fail. Please add the necessary code changes to resolve the issue this test is covering.
Additionally, the pull request description is missing the Pre-launch Checklist as required by the repository's style guide (lines 13-15). Please update the description to include it.
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
Checklist:
- The test is in the correct file
- The test name goes “does not crash at zero area”
- The target widget is wrapped by
Center(or is fullscreen) - The target widget does not have an overlay, or the overlay is tested
- The target widget is expected to have a size of exactly
Size.zero
dkwingsmt
added
the
autosubmit
|
autosubmit label was removed for flutter/flutter/175372, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
dkwingsmt
force-pushed
the
handle#6537-IconButton
branch
from
15f80d1 to
d237e50
Compare
dkwingsmt
added
the
autosubmit
|
autosubmit label was removed for flutter/flutter/175372, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
dkwingsmt
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/175372, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
dkwingsmt
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/175372, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
dkwingsmt
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/175372, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
dkwingsmt
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
…r#175372) This is my attempt to handle flutter#6537 for the IconButton widget. Co-authored-by: Tong Mu <[email protected]>
3 participants
This is my attempt to handle #6537 for the IconButton widget.