Document Form.onChange precedence over DropdownButtonFormField.onChange #175249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds documentation to DropdownButtonFormField.onChanged to clarify its execution order relative to Form.onChanged. The added documentation is accurate and helpful. I've suggested a minor wording improvement to enhance clarity.
Comment on lines
1890
to
1893
| /// | ||
| /// This callback is called after the [Form.onChanged] callback. | ||
| /// [Form.onChanged] callback can query the field updated value using | ||
| /// [FormFieldState.value]. |
Contributor
There was a problem hiding this comment.
Thanks for adding this clarification. The wording could be slightly improved for better clarity and to be more explicit about which Form is being referred to.
///
/// This callback is invoked after the parent [Form]'s [Form.onChanged] callback.
/// The field's updated value is available in the [Form.onChanged] callback
/// via [FormFieldState.value].
bleroux
force-pushed
the
document_form_onChanged_precedence
branch
from
90f86ab to
93d8350
Compare
ksokolovskyi
approved these changes
Sep 12, 2025
Contributor
ksokolovskyi
left a comment
ksokolovskyi
left a comment
There was a problem hiding this comment.
LGTM, thanks for the clarification!
ksokolovskyi
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 12, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 12, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 12, 2025
flutter/flutter@5a6a1bf...f331a55 2025-09-12 [email protected] Roll Dart SDK from a4075f2f670f to 11dedad2d062 (2 revisions) (flutter/flutter#175268) 2025-09-12 [email protected] Roll Packages from 5db2635 to 15e7e89 (2 revisions) (flutter/flutter#175266) 2025-09-12 [email protected] Document Form.onChange precedence over DropdownButtonFormField.onChange (flutter/flutter#175249) 2025-09-12 [email protected] Roll Fuchsia Linux SDK from 1pTB3J5rn4YYugylf... to b1AYfAFOnvBMHSsYL... (flutter/flutter#175250) 2025-09-12 [email protected] Roll Dart SDK from 7acebac57248 to a4075f2f670f (1 revision) (flutter/flutter#175245) 2025-09-11 [email protected] Roll Dart SDK from f7d6a4732ab0 to 7acebac57248 (2 revisions) (flutter/flutter#175239) 2025-09-11 [email protected] Marks Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary to be flaky (flutter/flutter#175174) 2025-09-11 [email protected] update deps to point to the new SOT repo for package:coverage (flutter/flutter#175234) 2025-09-11 [email protected] [web] Fix image and color filters equality in SkWASM. (flutter/flutter#175230) 2025-09-11 [email protected] Roll Packages from 03598e7 to 5db2635 (1 revision) (flutter/flutter#175232) 2025-09-11 [email protected] Migrate to widget state (flutter/flutter#174746) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
dixita0607
pushed a commit
to dixita0607/flutter
that referenced
this pull request
Sep 17, 2025
…ge (flutter#175249) ## Description This PR adds some documentation to `DropdownButtonFormField.onChanged` to clarify the precedence order related to `Form.onChanged`. ## Related Issue Fixes [DropdownButtonFormField changes not absorbing Form onChanged Function](flutter#86336) ## Tests Documentation only
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
…ge (flutter#175249) ## Description This PR adds some documentation to `DropdownButtonFormField.onChanged` to clarify the precedence order related to `Form.onChanged`. ## Related Issue Fixes [DropdownButtonFormField changes not absorbing Form onChanged Function](flutter#86336) ## Tests Documentation only
Jaineel-Mamtora
pushed a commit
to Jaineel-Mamtora/flutter_forked
that referenced
this pull request
Sep 24, 2025
…ge (flutter#175249) ## Description This PR adds some documentation to `DropdownButtonFormField.onChanged` to clarify the precedence order related to `Form.onChanged`. ## Related Issue Fixes [DropdownButtonFormField changes not absorbing Form onChanged Function](flutter#86336) ## Tests Documentation only
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
…ge (flutter#175249) ## Description This PR adds some documentation to `DropdownButtonFormField.onChanged` to clarify the precedence order related to `Form.onChanged`. ## Related Issue Fixes [DropdownButtonFormField changes not absorbing Form onChanged Function](flutter#86336) ## Tests Documentation only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some documentation to
DropdownButtonFormField.onChangedto clarify the precedence order related toForm.onChanged.Related Issue
Fixes DropdownButtonFormField changes not absorbing Form onChanged Function
Tests
Documentation only