-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Marks Mac plugin_test_android_standard to be unflaky #175166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the CI configuration to mark the Mac plugin_test_android_standard test as stable. This is achieved by removing the bringup: true property for the test in .ci.yaml. According to the pull request description, this change is warranted as the test has passed for 50 consecutive runs. The change is correct and aligns with the repository's process for managing test flakiness.
flutter/flutter@a082096...5a6a1bf 2025-09-11 [email protected] Roll Dart SDK from 42045594dbc6 to f7d6a4732ab0 (2 revisions) (flutter/flutter#175222) 2025-09-11 [email protected] Roll Skia from 00c8b3f69de9 to ead9277819fc (2 revisions) (flutter/flutter#175221) 2025-09-11 [email protected] Roll Skia from 4a8817a48b25 to 00c8b3f69de9 (3 revisions) (flutter/flutter#175213) 2025-09-11 [email protected] Roll Fuchsia Linux SDK from 10x-JGF5zuuW8ik4K... to 1pTB3J5rn4YYugylf... (flutter/flutter#175210) 2025-09-11 [email protected] Roll Dart SDK from 1de2289e49fe to 42045594dbc6 (1 revision) (flutter/flutter#175203) 2025-09-10 [email protected] Roll Skia from cbb0388767d2 to 4a8817a48b25 (4 revisions) (flutter/flutter#175202) 2025-09-10 [email protected] Roll Skia from 55c9d697da52 to cbb0388767d2 (7 revisions) (flutter/flutter#175197) 2025-09-10 [email protected] Roll Dart SDK from f446144fb7c9 to 1de2289e49fe (3 revisions) (flutter/flutter#175192) 2025-09-10 [email protected] Roll Skia from c3a3d1e47699 to 55c9d697da52 (4 revisions) (flutter/flutter#175190) 2025-09-10 [email protected] Roll Packages from 2d651b2 to 03598e7 (5 revisions) (flutter/flutter#175185) 2025-09-10 [email protected] Roll Skia from 36f3c3fbec19 to c3a3d1e47699 (2 revisions) (flutter/flutter#175181) 2025-09-10 [email protected] Marks Linux plugin_test_android_standard to be unflaky (flutter/flutter#175163) 2025-09-10 [email protected] Roll Skia from 97497ee065e4 to 36f3c3fbec19 (5 revisions) (flutter/flutter#175178) 2025-09-10 [email protected] Marks Windows plugin_test_android_variants to be unflaky (flutter/flutter#175167) 2025-09-10 [email protected] Marks Linux plugin_test_android_variants to be unflaky (flutter/flutter#175162) 2025-09-10 [email protected] Marks Windows plugin_test_android_standard to be unflaky (flutter/flutter#175168) 2025-09-10 [email protected] Marks Mac plugin_test_android_standard to be unflaky (flutter/flutter#175166) 2025-09-10 [email protected] Marks Mac plugin_test_android_variants to be unflaky (flutter/flutter#175165) 2025-09-10 [email protected] [shell] Fix engineId not being set after hot restart (flutter/flutter#174451) 2025-09-10 [email protected] Roll Skia from 6acb8b29b60e to 97497ee065e4 (1 revision) (flutter/flutter#175152) 2025-09-10 [email protected] Roll Skia from 127786500ad0 to 6acb8b29b60e (1 revision) (flutter/flutter#175148) 2025-09-10 [email protected] Roll Skia from 04513dfdf517 to 127786500ad0 (2 revisions) (flutter/flutter#175145) 2025-09-09 [email protected] Roll Fuchsia Linux SDK from m7Qmvj5wtfPlMA8i8... to 10x-JGF5zuuW8ik4K... (flutter/flutter#175140) 2025-09-09 [email protected] Roll Skia from 416b3b42ece2 to 04513dfdf517 (5 revisions) (flutter/flutter#175137) 2025-09-09 [email protected] Roll Skia from 19ba56dde579 to 416b3b42ece2 (1 revision) (flutter/flutter#175134) 2025-09-09 [email protected] Adjust default CupertinoCheckbox size on desktop (flutter/flutter#172502) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac plugin_test_android_standard"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac%20plugin_test_android_standard%22).
This test can be marked as unflaky.
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac plugin_test_android_standard"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac%20plugin_test_android_standard%22).
This test can be marked as unflaky.
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac plugin_test_android_standard"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac%20plugin_test_android_standard%22).
This test can be marked as unflaky.
The test has been passing for 50 consecutive runs.
This test can be marked as unflaky.