Ensure that the raster thread has an EGL context before submitting the command buffer in ImageEncodingImpeller #175102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
chinmaygarde
requested changes
Sep 15, 2025
| // task runner was assigned to a new thread and no previous rendering | ||
| // task has run on that thread. | ||
| if (!(snapshot_delegate && snapshot_delegate->MakeRenderContextCurrent())) { | ||
| encode_task(fml::Status(fml::StatusCode::kFailedPrecondition, |
Member
There was a problem hiding this comment.
Shouldn't there be an early return in this case?
Member
Author
There was a problem hiding this comment.
Added the return. Also fixed handling of a case where ConvertDlImageToSkImage is being called on the IO thread and the snapshot delegate is not applicable.
chinmaygarde
approved these changes
Sep 15, 2025
…e command buffer in ImageEncodingImpeller Fixes flutter#171946
The Metal backend can support image enconding without a surface and does not require MakeRenderContextCurrent.
jason-simmons
force-pushed
the
bug_171946
branch
from
7072fc3 to
60bcdb5
Compare
jason-simmons
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 18, 2025
…mitting the command buffer in ImageEncodingImpeller (flutter/flutter#175102)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 18, 2025
…mitting the command buffer in ImageEncodingImpeller (flutter/flutter#175102)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 18, 2025
…mitting the command buffer in ImageEncodingImpeller (flutter/flutter#175102)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 18, 2025
…mitting the command buffer in ImageEncodingImpeller (flutter/flutter#175102)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 19, 2025
…mitting the command buffer in ImageEncodingImpeller (flutter/flutter#175102)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 19, 2025
…mitting the command buffer in ImageEncodingImpeller (flutter/flutter#175102)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 19, 2025
…mitting the command buffer in ImageEncodingImpeller (flutter/flutter#175102)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 19, 2025
…mitting the command buffer in ImageEncodingImpeller (flutter/flutter#175102)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 19, 2025
…mitting the command buffer in ImageEncodingImpeller (flutter/flutter#175102)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 20, 2025
…mitting the command buffer in ImageEncodingImpeller (flutter/flutter#175102)
Jaineel-Mamtora
pushed a commit
to Jaineel-Mamtora/flutter_forked
that referenced
this pull request
Sep 24, 2025
…e command buffer in ImageEncodingImpeller (flutter#175102) Fixes flutter#171946
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
…mitting the command buffer in ImageEncodingImpeller (flutter/flutter#175102)
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
…e command buffer in ImageEncodingImpeller (flutter#175102) Fixes flutter#171946
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…e command buffer in ImageEncodingImpeller (flutter#175102) Fixes flutter#171946
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171946