Skip to content

Conversation

@eyebrowsoffire
Copy link
Contributor

No description provided.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version looks right but the error's back :(

@camsim99
Copy link
Contributor

camsim99 commented Sep 8, 2025

Wait actually is that the right commit? Do bin/internal changes count as engine changes?

@eyebrowsoffire
Copy link
Contributor Author

Wait actually is that the right commit? Do bin/internal changes count as engine changes?

Looks like the issue is that the release builder failed to actually build this commit: https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Linux%20flutter_release_builder/1030/overview

@eyebrowsoffire
Copy link
Contributor Author

The previous commit failed because we hadn't made a recipes branch for this version apparently. I manually created the recipes branch and kicked off a new release builder: https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Linux%20flutter_release_builder/1031/overview

That appears to be working so far. After it completes I can retry the presubmits.

@eyebrowsoffire
Copy link
Contributor Author

Wait actually is that the right commit? Do bin/internal changes count as engine changes?

To answer this, bin/internal/release-candidate-branch.version is specifically included as part of the content aware hash and whether to build the engine.

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 8, 2025
@auto-submit auto-submit bot merged commit 155e144 into flutter:flutter-3.37-candidate.0 Sep 8, 2025
5 checks passed
renancaraujo pushed a commit to superlistapp/flutter that referenced this pull request Nov 26, 2025
@eyebrowsoffire eyebrowsoffire deleted the flutter-3.37-engine-bump branch December 12, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants