-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Bump engine version for Flutter 3.37 #175081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump engine version for Flutter 3.37 #175081
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
camsim99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version looks right but the error's back :(
|
Wait actually is that the right commit? Do bin/internal changes count as engine changes? |
Looks like the issue is that the release builder failed to actually build this commit: https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Linux%20flutter_release_builder/1030/overview |
|
The previous commit failed because we hadn't made a recipes branch for this version apparently. I manually created the recipes branch and kicked off a new release builder: https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Linux%20flutter_release_builder/1031/overview That appears to be working so far. After it completes I can retry the presubmits. |
To answer this, |
155e144
into
flutter:flutter-3.37-candidate.0
No description provided.