Skip to content

Conversation

@johnpryan
Copy link
Contributor

@johnpryan johnpryan commented Sep 5, 2025

This adds the initial version of AI rules for Flutter development to the flutter/flutter repo. These are currently published to https://docs.flutter.dev/ai/ai-rules

cc: @sethladd @rodydavis

@github-actions github-actions bot added the d: docs/ flutter/flutter/docs, for contributors label Sep 5, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an initial set of AI rules for Flutter development in a new docs/rules directory. The rules are well-structured and cover many aspects of Flutter development, from project setup to visual design. My review focuses on improving the clarity and consistency of these rules to ensure the AI can interpret them correctly. I've pointed out a contradiction in the state management guidance and suggested a clarification. I also found an unclear rule regarding image assets and proposed a more specific and actionable version.

johnpryan and others added 2 commits September 5, 2025 14:16
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@johnpryan
Copy link
Contributor Author

@gspencergoog @sethladd I think I've addressed most of the feedback that makes sense as per our conversation today. Please take another look and let me know if you have any questions, thanks!

@sethladd
Copy link
Contributor

LGTM from my side, thank you. I assume we can keep tweaking in later PRs

@sethladd sethladd self-requested a review September 15, 2025 19:32
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still
32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Just some details I noticed: they can all wait for another PR if you want.

@johnpryan johnpryan enabled auto-merge September 16, 2025 17:00
@johnpryan johnpryan added this pull request to the merge queue Sep 16, 2025
auto-merge was automatically disabled September 16, 2025 21:22

Pull Request is not mergeable

Merged via the queue into flutter:master with commit 377ed85 Sep 17, 2025
7 checks passed
@johnpryan johnpryan deleted the rules branch September 17, 2025 00:23
dixita0607 pushed a commit to dixita0607/flutter that referenced this pull request Sep 17, 2025
This adds the initial version of AI rules for Flutter development to the
flutter/flutter repo. These are currently published to
https://docs.flutter.dev/ai/ai-rules

cc: @sethladd @rodydavis

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 17, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 17, 2025
flutter/flutter@8d0b31d...8f94cb0

2025-09-17 [email protected] fix typo in comments to mention `settings.gradle/.kts` instead of `build.gradle/.kts` (flutter/flutter#175486)
2025-09-17 [email protected] replace ` Charset.forName("UTF-8")` with `StandardCharsets.UTF_8` to address linter issues (flutter/flutter#175275)
2025-09-17 [email protected] Roll Skia from 283a8ff3bca5 to a5a8f1df14bb (6 revisions) (flutter/flutter#175512)
2025-09-17 [email protected] Roll Dart SDK from 649eef6040a1 to 116f7fe72839 (3 revisions) (flutter/flutter#175474)
2025-09-17 [email protected] Roll Fuchsia Linux SDK from wzk_HjPLGu-mlg5hC... to 0_jKqLGnkILvQ5C8a... (flutter/flutter#175468)
2025-09-16 [email protected] Sync 3.35.3 and 3.35.4 notes from stable to master (flutter/flutter#175461)
2025-09-16 [email protected] Roll Dart SDK from 700de52f29a9 to 649eef6040a1 (4 revisions) (flutter/flutter#175455)
2025-09-16 [email protected] Update gradle_errors.dart to use constants defined in gradle_utils.dart (flutter/flutter#174760)
2025-09-16 [email protected] Update gradle_utils.dart to use `constant` instead of `final` (flutter/flutter#175443)
2025-09-16 [email protected] fix typo in test documentation (flutter/flutter#174292)
2025-09-16 [email protected] [benchmarks] Allow passing --local-web-sdk and --build-mode flags to benchmarks (flutter/flutter#175199)
2025-09-16 [email protected] Roll pub packages and update lockfiles (flutter/flutter#175446)
2025-09-16 [email protected] [docs] Add initial version of Flutter AI rules (flutter/flutter#175011)
2025-09-16 [email protected] Remove  redundant `public` modifier  for interface members in MouseCursorPlugin.java (flutter/flutter#175281)
2025-09-16 [email protected] Remove the unnecessary semicolon at the end of the line in `ProcessTextPlugin.java` (flutter/flutter#175280)
2025-09-16 [email protected] Remove unnecessary `toString()` call in `ImageReaderPlatformViewRenderTarget.java` (flutter/flutter#175286)
2025-09-16 [email protected] Refactor `AccessibilityBridge.java` to address linter issues (flutter/flutter#175277)
2025-09-16 [email protected] Replace `.size() == 0` with `isEmpty()` in `PlatformPlugin.java` (flutter/flutter#175285)
2025-09-16 [email protected] Allow Passing an AnimationController to CircularProgressIndicator and LinearProgressIndicator (flutter/flutter#174605)
2025-09-16 [email protected] Roll Skia from 7d160bbf9403 to 283a8ff3bca5 (11 revisions) (flutter/flutter#175436)
2025-09-16 [email protected] chore: move engine docs out of engine/ and into docs/ (flutter/flutter#175195)
2025-09-16 [email protected] [Impeller] Disable the render target cache when creating a snapshot in DlImageImpeller::MakeFromYUVTextures (flutter/flutter#174912)
2025-09-16 [email protected] Remove redundant public modifier in `PlatformViewRenderTarget.java` (flutter/flutter#175284)
2025-09-16 [email protected] Update NDK to The Latest Stable (flutter/flutter#175365)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
This adds the initial version of AI rules for Flutter development to the
flutter/flutter repo. These are currently published to
https://docs.flutter.dev/ai/ai-rules

cc: @sethladd @rodydavis

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Jaineel-Mamtora pushed a commit to Jaineel-Mamtora/flutter_forked that referenced this pull request Sep 24, 2025
This adds the initial version of AI rules for Flutter development to the
flutter/flutter repo. These are currently published to
https://docs.flutter.dev/ai/ai-rules

cc: @sethladd @rodydavis

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
This adds the initial version of AI rules for Flutter development to the
flutter/flutter repo. These are currently published to
https://docs.flutter.dev/ai/ai-rules

cc: @sethladd @rodydavis

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

d: docs/ flutter/flutter/docs, for contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants