Make sure that an ElevatedButton doesn't crash in 0x0 environment #175006
Conversation
github-actions
bot
added
framework
ahmedsameha1
force-pushed
the
handle#6537-ElevatedButton
branch
from
2816736 to
cb59c3e
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a regression test to packages/flutter/test/material/elevated_button_test.dart. The new test, ElevatedButton does not crash at zero area, verifies that rendering an ElevatedButton within a zero-sized SizedBox does not cause a crash. My review includes a suggestion to add an explicit assertion to the test to improve its clarity and robustness.
| ), | ||
| ), | ||
| ); | ||
| expect(tester.getSize(find.byType(ElevatedButton)), Size.zero); |
There was a problem hiding this comment.
To make the test's intent more explicit, it's a good practice to add an expect assertion to verify that no exceptions were thrown. This aligns with other crash regression tests in this file and follows the principle of writing effective tests.1
expect(tester.takeException(), isNull);
});Style Guide References
Footnotes
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
Checklist:
- The test is in the correct file
- The test name goes “does not crash at zero area”
- The target widget is wrapped by
Center(or is fullscreen) - The target widget does not have an overlay, or the overlay is tested
- The target widget is expected to have a size of exactly
Size.zero
dkwingsmt
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/175006, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
dkwingsmt
force-pushed
the
handle#6537-ElevatedButton
branch
from
87ea97e to
bf41ebc
Compare
dkwingsmt
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/175006, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
dkwingsmt
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
…utter#175006) This is my attempt to handle flutter#6537 for the ElevatedButton widget. Co-authored-by: Tong Mu <[email protected]>
3 participants
This is my attempt to handle #6537 for the ElevatedButton widget.